All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Jesse T <mr.bossman075@gmail.com>
Cc: Fabio Estevam <festevam@gmail.com>,
	Giulio Benetti <giulio.benetti@benettiengineering.com>,
	maeva.manuel@oss.nxp.com, stephane.viau@oss.nxp.com,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2] configs/imxrt1050-evk: New defconfig
Date: Tue, 2 Aug 2022 09:46:16 +0200	[thread overview]
Message-ID: <20220802094616.2a60881c@windsurf> (raw)
In-Reply-To: <CAJFTR8SkMjAe1=V411g9BmdzYDZv+5mtLMQ29w=2BJj4LS1sWw@mail.gmail.com>

Hello Jesse,

On Mon, 1 Aug 2022 17:46:48 -0400
Jesse T <mr.bossman075@gmail.com> wrote:

> > Any reason to add Giulio here?  
> 
> We worked on Linux and U-Boot together.

Then I think it is worth mentioning in the commit log, as it is
surprising to see two people added in the DEVELOPERS file, without any
explanation.

> > Why is this test needed? The Image file will be produced by the kernel
> > build, so it should be there. If it's not, we should really error out
> > hard. So I think doing without the test is better.  
> 
> I was using board/nexbox/a95x/post-build.sh as a base, I can drop it.

Yes, I think this test doesn't make sense, so you can drop it.

> > > +# Filesystem
> > > +BR2_TARGET_ROOTFS_EXT2=y
> > > +BR2_TARGET_ROOTFS_EXT2_4=y
> > > +BR2_TARGET_ROOTFS_EXT2_LABEL="root"
> > > +BR2_TARGET_ROOTFS_EXT2_SIZE="3M"  
> >
> > Why limit to 3 MB ? Is there a strong reason?  
> 
> Because that's the nearest ceil(MB) size of the ext4 filesystem.
> I like dd-ing the images fast.

You can use bmap-tools to speed up writing a SD card image that is
large but mostly empty.

> https://patchwork.ozlabs.org/project/uboot/patch/20220712110023.3163770-1-andre.przywara@arm.com/
> 
> The patch above removes the need for binutils 2.36 and a U-Boot
> version hasn't been released with that commit yet.
> This is the reason for no U-Boot version.

As explained by Giulio, you should use a well-defined version of
U-Boot, and backport the U-Boot patch.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2022-08-02  7:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-30  6:12 [Buildroot] [PATCH v2] configs/imxrt1050-evk: New defconfig Jesse Taube
2022-08-01 20:50 ` Thomas Petazzoni via buildroot
2022-08-01 21:46   ` Jesse T
2022-08-01 22:05     ` Giulio Benetti
2022-08-01 23:18       ` Giulio Benetti
2022-08-02  7:46     ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220802094616.2a60881c@windsurf \
    --to=buildroot@buildroot.org \
    --cc=festevam@gmail.com \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=maeva.manuel@oss.nxp.com \
    --cc=mr.bossman075@gmail.com \
    --cc=stephane.viau@oss.nxp.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.