From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48F197F for ; Tue, 2 Aug 2022 15:06:59 +0000 (UTC) Received: by mail-io1-f51.google.com with SMTP id v185so10814698ioe.11 for ; Tue, 02 Aug 2022 08:06:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=x3XCynuR0M/TShCzZqty0IPaAPxLKscWE0q3SESViQY=; b=xHs1aK+EJYH1/ribX9j7opG2kRihWYghHf/QtpZvKArio6Lxyr/o2/gZG+IU1rpAul 1yA9EGkPr79gnribYgriJ1Hyi2ttgPSRlFQbcuONdhADoplJiIAFn281Lh6ObOvhgfCE jf7L7RXbTxE2iwqBCxTIZwvLIlsGsy1mbdhdf8UyNPP7u3UNVsfKBl/ZsEQ3aj9fwUny cBQpcn1d7YGv+7G4IbOFkbJRJZPWQj+nehuS0iflYvApJefYhnwKPQ5BpMwpeolbyyIW 4BZju0/GOv9EgWm2pyYS5oyhzNQUGJdYVUjuMaJzrsjkseFusHN/nSTZ8itlObIqoSe5 sm1A== X-Gm-Message-State: AJIora8Uit/YMwGODdA070DptzWOF4XOABNDc32MNX2IaLEOYzX7G4Kq 2J4Yxv/QJN6mgSdDHOv2qA== X-Google-Smtp-Source: AGRyM1sKUi6tiTehYE0cNjPculTasu4AM874RxolsEPrxNCFivhQUiMOpXnNKOlKQq9dYYA+GOxGFQ== X-Received: by 2002:a05:6638:1305:b0:33f:7e59:4bc7 with SMTP id r5-20020a056638130500b0033f7e594bc7mr7940473jad.316.1659452818161; Tue, 02 Aug 2022 08:06:58 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id q28-20020a02a99c000000b0033a29ec646dsm6568358jam.4.2022.08.02.08.06.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Aug 2022 08:06:57 -0700 (PDT) Received: (nullmailer pid 112022 invoked by uid 1000); Tue, 02 Aug 2022 15:06:56 -0000 Date: Tue, 2 Aug 2022 09:06:56 -0600 From: Rob Herring To: Samuel Holland Cc: Liam Girdwood , Mark Brown , Chen-Yu Tsai , Jernej Skrabec , Krzysztof Kozlowski , Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v2 1/4] dt-bindings: sram: sunxi-sram: Add optional regulators child Message-ID: <20220802150656.GB86158-robh@kernel.org> References: <20220802053213.3645-1-samuel@sholland.org> <20220802053213.3645-2-samuel@sholland.org> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220802053213.3645-2-samuel@sholland.org> On Tue, Aug 02, 2022 at 12:32:10AM -0500, Samuel Holland wrote: > Some sunxi SoCs have in-package regulators controlled by a register in > the system control MMIO block. Allow a child node for these regulators > in addition to SRAM child nodes. > > Signed-off-by: Samuel Holland > --- > > Changes in v2: > - New patch for v2 > > .../bindings/sram/allwinner,sun4i-a10-system-control.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml b/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml > index 1c426c211e36..cc57836b2906 100644 > --- a/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml > +++ b/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml > @@ -56,6 +56,9 @@ properties: > > ranges: true > > + regulators: > + type: object This should reference the regulator schema. Also, it's preferred to have 1 complete example here rather than piecemeal examples in each child schema. > + > patternProperties: > "^sram@[a-z0-9]+": > type: object > -- > 2.35.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB5EDC00140 for ; Tue, 2 Aug 2022 15:08:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZqjboJ1k/23bHCVfgmZO2Bl4Yh+Tj23G7Tme60fnUM8=; b=qu7HsmHyHfB5H9 V0s5v2JMIddPcBMaXrySAVR64p/a/vh1jEH4qL5SCUVtQkLLwS0qkpnwWyDoN+/Gg3wIK9W/56LzA +q/YutWjtHcWpdFjxYyndUIkuxlrCzvp+AgD5rl5CQt8+s98R8r+HuSe29lM751DRUVCugzxzzX0U Q/K052vaNuQEXA5JMyguhzPnEKiSt9Fcs86nGaryPJEkLHbu5QxjgRB7xGqmPhz3FM/pjRbLGwel3 c3p91oj0slWVbyfB4WHadfEqRJX0Nfn2F7F9vzVI+EWXiosPXCD9AB2IizjOMSg4uBgsPASCJPO9D /+vH9VU8dlvwPOy26I/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oItU9-00FEY9-Gv; Tue, 02 Aug 2022 15:07:05 +0000 Received: from mail-io1-f49.google.com ([209.85.166.49]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oItU5-00FEV4-Rh for linux-arm-kernel@lists.infradead.org; Tue, 02 Aug 2022 15:07:03 +0000 Received: by mail-io1-f49.google.com with SMTP id d76so2229429iof.12 for ; Tue, 02 Aug 2022 08:06:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=x3XCynuR0M/TShCzZqty0IPaAPxLKscWE0q3SESViQY=; b=FWFRduuy3VODIRwbZZgVUDCxGRoD7UDOxQi5bKPR7uj2JLuYQfqxlBPCXps1F44Stx ozNC3yooTt4cZRNySzW6jgFURZ97L+gFg03BQAgVX6/Jsh2JG1aNuCGWcxTczBRy8CMz YH5sllPYWTF9k6Alk/PdOeT5TJvK3fRJ3irC/zi3sCCgV3GzuhcxVOIg+qAYc/2i6DIr qphucO87w1vpuguxDFKdG2wUgLjx7xoH+TsYMc0olk3THisHUTrIDx3OiMLKCt3+AnRJ qRUpJnk+Gg4sZ40DduV7SKyc6Cnfpagj2DLNxoBsm3jEgHgiuqjAb0lM85tbccI/x/jO wMXw== X-Gm-Message-State: AJIora8J0t9e2Y2w2+jNgvkTJ06mv+zl8lhf/ylXNrsG75ULygmY4ovq Kn6h+GK8H8mBBK+8WFcjng== X-Google-Smtp-Source: AGRyM1sKUi6tiTehYE0cNjPculTasu4AM874RxolsEPrxNCFivhQUiMOpXnNKOlKQq9dYYA+GOxGFQ== X-Received: by 2002:a05:6638:1305:b0:33f:7e59:4bc7 with SMTP id r5-20020a056638130500b0033f7e594bc7mr7940473jad.316.1659452818161; Tue, 02 Aug 2022 08:06:58 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id q28-20020a02a99c000000b0033a29ec646dsm6568358jam.4.2022.08.02.08.06.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Aug 2022 08:06:57 -0700 (PDT) Received: (nullmailer pid 112022 invoked by uid 1000); Tue, 02 Aug 2022 15:06:56 -0000 Date: Tue, 2 Aug 2022 09:06:56 -0600 From: Rob Herring To: Samuel Holland Cc: Liam Girdwood , Mark Brown , Chen-Yu Tsai , Jernej Skrabec , Krzysztof Kozlowski , Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v2 1/4] dt-bindings: sram: sunxi-sram: Add optional regulators child Message-ID: <20220802150656.GB86158-robh@kernel.org> References: <20220802053213.3645-1-samuel@sholland.org> <20220802053213.3645-2-samuel@sholland.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220802053213.3645-2-samuel@sholland.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220802_080701_927104_D67A50A5 X-CRM114-Status: GOOD ( 18.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 02, 2022 at 12:32:10AM -0500, Samuel Holland wrote: > Some sunxi SoCs have in-package regulators controlled by a register in > the system control MMIO block. Allow a child node for these regulators > in addition to SRAM child nodes. > > Signed-off-by: Samuel Holland > --- > > Changes in v2: > - New patch for v2 > > .../bindings/sram/allwinner,sun4i-a10-system-control.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml b/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml > index 1c426c211e36..cc57836b2906 100644 > --- a/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml > +++ b/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml > @@ -56,6 +56,9 @@ properties: > > ranges: true > > + regulators: > + type: object This should reference the regulator schema. Also, it's preferred to have 1 complete example here rather than piecemeal examples in each child schema. > + > patternProperties: > "^sram@[a-z0-9]+": > type: object > -- > 2.35.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel