From: Stephen Hemminger <stephen@networkplumber.org>
To: sunsuwan <sunsuwan3@huawei.com>
Cc: <netdev@vger.kernel.org>, <chenzhen126@huawei.com>,
<liaichun@huawei.com>, <yanan@huawei.com>, <roopa@nvidia.com>,
<nikolay@nvidia.com>, <davem@davemloft.net>, <kuba@kernel.org>
Subject: Re: [PATCH] bridge-utils:close socket before exit
Date: Wed, 3 Aug 2022 08:25:57 -0700 [thread overview]
Message-ID: <20220803082557.451637d4@hermes.local> (raw)
In-Reply-To: <20220803082051.1704227-1-sunsuwan3@huawei.com>
On Wed, 3 Aug 2022 16:20:51 +0800
sunsuwan <sunsuwan3@huawei.com> wrote:
> brctl should close socket before exit.
>
> Signed-off-by: sunsuwan <sunsuwan3@huawei.com>
Why bother? The file descriptor is closed automatically on process exit.
At this point bridge-utils is in long term hibernation mode.
It has been replaced by bridge command in iproute2.
Don't want to do any changes or releases unless there is a very high priority
bug that must be fixed.
prev parent reply other threads:[~2022-08-03 15:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 8:20 [PATCH] bridge-utils:close socket before exit sunsuwan
2022-08-03 15:25 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220803082557.451637d4@hermes.local \
--to=stephen@networkplumber.org \
--cc=chenzhen126@huawei.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=liaichun@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=roopa@nvidia.com \
--cc=sunsuwan3@huawei.com \
--cc=yanan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.