From: Stephen Hemminger <stephen@networkplumber.org>
To: Naga Harish K S V <s.v.naga.harish.k@intel.com>
Cc: erik.g.carrillo@intel.com, dev@dpdk.org
Subject: Re: [PATCH 3/4] timer: fix rte_timer_stop_all
Date: Wed, 3 Aug 2022 10:49:06 -0700 [thread overview]
Message-ID: <20220803104906.4013d349@hermes.local> (raw)
In-Reply-To: <20220803162651.3145945-1-s.v.naga.harish.k@intel.com>
On Wed, 3 Aug 2022 11:26:51 -0500
Naga Harish K S V <s.v.naga.harish.k@intel.com> wrote:
> there is a possibility of deadlock in this api,
> as same spinlock is tried to be acquired in nested manner.
>
> This patch removes the acquisition of nested locking.
>
> Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
The wording in this commit message is a little confusing, what is
the exact lock conflict?
After your patch, there are no longer any callers for __rte_timer_stop()
with the local_is_locked flag. Please resubmit and remove all the
the local_is_locked from __rte_timer_stop().
It looks like the test suite for rte_timer is not exercising all
the exposed API's. That's a problem
next prev parent reply other threads:[~2022-08-03 17:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 16:26 [PATCH 3/4] timer: fix rte_timer_stop_all Naga Harish K S V
2022-08-03 17:49 ` Stephen Hemminger [this message]
2022-08-10 7:20 ` Naga Harish K, S V
2022-08-10 7:09 ` [PATCH v2 3/4] timer: fix function to stop all timers Naga Harish K S V
2022-08-10 19:29 ` Carrillo, Erik G
2022-08-10 19:38 ` Stephen Hemminger
2022-08-11 15:42 ` Naga Harish K, S V
2022-08-11 15:37 ` [PATCH v3 " Naga Harish K S V
2022-08-12 16:07 ` [PATCH v4 " Naga Harish K S V
2022-08-18 13:12 ` Carrillo, Erik G
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220803104906.4013d349@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=s.v.naga.harish.k@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.