From: "Michael S. Tsirkin" <mst@redhat.com>
To: bchalios@amazon.es
Cc: qemu-devel@nongnu.org, ani@anisinha.ca, imammedo@redhat.com,
dwmw@amazon.co.uk, graf@amazon.de, xmarcalx@amazon.co.uk
Subject: Re: [PATCH 0/2] vmgenid: add generation counter
Date: Wed, 3 Aug 2022 11:36:32 -0400 [thread overview]
Message-ID: <20220803113537-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20220803134147.31073-1-bchalios@amazon.es>
On Wed, Aug 03, 2022 at 03:41:45PM +0200, bchalios@amazon.es wrote:
> From: Babis Chalios <bchalios@amazon.es>
>
> VM generation ID exposes a GUID inside the VM which changes every time a
> VM restore is happening. Typically, this GUID is used by the guest
> kernel to re-seed its internal PRNG. As a result, this value cannot be
> exposed in guest user-space as a notification mechanism for VM restore
> events.
>
> This patch set extends vmgenid to introduce a 32 bits generation counter
> whose purpose is to be used as a VM restore notification mechanism for
> the guest user-space.
>
> It is true that such a counter could be implemented entirely by the
> guest kernel, but this would rely on the vmgenid ACPI notification to
> trigger the counter update, which is inherently racy. Exposing this
> through the monitor allows the updated value to be in-place before
> resuming the vcpus, so interested user-space code can (atomically)
> observe the update without relying on the ACPI notification.
Producing another 4 bytes is not really the issue, the issue
is how does guest consume this.
So I would like this discussion to happen on the linux kernel mailing
list not just here. Can you post the linux patch please?
> Babis Chalios (2):
> vmgenid: make device data size configurable
> vmgenid: add generation counter
>
> docs/specs/vmgenid.txt | 101 ++++++++++++++++++--------
> hw/acpi/vmgenid.c | 145 +++++++++++++++++++++++++++++++-------
> include/hw/acpi/vmgenid.h | 23 ++++--
> 3 files changed, 204 insertions(+), 65 deletions(-)
>
> --
> 2.37.1
>
> Amazon Spain Services sociedad limitada unipersonal, Calle Ramirez de Prado 5, 28045 Madrid. Registro Mercantil de Madrid . Tomo 22458 . Folio 102 . Hoja M-401234 . CIF B84570936
next prev parent reply other threads:[~2022-08-03 15:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 13:41 [PATCH 0/2] vmgenid: add generation counter bchalios
2022-08-03 13:41 ` [PATCH 1/2] vmgenid: make device data size configurable bchalios
2022-08-03 13:41 ` [PATCH 2/2] vmgenid: add generation counter bchalios
2022-08-03 15:36 ` Michael S. Tsirkin [this message]
2022-08-03 16:17 ` [PATCH 0/2] " bchalios
2022-08-03 16:26 ` Daniel P. Berrangé
2022-08-04 9:54 ` Chalios, Babis
2022-08-04 10:02 ` Daniel P. Berrangé
2022-08-04 10:17 ` Chalios, Babis
2022-08-04 13:31 ` Chalios, Babis
2022-08-07 15:39 ` Michael Kelley (LINUX)
2022-08-04 15:01 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220803113537-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=ani@anisinha.ca \
--cc=bchalios@amazon.es \
--cc=dwmw@amazon.co.uk \
--cc=graf@amazon.de \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xmarcalx@amazon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.