From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Buildroot List <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH] Makefile: ignore *.orig and *.rej in check-package target
Date: Wed, 3 Aug 2022 22:59:26 +0200 [thread overview]
Message-ID: <20220803205926.GA3321867@scaer> (raw)
In-Reply-To: <20220803192400.208270-1-thomas.petazzoni@bootlin.com>
Thomas, All,
On 2022-08-03 21:23 +0200, Thomas Petazzoni via buildroot spake thusly:
> When one is applying patches, it is pretty common to end up with .orig
> and/or .rej files lying around. Unfortunately, our 'Config.*' match in
> check-package ends up matching those files, causing false positives
> when running "make check-package". To avoid this, this commit
> excludes *.orig and *.rej files for the find logic used in the
> check-package target.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index 5f266e36b2..14b7ecd475 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1253,6 +1253,7 @@ check-flake8:
>
> check-package:
> find $(TOPDIR) -type f \( -name '*.mk' -o -name '*.hash' -o -name 'Config.*' -o -name '*.patch' \) \
> + -a -not -name '*.orig' -a -not -name '*.rej' \
I was wondering if we could have easily used 'git ls-tree' like is done
in check-flake8, but that is not so trivial. Indeed, check-flake8
filters absed on the content of files, so it needs to find all of our
files, while check-package filters on filename, and so the filtering
would become a bit more convoluted with 'git ls-tree' than it is with
'find'.
Applied to master, thanks (and of course, I forgot to add the above to
the commit log before pushing).
Regards,
Yann E. MORIN.
> -exec ./utils/check-package --exclude=Sob {} +
>
> include docs/manual/manual.mk
> --
> 2.37.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-08-03 20:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 19:23 [Buildroot] [PATCH] Makefile: ignore *.orig and *.rej in check-package target Thomas Petazzoni via buildroot
2022-08-03 20:59 ` Yann E. MORIN [this message]
2022-09-14 9:36 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220803205926.GA3321867@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.