From: Lai Jiangshan <jiangshanlai@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Lai Jiangshan <jiangshan.ljs@antgroup.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Tejun Heo <tj@kernel.org>, Petr Mladek <pmladek@suse.com>,
Michal Hocko <mhocko@suse.com>,
Peter Zijlstra <peterz@infradead.org>,
Wedson Almeida Filho <wedsonaf@google.com>
Subject: [RFC PATCH 0/8] workqueue: Fix for prematurely wakeups and cleanups
Date: Thu, 4 Aug 2022 16:41:27 +0800 [thread overview]
Message-ID: <20220804084135.92425-1-jiangshanlai@gmail.com> (raw)
From: Lai Jiangshan <jiangshan.ljs@antgroup.com>
Patch1-3 are fixes for prematurely wakeups and patch4-8 are cleanups.
Patch2 fixes when prematurely wakeup happens after kthread_bind_mask().
Patch3 fixes when prematurely wakeup happens before kthread_bind_mask().
Patch1 prepares for patch2-3.
Like Petr's patch[1], a completion is introduced to do the synchronization,
but the synchronization is done in a different direction which allows the
newly created worker itself do some initialization instead of the manager
and allows for a more simplified code.
(The changed synchronization direction is not necessarily better.)
And make workqueue code less dependence on the semantics that kthread
provides.
[1]: https://lore.kernel.org/all/20220622140853.31383-1-pmladek@suse.com/
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Tejun Heo <tj@kernel.org>,
Cc: Petr Mladek <pmladek@suse.com>
Cc: Michal Hocko <mhocko@suse.com>,
Cc: Peter Zijlstra <peterz@infradead.org>,
Cc: Wedson Almeida Filho <wedsonaf@google.com>
Lai Jiangshan (8):
workqueue: Unconditionally set cpumask in worker_attach_to_pool()
workqueue: Make create_worker() safe against prematurely wakeups
workqueue: Set PF_NO_SETAFFINITY instead of kthread_bind_mask()
workqueue: Set/Clear PF_WQ_WORKER while attaching/detaching
workqueue: Use worker_set_flags() in worker_enter_idle()
workqueue: Simplify the starting of the newly created worker
workqueue: Remove the outer loop in maybe_create_worker()
workqueue: Move the locking out of maybe_create_worker()
kernel/workqueue.c | 123 +++++++++++++++---------------------
kernel/workqueue_internal.h | 11 +++-
2 files changed, 60 insertions(+), 74 deletions(-)
--
2.19.1.6.gb485710b
next reply other threads:[~2022-08-04 8:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 8:41 Lai Jiangshan [this message]
2022-08-04 8:41 ` [RFC PATCH 1/8] workqueue: Unconditionally set cpumask in worker_attach_to_pool() Lai Jiangshan
2022-08-16 21:18 ` Tejun Heo
2022-08-18 14:39 ` Lai Jiangshan
2022-09-12 7:54 ` Peter Zijlstra
2022-08-04 8:41 ` [RFC PATCH 2/8] workqueue: Make create_worker() safe against prematurely wakeups Lai Jiangshan
2022-08-04 12:35 ` Hillf Danton
2022-08-05 2:30 ` Lai Jiangshan
2022-08-06 8:02 ` Hillf Danton
2022-08-16 21:46 ` Tejun Heo
2022-08-04 8:41 ` [RFC PATCH 3/8] workqueue: Set PF_NO_SETAFFINITY instead of kthread_bind_mask() Lai Jiangshan
2022-08-04 8:41 ` [RFC PATCH 4/8] workqueue: Set/Clear PF_WQ_WORKER while attaching/detaching Lai Jiangshan
2022-08-04 8:41 ` [RFC PATCH 5/8] workqueue: Use worker_set_flags() in worker_enter_idle() Lai Jiangshan
2022-08-04 8:41 ` [RFC PATCH 6/8] workqueue: Simplify the starting of the newly created worker Lai Jiangshan
2022-08-04 8:41 ` [RFC PATCH 7/8] workqueue: Remove the outer loop in maybe_create_worker() Lai Jiangshan
2022-08-16 22:08 ` Tejun Heo
2022-08-18 14:44 ` Lai Jiangshan
2022-08-19 17:29 ` Tejun Heo
2022-08-04 8:41 ` [RFC PATCH 8/8] workqueue: Move the locking out of maybe_create_worker() Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220804084135.92425-1-jiangshanlai@gmail.com \
--to=jiangshanlai@gmail.com \
--cc=ebiederm@xmission.com \
--cc=jiangshan.ljs@antgroup.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=wedsonaf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.