From: Mel Gorman <mgorman@suse.de>
To: Ingo Molnar <mingo@kernel.org>
Cc: Libo Chen <libo.chen@oracle.com>,
K Prateek Nayak <kprateek.nayak@amd.com>,
peterz@infradead.org, vincent.guittot@linaro.org,
tim.c.chen@linux.intel.com, 21cnbao@gmail.com,
dietmar.eggemann@arm.com, linux-kernel@vger.kernel.org,
tglx@linutronix.de
Subject: Re: [PATCH] sched/fair: no sync wakeup from interrupt context
Date: Thu, 4 Aug 2022 10:51:50 +0100 [thread overview]
Message-ID: <20220804095150.GG3493@suse.de> (raw)
In-Reply-To: <YuuJcFkUVUfDvcYB@gmail.com>
On Thu, Aug 04, 2022 at 10:55:12AM +0200, Ingo Molnar wrote:
>
> * Libo Chen <libo.chen@oracle.com> wrote:
>
> > Oh yes, I have no issue with holding the patch back until the regression
> > is fully understood. I was just a little confused on your reference to
> > Mel's comments. [...]
>
> Yeah, that was just me getting confused about which change Mel was
> referring to, as I was looking for external confirmation saying what I was
> thinking about the patch: in_task()/in_interrupt() heuristics rarely do
> well. ;-)
>
Even though I was referring to something else, the reported regression
is still a regression. Prateek's report and what I brought up in
https://lore.kernel.org/all/20220715100738.GD3493@suse.de/ are both simply
examples where changes to affine wakeup can have surprising results.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2022-08-04 9:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 22:47 [PATCH] sched/fair: no sync wakeup from interrupt context Libo Chen
2022-07-13 16:40 ` Tim Chen
[not found] ` <0917f479-b6aa-19de-3d6a-6fd422df4d21@oracle.com>
2022-07-13 19:34 ` Libo Chen
2022-07-13 20:51 ` Tim Chen
2022-07-13 21:37 ` Libo Chen
2022-07-14 14:18 ` Mel Gorman
2022-07-14 20:21 ` Libo Chen
2022-07-15 10:07 ` Mel Gorman
2022-07-14 11:26 ` Peter Zijlstra
2022-07-14 11:35 ` Peter Zijlstra
2022-07-14 18:18 ` Libo Chen
2022-07-21 8:44 ` [tip: sched/core] sched/fair: Disallow " tip-bot2 for Libo Chen
2022-07-29 4:47 ` [PATCH] sched/fair: no " K Prateek Nayak
2022-08-01 13:26 ` Ingo Molnar
2022-08-01 14:59 ` Libo Chen
2022-08-03 9:18 ` Ingo Molnar
2022-08-03 19:37 ` Libo Chen
2022-08-04 8:55 ` Ingo Molnar
2022-08-04 9:51 ` Mel Gorman [this message]
2022-08-01 14:57 ` Libo Chen
2022-08-02 4:40 ` K Prateek Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220804095150.GG3493@suse.de \
--to=mgorman@suse.de \
--cc=21cnbao@gmail.com \
--cc=dietmar.eggemann@arm.com \
--cc=kprateek.nayak@amd.com \
--cc=libo.chen@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.