From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF9C9C3F6B0 for ; Thu, 4 Aug 2022 10:49:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229575AbiHDKtd (ORCPT ); Thu, 4 Aug 2022 06:49:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238145AbiHDKta (ORCPT ); Thu, 4 Aug 2022 06:49:30 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5309E5019F for ; Thu, 4 Aug 2022 03:49:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 01150B824E4 for ; Thu, 4 Aug 2022 10:49:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F576C43470; Thu, 4 Aug 2022 10:49:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659610166; bh=NRYgkbOBZl35JeLYiTrlSXLZ0yPBiRFJgFdAcvvkHxU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g2ik1eaEM/rZo+hFWBRmv3Rk+FDT+ZJALZe7ymjJyFELnmquWZgpeqcp991scGS8l 5o1Tw95zcFU2HSUVE+5coEt2Cw/+tqdI281hr5yBGGN9A1azI7n33or5w7DSnU0dLf FamgLbC9AnUfZwDPndvH31IKMBrug8ZWJktIA0vovLV5pMb/y8tA8Szmh903v2v5ZJ VLND6qC1KDVC4gHhCjM7mO6Vf0oayXaYXYWZynBi5OXffA78vBbE8lD92KdKYviqwv Kyj84Y5MHLAzF5SPdCUP9yQRypFl61tC2HSZsudY2+zVJy3DeEnx2TOa+maRzxG6nt aUQqnLrkpzpUA== Received: by pali.im (Postfix) id 0FF91B01; Thu, 4 Aug 2022 12:49:24 +0200 (CEST) From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Linus Walleij Cc: =?UTF-8?q?Marek=20Beh=C3=BAn?= , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org Subject: [PATCH 3/4] pinctrl: armada-37xx: Checks for errors in gpio_request_enable callback Date: Thu, 4 Aug 2022 12:49:14 +0200 Message-Id: <20220804104915.23719-3-pali@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220804104915.23719-1-pali@kernel.org> References: <20220804104915.23719-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Now when all MPP pins are properly defined and every MPP pin has GPIO function, always checks for errors in armada_37xx_gpio_request_enable() function when calling armada_37xx_pmx_set_by_name(). Function armada_37xx_pmx_set_by_name() should not return "not supported" error anymore for any GPIO pin when requesting GPIO mode. Fixes: 87466ccd9401 ("pinctrl: armada-37xx: Add pin controller support for Armada 37xx") Signed-off-by: Pali Rohár --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c index e5e5f0ea0e77..8978e6c15905 100644 --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c @@ -503,8 +503,11 @@ static int armada_37xx_gpio_request_enable(struct pinctrl_dev *pctldev, dev_dbg(info->dev, "requesting gpio %d\n", offset); - while ((group = armada_37xx_find_next_grp_by_pin(info, offset, &grp))) - armada_37xx_pmx_set_by_name(pctldev, "gpio", group); + while ((group = armada_37xx_find_next_grp_by_pin(info, offset, &grp))) { + ret = armada_37xx_pmx_set_by_name(pctldev, "gpio", group); + if (ret) + return ret; + } return 0; } -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71CB1C19F2B for ; Thu, 4 Aug 2022 10:50:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JdAC+88NGhF3DUapQ97SLZedTyaevMfw5Zs7sFV5tgg=; b=LYqC9Ivhi4WWWP 6G5I/kBC/fJrtxXn2Dl7b5ELcSODwUxnni9yaMxTPuu8FTZWEhw6cWveXh7k9Q934J8ljw51axXE2 GiuERthADlSzbUEqF2lHDKDGEt9SbMTW3Bx2es/2/WooB3U05Af602N+I7QwQs6LYOW0eOqU6Axm0 vx8498kgHyGArnfFj+dXH6mixhtl22yVS6hXZ4zAJEecwxdyOuhGWSQhpe2ATHcASKKFSArAmX5dT H90oWaJfYcPpN0t2f+cCCKpe30N1ACGUtRNXJEP9DqUIsJxakqAUOe0VsEYrUQXnXfF3D0x5J/NG5 i3wjTmjH7Rz6A0KTIPCA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJYPz-005Kqx-Gz; Thu, 04 Aug 2022 10:49:31 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJYPw-005Kot-09 for linux-arm-kernel@lists.infradead.org; Thu, 04 Aug 2022 10:49:29 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 466C8616C9; Thu, 4 Aug 2022 10:49:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F576C43470; Thu, 4 Aug 2022 10:49:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659610166; bh=NRYgkbOBZl35JeLYiTrlSXLZ0yPBiRFJgFdAcvvkHxU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g2ik1eaEM/rZo+hFWBRmv3Rk+FDT+ZJALZe7ymjJyFELnmquWZgpeqcp991scGS8l 5o1Tw95zcFU2HSUVE+5coEt2Cw/+tqdI281hr5yBGGN9A1azI7n33or5w7DSnU0dLf FamgLbC9AnUfZwDPndvH31IKMBrug8ZWJktIA0vovLV5pMb/y8tA8Szmh903v2v5ZJ VLND6qC1KDVC4gHhCjM7mO6Vf0oayXaYXYWZynBi5OXffA78vBbE8lD92KdKYviqwv Kyj84Y5MHLAzF5SPdCUP9yQRypFl61tC2HSZsudY2+zVJy3DeEnx2TOa+maRzxG6nt aUQqnLrkpzpUA== Received: by pali.im (Postfix) id 0FF91B01; Thu, 4 Aug 2022 12:49:24 +0200 (CEST) From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Linus Walleij Cc: =?UTF-8?q?Marek=20Beh=C3=BAn?= , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org Subject: [PATCH 3/4] pinctrl: armada-37xx: Checks for errors in gpio_request_enable callback Date: Thu, 4 Aug 2022 12:49:14 +0200 Message-Id: <20220804104915.23719-3-pali@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220804104915.23719-1-pali@kernel.org> References: <20220804104915.23719-1-pali@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220804_034928_119756_0BC368DC X-CRM114-Status: GOOD ( 13.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Tm93IHdoZW4gYWxsIE1QUCBwaW5zIGFyZSBwcm9wZXJseSBkZWZpbmVkIGFuZCBldmVyeSBNUFAg cGluIGhhcyBHUElPCmZ1bmN0aW9uLCBhbHdheXMgY2hlY2tzIGZvciBlcnJvcnMgaW4gYXJtYWRh XzM3eHhfZ3Bpb19yZXF1ZXN0X2VuYWJsZSgpCmZ1bmN0aW9uIHdoZW4gY2FsbGluZyBhcm1hZGFf Mzd4eF9wbXhfc2V0X2J5X25hbWUoKS4gRnVuY3Rpb24KYXJtYWRhXzM3eHhfcG14X3NldF9ieV9u YW1lKCkgc2hvdWxkIG5vdCByZXR1cm4gIm5vdCBzdXBwb3J0ZWQiIGVycm9yCmFueW1vcmUgZm9y IGFueSBHUElPIHBpbiB3aGVuIHJlcXVlc3RpbmcgR1BJTyBtb2RlLgoKRml4ZXM6IDg3NDY2Y2Nk OTQwMSAoInBpbmN0cmw6IGFybWFkYS0zN3h4OiBBZGQgcGluIGNvbnRyb2xsZXIgc3VwcG9ydCBm b3IgQXJtYWRhIDM3eHgiKQpTaWduZWQtb2ZmLWJ5OiBQYWxpIFJvaMOhciA8cGFsaUBrZXJuZWwu b3JnPgotLS0KIGRyaXZlcnMvcGluY3RybC9tdmVidS9waW5jdHJsLWFybWFkYS0zN3h4LmMgfCA3 ICsrKysrLS0KIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9waW5jdHJsL212ZWJ1L3BpbmN0cmwtYXJtYWRhLTM3eHgu YyBiL2RyaXZlcnMvcGluY3RybC9tdmVidS9waW5jdHJsLWFybWFkYS0zN3h4LmMKaW5kZXggZTVl NWYwZWEwZTc3Li44OTc4ZTZjMTU5MDUgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvcGluY3RybC9tdmVi dS9waW5jdHJsLWFybWFkYS0zN3h4LmMKKysrIGIvZHJpdmVycy9waW5jdHJsL212ZWJ1L3BpbmN0 cmwtYXJtYWRhLTM3eHguYwpAQCAtNTAzLDggKzUwMywxMSBAQCBzdGF0aWMgaW50IGFybWFkYV8z N3h4X2dwaW9fcmVxdWVzdF9lbmFibGUoc3RydWN0IHBpbmN0cmxfZGV2ICpwY3RsZGV2LAogCiAJ ZGV2X2RiZyhpbmZvLT5kZXYsICJyZXF1ZXN0aW5nIGdwaW8gJWRcbiIsIG9mZnNldCk7CiAKLQl3 aGlsZSAoKGdyb3VwID0gYXJtYWRhXzM3eHhfZmluZF9uZXh0X2dycF9ieV9waW4oaW5mbywgb2Zm c2V0LCAmZ3JwKSkpCi0JCWFybWFkYV8zN3h4X3BteF9zZXRfYnlfbmFtZShwY3RsZGV2LCAiZ3Bp byIsIGdyb3VwKTsKKwl3aGlsZSAoKGdyb3VwID0gYXJtYWRhXzM3eHhfZmluZF9uZXh0X2dycF9i eV9waW4oaW5mbywgb2Zmc2V0LCAmZ3JwKSkpIHsKKwkJcmV0ID0gYXJtYWRhXzM3eHhfcG14X3Nl dF9ieV9uYW1lKHBjdGxkZXYsICJncGlvIiwgZ3JvdXApOworCQlpZiAocmV0KQorCQkJcmV0dXJu IHJldDsKKwl9CiAKIAlyZXR1cm4gMDsKIH0KLS0gCjIuMjAuMQoKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBs aXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK