All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: James Prestwood <prestwoj@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [RFC 1/1] net: move IFF_LIVE_ADDR_CHANGE to public flag
Date: Thu, 4 Aug 2022 11:43:42 -0700	[thread overview]
Message-ID: <20220804114342.71d2cff0@kernel.org> (raw)
In-Reply-To: <20220804174307.448527-2-prestwoj@gmail.com>

On Thu,  4 Aug 2022 10:43:07 -0700 James Prestwood wrote:
> By exposing IFF_LIVE_ADDR_CHANGE to userspace it at least gives an
> indication that we can successfully randomize the address and
> connect. In the worst case address randomization can be avoided
> ahead of time. A secondary win is also time, since userspace can
> avoid a power down unless its required which saves some time.

It's not a generic thing tho, it's most of an implicit argument 
to eth_mac_addr(). Not all netdevs are Ethernet.

The semantics in wireless are also a little stretched because normally
if the flag is not set the netdev will _refuse_ (-EBUSY) to change the
address while running, not do some crazy fw reset.

Perhaps we should wait for Johannes to return form vacation but my
immediate reaction would be to add a knob (in wireless?) that controls
whether the reset dance is allowed.

  parent reply	other threads:[~2022-08-04 18:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-04 17:43 [RFC 0/1] Move IFF_LIVE_ADDR_CHANGE to public flag James Prestwood
2022-08-04 17:43 ` [RFC 1/1] net: move " James Prestwood
2022-08-04 17:59   ` Stephen Hemminger
2022-08-04 19:29     ` James Prestwood
2022-08-04 18:43   ` Jakub Kicinski [this message]
2022-08-04 19:23     ` James Prestwood
2022-08-04 19:49       ` James Prestwood
2022-08-09 19:04         ` Johannes Berg
2022-08-10 16:26           ` James Prestwood
2022-08-10 17:17             ` Johannes Berg
2022-08-10 17:36               ` Jakub Kicinski
2022-08-10 19:35               ` James Prestwood
2022-08-04 20:49 ` [RFC 0/1] Move " Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220804114342.71d2cff0@kernel.org \
    --to=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=prestwoj@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.