From: bfields@fieldses.org (J. Bruce Fields)
To: Chuck Lever III <chuck.lever@oracle.com>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: pynfs clean_init issue
Date: Thu, 4 Aug 2022 14:14:05 -0400 [thread overview]
Message-ID: <20220804181405.GC9019@fieldses.org> (raw)
In-Reply-To: <1C391A45-B2CC-4C90-86DD-1FB9C2000E7E@oracle.com>
On Thu, Aug 04, 2022 at 03:43:56PM +0000, Chuck Lever III wrote:
> It passes, but leaves the test file so that clean_dir does not work
> again until the old lease expires.
Oh, right.
> > But possibly cleanup should also be better.
>
> This bug might prevent running these tests in an automation harness.
> I'd say cleanup does need to be better about this.
>
> > I'm not sure what the right fix is.
>
> Brute force: keep trying to delete that file if clean_dir receives
> NFS4ERR_DELAY?
Delegations block unlinks too so that probably doesn't help.
> init_connection somewhere needs to set up a callback service and
> leave it running.
The callback isn't too important, I think, if we want to return the
delegation at the end of the test we can do that without waiting for the
server to remind us.
Or maybe destroy the client at the end. We have no DESTROY_CLIENTID
(this is 4.0), but we could do a client-rebooting SETCLIENTID/CONFIRM to
wipe out its state.
There may be limits to the kind of cleanup pynfs can do. A test harness
should probably reboot the server between test runs.
--b.
next prev parent reply other threads:[~2022-08-04 18:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 15:23 pynfs clean_init issue Chuck Lever III
2022-08-04 15:38 ` J. Bruce Fields
2022-08-04 15:43 ` Chuck Lever III
2022-08-04 18:14 ` J. Bruce Fields [this message]
2022-08-04 18:22 ` Chuck Lever III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220804181405.GC9019@fieldses.org \
--to=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.