From: Dan Carpenter <dan.carpenter@oracle.com>
To: Namjae Jeon <linkinjeon@kernel.org>
Cc: linux-cifs@vger.kernel.org
Subject: Re: [bug report] ksmbd: fix heap-based overflow in set_ntacl_dacl()
Date: Fri, 5 Aug 2022 14:42:00 +0300 [thread overview]
Message-ID: <20220805114200.GM3460@kadam> (raw)
In-Reply-To: <CAKYAXd9PDUBLvoZqS26mMKqdS6J1b-MQ6LNgy=W7POjXu_+L4Q@mail.gmail.com>
On Fri, Aug 05, 2022 at 08:03:04AM +0900, Namjae Jeon wrote:
> 2022-08-04 23:33 GMT+09:00, Dan Carpenter <dan.carpenter@oracle.com>:
> > Hello Namjae Jeon,
> Hi Dan,
> >
> > The patch 982979772f2b: "ksmbd: fix heap-based overflow in
> > set_ntacl_dacl()" from Jul 28, 2022, leads to the following Smatch
> > static checker warning:
> >
> > fs/ksmbd/smb2pdu.c:5182 smb2_get_info_sec()
> > error: uninitialized symbol 'secdesclen'.
> This was fixed on v4 patch :
> https://marc.info/?l=linux-cifs&m=165939383203779&w=2
>
> Thanks for your report!
Oops. Sorry, I didn't realize it was part of the kbuild warning... The
kbuild warning didn't include that code so this was the first time I
was seeing the code myself.
regards,
dan carpenter
prev parent reply other threads:[~2022-08-05 11:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 14:33 [bug report] ksmbd: fix heap-based overflow in set_ntacl_dacl() Dan Carpenter
2022-08-04 23:03 ` Namjae Jeon
2022-08-05 11:42 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220805114200.GM3460@kadam \
--to=dan.carpenter@oracle.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.