From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55925C00140 for ; Fri, 5 Aug 2022 11:59:21 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LzkfH24KVz3bY5 for ; Fri, 5 Aug 2022 21:59:19 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=VT9RgJ+o; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::82e; helo=mail-qt1-x82e.google.com; envelope-from=tcminyard@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=VT9RgJ+o; dkim-atps=neutral Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4LzkdT6x2Cz2xH3 for ; Fri, 5 Aug 2022 21:58:35 +1000 (AEST) Received: by mail-qt1-x82e.google.com with SMTP id b18so1801682qtq.13 for ; Fri, 05 Aug 2022 04:58:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:sender:from:to:cc; bh=12EUweBf0CXLW8+gSAKKg9xplGZSYosR37oZCD2Y1Eg=; b=VT9RgJ+oVb09HdRQa6Lq62UkO+czbOAM9zhFz3mQzPOunpvHA/Dup3iDIDNBrSTcRg ISw6ghOW+btNX/HqH0k2wNgSXpUg9bL7XcttzO3HDDNNozk+y3dM1mVPrsLCuGG1wDEB zPDESdIoCLKl87M3ZHZOLwvWZcZCGfdRYxSeLVkv1UokGzv1nB/bnYzWf+ZQw+cvxeeO puAKsVq9rrDGTJ2pP8KskFUBBm5iQIXGPWMPTn0Fzqb9UMJ5bQb/k0gtuQPFCBlS4+N1 kK6jb8sG7doAKbDSIiJhVitTkmnihXzpan+QM+ytoVxdChvksAv2+bOnb1FKMbKjMQbE tC4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:sender:x-gm-message-state:from :to:cc; bh=12EUweBf0CXLW8+gSAKKg9xplGZSYosR37oZCD2Y1Eg=; b=gY1MXiWCHUX6aGMLWw+LvgvlIIxyLIS1bMWiH/wm1fXYZ15Wy7/zgiXUSDnXrIThif Wp2Cb5ms7kZsurilrO2uKPTlBLUkHjo0ATPpmDR9DvX0MiP29aT9nstYfYZ5Nhlfqmyq ktmm+OIB9XVtLZbPiJHgE29dVCJEzKn08o3DvH2IgKG0jAmsYqRLLkObk0jjjaDIZVgp j2bfG/xg7vf1yqBcvotiEzRqGwcz//HCoW2/vHsNSPnfTCMMs/JK15VDds0qvaptQ5Xk QzH7bHJ/1RNJBBXMCnI9VyWF6Caf7wL74KnS65JNw4XWN3rgotfs3GCPfW7nzN7EQfU/ vfIg== X-Gm-Message-State: ACgBeo23gxaHrXv8wgmWfd5GAMpRxh1SlG9dGwmUThuhIVKNFvz/+lzE nKkuVhzu5eoybXOu8cMAbw== X-Google-Smtp-Source: AA6agR4yn9VOrQApcMy/JIE89HsYzBMvrpAkEphl5ssbELPYZNrOf1zrKpwK4oe95pmrgYf1HSEKPA== X-Received: by 2002:a05:622a:346:b0:31f:c40:eac0 with SMTP id r6-20020a05622a034600b0031f0c40eac0mr5373701qtw.326.1659700711064; Fri, 05 Aug 2022 04:58:31 -0700 (PDT) Received: from serve.minyard.net (serve.minyard.net. [2001:470:b8f6:1b::1]) by smtp.gmail.com with ESMTPSA id c8-20020ac85188000000b0031eb51dd72csm2491484qtn.85.2022.08.05.04.58.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Aug 2022 04:58:30 -0700 (PDT) Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:8c5c:a823:f5bd:8751]) by serve.minyard.net (Postfix) with ESMTPSA id 4CFC71800FA; Fri, 5 Aug 2022 11:58:29 +0000 (UTC) Date: Fri, 5 Aug 2022 06:58:27 -0500 From: Corey Minyard To: Tomer Maimon Subject: Re: [PATCH v2] dt-binding: ipmi: add fallback to npcm845 compatible Message-ID: <20220805115827.GG3834@minyard.net> References: <20220804181800.235368-1-tmaimon77@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220804181800.235368-1-tmaimon77@gmail.com> X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: minyard@acm.org Cc: devicetree@vger.kernel.org, benjaminfair@google.com, avifishman70@gmail.com, venture@google.com, openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org, tali.perry1@gmail.com, robh+dt@kernel.org, joel@jms.id.au, krzysztof.kozlowski+dt@linaro.org, openipmi-developer@lists.sourceforge.net, jic23@kernel.org Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Thu, Aug 04, 2022 at 09:18:00PM +0300, Tomer Maimon wrote: > Add to npcm845 KCS compatible string a fallback to npcm750 KCS compatible > string becuase NPCM845 and NPCM750 BMCs are using identical KCS modules. > > Signed-off-by: Tomer Maimon > --- > Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt > index cbc10a68ddef..4fda76e63396 100644 > --- a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt > +++ b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt > @@ -7,7 +7,7 @@ used to perform in-band IPMI communication with their host. > Required properties: > - compatible : should be one of > "nuvoton,npcm750-kcs-bmc" > - "nuvoton,npcm845-kcs-bmc" > + "nuvoton,npcm845-kcs-bmc", "nuvoton,npcm750-kcs-bmc" This is just wrong. The compatible is supposed to identify the device, not the board the device is on. I think compatible here should be "npcm7xx-kcs-bmc", and just use that everywhere. It's fine if that is used on a board named npcm845. -corey > - interrupts : interrupt generated by the controller > - kcs_chan : The KCS channel number in the controller > > -- > 2.33.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27022C00140 for ; Fri, 5 Aug 2022 11:58:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231347AbiHEL6f (ORCPT ); Fri, 5 Aug 2022 07:58:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230169AbiHEL6d (ORCPT ); Fri, 5 Aug 2022 07:58:33 -0400 Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B14876470; Fri, 5 Aug 2022 04:58:33 -0700 (PDT) Received: by mail-qt1-x835.google.com with SMTP id d16so1821033qtw.8; Fri, 05 Aug 2022 04:58:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:sender:from:to:cc; bh=12EUweBf0CXLW8+gSAKKg9xplGZSYosR37oZCD2Y1Eg=; b=VT9RgJ+oVb09HdRQa6Lq62UkO+czbOAM9zhFz3mQzPOunpvHA/Dup3iDIDNBrSTcRg ISw6ghOW+btNX/HqH0k2wNgSXpUg9bL7XcttzO3HDDNNozk+y3dM1mVPrsLCuGG1wDEB zPDESdIoCLKl87M3ZHZOLwvWZcZCGfdRYxSeLVkv1UokGzv1nB/bnYzWf+ZQw+cvxeeO puAKsVq9rrDGTJ2pP8KskFUBBm5iQIXGPWMPTn0Fzqb9UMJ5bQb/k0gtuQPFCBlS4+N1 kK6jb8sG7doAKbDSIiJhVitTkmnihXzpan+QM+ytoVxdChvksAv2+bOnb1FKMbKjMQbE tC4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:sender:x-gm-message-state:from :to:cc; bh=12EUweBf0CXLW8+gSAKKg9xplGZSYosR37oZCD2Y1Eg=; b=wDByAgHNHZJ03deDYW2vEKKN/OA1nnGtxUt7DOTrHR/lVsi8rMVlIEMlGVgH88E5GU A8JenB0e7ck384WpGVpOyKwjHwWnAclWHSVPn6ZEe6aHKq92+9BiXKGcKUasVVJZjloj BE9uQGzUnjWznEV+XKSplBqZDmGxntS6/vc4osTcXOqMjeKYzvFFO2khP8HIp5h8ThLw ZuObo52DhhJtb+bOWWN+HDgb2+l7fn0poUJQzIHZQTpoUmxMzUKa/ANwpUalcA6cAfWP /pGPXM+T/fwqvAY5hK5LCvnRpoJ29Nb8+6JePLV15ZKre5summq35N5wvDNhbFQ4fxcs 9Ufw== X-Gm-Message-State: ACgBeo1gQoX60o65JtOKcTQN9vl6/Y8R8BCfCgBgE27gaHvzH+dXlOEI TpCiniKe4Jqg62HbgiuuwA== X-Google-Smtp-Source: AA6agR4yn9VOrQApcMy/JIE89HsYzBMvrpAkEphl5ssbELPYZNrOf1zrKpwK4oe95pmrgYf1HSEKPA== X-Received: by 2002:a05:622a:346:b0:31f:c40:eac0 with SMTP id r6-20020a05622a034600b0031f0c40eac0mr5373701qtw.326.1659700711064; Fri, 05 Aug 2022 04:58:31 -0700 (PDT) Received: from serve.minyard.net (serve.minyard.net. [2001:470:b8f6:1b::1]) by smtp.gmail.com with ESMTPSA id c8-20020ac85188000000b0031eb51dd72csm2491484qtn.85.2022.08.05.04.58.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Aug 2022 04:58:30 -0700 (PDT) Sender: Corey Minyard Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:8c5c:a823:f5bd:8751]) by serve.minyard.net (Postfix) with ESMTPSA id 4CFC71800FA; Fri, 5 Aug 2022 11:58:29 +0000 (UTC) Date: Fri, 5 Aug 2022 06:58:27 -0500 From: Corey Minyard To: Tomer Maimon Cc: avifishman70@gmail.com, tali.perry1@gmail.com, joel@jms.id.au, venture@google.com, yuenn@google.com, benjaminfair@google.com, jic23@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, openbmc@lists.ozlabs.org, openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2] dt-binding: ipmi: add fallback to npcm845 compatible Message-ID: <20220805115827.GG3834@minyard.net> Reply-To: minyard@acm.org References: <20220804181800.235368-1-tmaimon77@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220804181800.235368-1-tmaimon77@gmail.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Aug 04, 2022 at 09:18:00PM +0300, Tomer Maimon wrote: > Add to npcm845 KCS compatible string a fallback to npcm750 KCS compatible > string becuase NPCM845 and NPCM750 BMCs are using identical KCS modules. > > Signed-off-by: Tomer Maimon > --- > Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt > index cbc10a68ddef..4fda76e63396 100644 > --- a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt > +++ b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt > @@ -7,7 +7,7 @@ used to perform in-band IPMI communication with their host. > Required properties: > - compatible : should be one of > "nuvoton,npcm750-kcs-bmc" > - "nuvoton,npcm845-kcs-bmc" > + "nuvoton,npcm845-kcs-bmc", "nuvoton,npcm750-kcs-bmc" This is just wrong. The compatible is supposed to identify the device, not the board the device is on. I think compatible here should be "npcm7xx-kcs-bmc", and just use that everywhere. It's fine if that is used on a board named npcm845. -corey > - interrupts : interrupt generated by the controller > - kcs_chan : The KCS channel number in the controller > > -- > 2.33.0 >