From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09E49C25B0C for ; Fri, 5 Aug 2022 12:22:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240645AbiHEMWa (ORCPT ); Fri, 5 Aug 2022 08:22:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240695AbiHEMW0 (ORCPT ); Fri, 5 Aug 2022 08:22:26 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CE51D6C for ; Fri, 5 Aug 2022 05:22:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E37A1B828AF for ; Fri, 5 Aug 2022 12:22:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E635C43141; Fri, 5 Aug 2022 12:22:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659702142; bh=vn2WUAHXHsGKqG8gx4eiUN1YZXYE9u0alZ+b+BqHmrc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CtQeO32aRLqO9+w82Hnf5qznoVF09qVAciLzX/GGJDxgfG9TVmcDn1/v30nv1x1YE kbEpDumT9M5EXHS+ntYBZQy34mwVUzHWV3MqT2/rPtOHyWC2L8pd62k8RF8+jOtmoQ ooaccg9kjd5uw2dRM8d1tGp7eUxmcrFBKOIBXHoVRvc8v++jESTngKpIxhEECtzXkh lAma4bbHOHUfmwmLkgUfj51n+3VTal1XnBN9U8GNHP6A7V5/JhTUE/12ndRsxRmqZf Cy0JSPnzceXTi6/0OSEV59MUFvN+iBfsJE+/XEClbDedgrjg+hk/A0BM7P0Od2p3Vv pedOodH1X/edA== Received: by pali.im (Postfix) id CE15E96D; Fri, 5 Aug 2022 14:22:19 +0200 (CEST) From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Linus Walleij Cc: =?UTF-8?q?Marek=20Beh=C3=BAn?= , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org Subject: [PATCH v2 3/4] pinctrl: armada-37xx: Checks for errors in gpio_request_enable callback Date: Fri, 5 Aug 2022 14:22:01 +0200 Message-Id: <20220805122202.23174-3-pali@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220805122202.23174-1-pali@kernel.org> References: <20220805122202.23174-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Now when all MPP pins are properly defined and every MPP pin has GPIO function, always checks for errors in armada_37xx_gpio_request_enable() function when calling armada_37xx_pmx_set_by_name(). Function armada_37xx_pmx_set_by_name() should not return "not supported" error anymore for any GPIO pin when requesting GPIO mode. Fixes: 87466ccd9401 ("pinctrl: armada-37xx: Add pin controller support for Armada 37xx") Signed-off-by: Pali Rohár --- Changes in v2: * add missing int ret; --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c index e5e5f0ea0e77..3227f70922fc 100644 --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c @@ -500,11 +500,15 @@ static int armada_37xx_gpio_request_enable(struct pinctrl_dev *pctldev, struct armada_37xx_pinctrl *info = pinctrl_dev_get_drvdata(pctldev); struct armada_37xx_pin_group *group; int grp = 0; + int ret; dev_dbg(info->dev, "requesting gpio %d\n", offset); - while ((group = armada_37xx_find_next_grp_by_pin(info, offset, &grp))) - armada_37xx_pmx_set_by_name(pctldev, "gpio", group); + while ((group = armada_37xx_find_next_grp_by_pin(info, offset, &grp))) { + ret = armada_37xx_pmx_set_by_name(pctldev, "gpio", group); + if (ret) + return ret; + } return 0; } -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4247C00140 for ; Fri, 5 Aug 2022 12:26:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rIjdEZvrVF+LsgGCtW7G6MB4IGdxmiiWdD9izM4hFk8=; b=SmCKqLqeQzKzSK 7QKzbmPJBEaXoVrPbYGrDC3F5AVfAnYp+/S4SV5UtsaPNbtgl9c1N8t573gIDw9sffTSmHABkrQwN YkKoXEcGZE/TaIxM/bJWW36K43gsI9l88XjFVox/MbsqSyceHVdN2b4IZPxUIjTeU5A7Nq2jfuRh2 ASF9/94RcG3GejLa9pP1AZNjGAqssdhY+vDqZnlLObqmhIrqigfl+H/VKXuzBirwIGElt3XS5/OJg zlK/bes5IrMNNGbKvw5tbzJ93F8a08HllFFCUgiOr6bZS8UB6l0RwJF6azGyZ0BQbojIqIN+VM3vE J/jF/GKPsGFlYGT+ljxg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJwOF-00EsPH-28; Fri, 05 Aug 2022 12:25:20 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJwLS-00EqYG-Pk for linux-arm-kernel@lists.infradead.org; Fri, 05 Aug 2022 12:22:29 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2F70F61A27; Fri, 5 Aug 2022 12:22:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E635C43141; Fri, 5 Aug 2022 12:22:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659702142; bh=vn2WUAHXHsGKqG8gx4eiUN1YZXYE9u0alZ+b+BqHmrc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CtQeO32aRLqO9+w82Hnf5qznoVF09qVAciLzX/GGJDxgfG9TVmcDn1/v30nv1x1YE kbEpDumT9M5EXHS+ntYBZQy34mwVUzHWV3MqT2/rPtOHyWC2L8pd62k8RF8+jOtmoQ ooaccg9kjd5uw2dRM8d1tGp7eUxmcrFBKOIBXHoVRvc8v++jESTngKpIxhEECtzXkh lAma4bbHOHUfmwmLkgUfj51n+3VTal1XnBN9U8GNHP6A7V5/JhTUE/12ndRsxRmqZf Cy0JSPnzceXTi6/0OSEV59MUFvN+iBfsJE+/XEClbDedgrjg+hk/A0BM7P0Od2p3Vv pedOodH1X/edA== Received: by pali.im (Postfix) id CE15E96D; Fri, 5 Aug 2022 14:22:19 +0200 (CEST) From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Linus Walleij Cc: =?UTF-8?q?Marek=20Beh=C3=BAn?= , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org Subject: [PATCH v2 3/4] pinctrl: armada-37xx: Checks for errors in gpio_request_enable callback Date: Fri, 5 Aug 2022 14:22:01 +0200 Message-Id: <20220805122202.23174-3-pali@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220805122202.23174-1-pali@kernel.org> References: <20220805122202.23174-1-pali@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220805_052226_938148_BC76C55F X-CRM114-Status: GOOD ( 15.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Tm93IHdoZW4gYWxsIE1QUCBwaW5zIGFyZSBwcm9wZXJseSBkZWZpbmVkIGFuZCBldmVyeSBNUFAg cGluIGhhcyBHUElPCmZ1bmN0aW9uLCBhbHdheXMgY2hlY2tzIGZvciBlcnJvcnMgaW4gYXJtYWRh XzM3eHhfZ3Bpb19yZXF1ZXN0X2VuYWJsZSgpCmZ1bmN0aW9uIHdoZW4gY2FsbGluZyBhcm1hZGFf Mzd4eF9wbXhfc2V0X2J5X25hbWUoKS4gRnVuY3Rpb24KYXJtYWRhXzM3eHhfcG14X3NldF9ieV9u YW1lKCkgc2hvdWxkIG5vdCByZXR1cm4gIm5vdCBzdXBwb3J0ZWQiIGVycm9yCmFueW1vcmUgZm9y IGFueSBHUElPIHBpbiB3aGVuIHJlcXVlc3RpbmcgR1BJTyBtb2RlLgoKRml4ZXM6IDg3NDY2Y2Nk OTQwMSAoInBpbmN0cmw6IGFybWFkYS0zN3h4OiBBZGQgcGluIGNvbnRyb2xsZXIgc3VwcG9ydCBm b3IgQXJtYWRhIDM3eHgiKQpTaWduZWQtb2ZmLWJ5OiBQYWxpIFJvaMOhciA8cGFsaUBrZXJuZWwu b3JnPgotLS0KQ2hhbmdlcyBpbiB2MjoKKiBhZGQgbWlzc2luZyBpbnQgcmV0OwotLS0KIGRyaXZl cnMvcGluY3RybC9tdmVidS9waW5jdHJsLWFybWFkYS0zN3h4LmMgfCA4ICsrKysrKy0tCiAxIGZp bGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L2RyaXZlcnMvcGluY3RybC9tdmVidS9waW5jdHJsLWFybWFkYS0zN3h4LmMgYi9kcml2ZXJzL3Bp bmN0cmwvbXZlYnUvcGluY3RybC1hcm1hZGEtMzd4eC5jCmluZGV4IGU1ZTVmMGVhMGU3Ny4uMzIy N2Y3MDkyMmZjIDEwMDY0NAotLS0gYS9kcml2ZXJzL3BpbmN0cmwvbXZlYnUvcGluY3RybC1hcm1h ZGEtMzd4eC5jCisrKyBiL2RyaXZlcnMvcGluY3RybC9tdmVidS9waW5jdHJsLWFybWFkYS0zN3h4 LmMKQEAgLTUwMCwxMSArNTAwLDE1IEBAIHN0YXRpYyBpbnQgYXJtYWRhXzM3eHhfZ3Bpb19yZXF1 ZXN0X2VuYWJsZShzdHJ1Y3QgcGluY3RybF9kZXYgKnBjdGxkZXYsCiAJc3RydWN0IGFybWFkYV8z N3h4X3BpbmN0cmwgKmluZm8gPSBwaW5jdHJsX2Rldl9nZXRfZHJ2ZGF0YShwY3RsZGV2KTsKIAlz dHJ1Y3QgYXJtYWRhXzM3eHhfcGluX2dyb3VwICpncm91cDsKIAlpbnQgZ3JwID0gMDsKKwlpbnQg cmV0OwogCiAJZGV2X2RiZyhpbmZvLT5kZXYsICJyZXF1ZXN0aW5nIGdwaW8gJWRcbiIsIG9mZnNl dCk7CiAKLQl3aGlsZSAoKGdyb3VwID0gYXJtYWRhXzM3eHhfZmluZF9uZXh0X2dycF9ieV9waW4o aW5mbywgb2Zmc2V0LCAmZ3JwKSkpCi0JCWFybWFkYV8zN3h4X3BteF9zZXRfYnlfbmFtZShwY3Rs ZGV2LCAiZ3BpbyIsIGdyb3VwKTsKKwl3aGlsZSAoKGdyb3VwID0gYXJtYWRhXzM3eHhfZmluZF9u ZXh0X2dycF9ieV9waW4oaW5mbywgb2Zmc2V0LCAmZ3JwKSkpIHsKKwkJcmV0ID0gYXJtYWRhXzM3 eHhfcG14X3NldF9ieV9uYW1lKHBjdGxkZXYsICJncGlvIiwgZ3JvdXApOworCQlpZiAocmV0KQor CQkJcmV0dXJuIHJldDsKKwl9CiAKIAlyZXR1cm4gMDsKIH0KLS0gCjIuMjAuMQoKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwg bWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK