From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1BC7C00140 for ; Fri, 5 Aug 2022 14:21:34 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D22EE8482D; Fri, 5 Aug 2022 16:21:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="p0veOrT4"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CE58984828; Fri, 5 Aug 2022 16:21:31 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A07A784828 for ; Fri, 5 Aug 2022 16:21:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2384E61139; Fri, 5 Aug 2022 14:21:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3693C433C1; Fri, 5 Aug 2022 14:21:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659709287; bh=29z/In+llfKR/iDKHbx/ofbpPys+3b8sMz/wQ88pFPw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p0veOrT4+qmuSsqHVx1hH/T/ZY6hfDuc/YV+DMYafM0U8YGyDy+rCvh8mNV7EXQrM RXIvk2eVhFHnLNhbXxsiTi1v+VyKf58z6cVCcwxzCSYlJLo4dKQy0Nnoxygd/6RdcX Nt/hOUONjs8X1lboL8D1474ATQTXWuPT+lr7mgK97XM6xdgFDfwxkCnCq1MIzc+iLn p0NsL49TuWIG5dwXZ2J2jkAb48vL4UP5Dw/whxIl22iEApU6k6TPysvfI5vxTNusZ6 oDnNkPA5FL1XNOGIvJa1Q+GfJZWnil0cgSXJSQiBHX5CYAebgURhYy4RNS0bNcHEQH tlFPt+4lXuIpQ== Received: by pali.im (Postfix) id BDF4982D; Fri, 5 Aug 2022 16:21:24 +0200 (CEST) Date: Fri, 5 Aug 2022 16:21:24 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Tom Rini Cc: u-boot@lists.denx.de, kabel@kernel.org Subject: Re: Broken commit de47ff536363289f92f85ed1e4901724d238432d Message-ID: <20220805142124.6swsha6aj62f33e3@pali> References: <20220802091338.f4g45ldhc7qbg6hm@pali> <20220802105826.GB1146598@bill-the-cat> <20220803160013.4oh6x4glh2thtcog@pali> <20220803161318.GS1146598@bill-the-cat> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220803161318.GS1146598@bill-the-cat> User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Wednesday 03 August 2022 12:13:18 Tom Rini wrote: > On Wed, Aug 03, 2022 at 06:00:13PM +0200, Pali Rohár wrote: > > On Tuesday 02 August 2022 06:58:26 Tom Rini wrote: > > > On Tue, Aug 02, 2022 at 11:13:38AM +0200, Pali Rohár wrote: > > > > > > > Hello Tom! > > > > > > > > Your commit de47ff536363289f92f85ed1e4901724d238432d ("Convert > > > > CONFIG_SYS_MPC85XX_NO_RESETVEC to Kconfig") seems to be broken. > > > > > > I thought I had managed to mirror the TPL/SPL/full usage that was there > > > prior, but apparently some got missed. > > > > Yea, conversion to Kconfig seems that was incorrect. > > As the config files were just unclear, but you seem to understand what > it's supposed to be, a patch to clean it up would be most appreciated, > thanks. > > -- > Tom Broken is also commit d433c74eecdce1e4952ef4e8c712a9289c0dfcc2. Seems that all kconfig migration changes done after that commit are broken. I really do not have energy to investigate what and how was broken due to incorrect kconfig migration. I did simple test. Applied following change: diff --git a/include/configs/p1_p2_rdb_pc.h b/include/configs/p1_p2_rdb_pc.h index a6523753d5ca..489f24df0ab1 100644 --- a/include/configs/p1_p2_rdb_pc.h +++ b/include/configs/p1_p2_rdb_pc.h @@ -624,3 +624,7 @@ __stringify(__PCIE_RST_CMD)"\0" "bootm $norbootaddr - $norfdtaddr" #endif /* __CONFIG_H */ + +#ifdef CONFIG_SDCARD +#error +#endif And then called: make CROSS_COMPILE=powerpc-linux-gnuspe- P2020RDB-PC_defconfig u-boot.bin And it failed, even when this defconfig file is not SD card builds.