From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BFDB3C00140 for ; Fri, 5 Aug 2022 15:55:03 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7550A84839; Fri, 5 Aug 2022 17:55:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="SGb3j5bb"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E5CD784839; Fri, 5 Aug 2022 17:54:59 +0200 (CEST) Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7219381727 for ; Fri, 5 Aug 2022 17:54:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x734.google.com with SMTP id j4so2131752qkl.10 for ; Fri, 05 Aug 2022 08:54:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=Y4bzhOy3b27qinKbK05iw99bqN2T53NjXvb45lylntg=; b=SGb3j5bbS4oyq6CrxF1QEYe33ym907Fw0G9sb7ftx3FQTbQ3cbSWPgFaZJa9Zsohyk NornVeAvcjbjN8rnFwVfHe3s0wr/fWdHWHzDkzuFuJA3mjwNPZtopP83kE2fKcTykq2e NLJBEmyFg34fHy89NyGTCGm3Y1c/BsuafJwtM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=Y4bzhOy3b27qinKbK05iw99bqN2T53NjXvb45lylntg=; b=YnZQjlqTwA4jOkd+eJ6gGD7wUoFzuk+C008TE1TsqoS6eGijFjZwkTg3vdwvhfTrae d5vk8MQP40SeafuQmUSvYJ0wIFP37utQE7he4tsGZv512Hb7zgs/dxn5yBNXqICddwsi 5F8Ml1SV6dm+zyiWjDaeq8dUshiPtCGBr3lcUyzSkfIzBLOro3aAPYTBooZRpR0igEzk JB7oUKV+yBVbyfpRh0/fdRPkZLk6MIp6v4rw8Z53C+4VyfaoPbEF5A9o1BarXoSgRvaj fcaq7mnb/GDN+Kx8NEsqSLyADBNq3tdJFv5I/1T9iAs3eICRpUJ0rwSIVHpM7vwghotM REaw== X-Gm-Message-State: ACgBeo1Cv0JW3CaLM1QAE/HoV3FqbRxQeb/hNqVgWii7oz4RMDFJ3N+O hTYKBnDHwsLC7Kx4paUZbuaVyg== X-Google-Smtp-Source: AA6agR4tVS0p/k7Vgyy95Q4Ujd5dji19IOoc0UYsVjfHbpIqTrITFmgLDFB+usK/eVlEranS9BlkOw== X-Received: by 2002:a05:620a:288c:b0:6b6:53c1:5ad6 with SMTP id j12-20020a05620a288c00b006b653c15ad6mr5657705qkp.603.1659714896126; Fri, 05 Aug 2022 08:54:56 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id x21-20020a05620a0ed500b006b615cd8c13sm2937154qkm.106.2022.08.05.08.54.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Aug 2022 08:54:55 -0700 (PDT) Date: Fri, 5 Aug 2022 11:54:53 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: u-boot@lists.denx.de, kabel@kernel.org Subject: Re: Broken commit de47ff536363289f92f85ed1e4901724d238432d Message-ID: <20220805155453.GC1146598@bill-the-cat> References: <20220802105826.GB1146598@bill-the-cat> <20220803160013.4oh6x4glh2thtcog@pali> <20220803161318.GS1146598@bill-the-cat> <20220805142124.6swsha6aj62f33e3@pali> <20220805144731.GV1146598@bill-the-cat> <20220805145935.xumynhjbih3nekjq@pali> <20220805150340.GX1146598@bill-the-cat> <20220805151259.hdftfa3utfiq4i3w@pali> <20220805154400.GA1146598@bill-the-cat> <20220805155135.r5dctspg2oohzdev@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hGzRdvij9TMxgK2o" Content-Disposition: inline In-Reply-To: <20220805155135.r5dctspg2oohzdev@pali> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --hGzRdvij9TMxgK2o Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 05, 2022 at 05:51:35PM +0200, Pali Roh=E1r wrote: > On Friday 05 August 2022 11:44:00 Tom Rini wrote: > > On Fri, Aug 05, 2022 at 05:12:59PM +0200, Pali Roh=E1r wrote: > > > On Friday 05 August 2022 11:03:40 Tom Rini wrote: > > > > On Fri, Aug 05, 2022 at 04:59:35PM +0200, Pali Roh=E1r wrote: > > > > > On Friday 05 August 2022 10:47:31 Tom Rini wrote: > > > > > > On Fri, Aug 05, 2022 at 04:21:24PM +0200, Pali Roh=E1r wrote: > > > > > > > On Wednesday 03 August 2022 12:13:18 Tom Rini wrote: > > > > > > > > On Wed, Aug 03, 2022 at 06:00:13PM +0200, Pali Roh=E1r wrot= e: > > > > > > > > > On Tuesday 02 August 2022 06:58:26 Tom Rini wrote: > > > > > > > > > > On Tue, Aug 02, 2022 at 11:13:38AM +0200, Pali Roh=E1r = wrote: > > > > > > > > > >=20 > > > > > > > > > > > Hello Tom! > > > > > > > > > > >=20 > > > > > > > > > > > Your commit de47ff536363289f92f85ed1e4901724d238432d = ("Convert > > > > > > > > > > > CONFIG_SYS_MPC85XX_NO_RESETVEC to Kconfig") seems to = be broken. > > > > > > > > > >=20 > > > > > > > > > > I thought I had managed to mirror the TPL/SPL/full usag= e that was there > > > > > > > > > > prior, but apparently some got missed. > > > > > > > > >=20 > > > > > > > > > Yea, conversion to Kconfig seems that was incorrect. > > > > > > > >=20 > > > > > > > > As the config files were just unclear, but you seem to unde= rstand what > > > > > > > > it's supposed to be, a patch to clean it up would be most a= ppreciated, > > > > > > > > thanks. > > > > > > > >=20 > > > > > > > > --=20 > > > > > > > > Tom > > > > > > >=20 > > > > > > > Broken is also commit d433c74eecdce1e4952ef4e8c712a9289c0dfcc= 2. Seems > > > > > > > that all kconfig migration changes done after that commit are= broken. > > > > > > >=20 > > > > > > > I really do not have energy to investigate what and how was b= roken due > > > > > > > to incorrect kconfig migration. > > > > > > >=20 > > > > > > >=20 > > > > > > > I did simple test. Applied following change: > > > > > > >=20 > > > > > > > diff --git a/include/configs/p1_p2_rdb_pc.h b/include/configs= /p1_p2_rdb_pc.h > > > > > > > index a6523753d5ca..489f24df0ab1 100644 > > > > > > > --- a/include/configs/p1_p2_rdb_pc.h > > > > > > > +++ b/include/configs/p1_p2_rdb_pc.h > > > > > > > @@ -624,3 +624,7 @@ __stringify(__PCIE_RST_CMD)"\0" > > > > > > > "bootm $norbootaddr - $norfdtaddr" > > > > > > > =20 > > > > > > > #endif /* __CONFIG_H */ > > > > > > > + > > > > > > > +#ifdef CONFIG_SDCARD > > > > > > > +#error > > > > > > > +#endif > > > > > > >=20 > > > > > > > And then called: > > > > > > >=20 > > > > > > > make CROSS_COMPILE=3Dpowerpc-linux-gnuspe- P2020RDB-PC_defcon= fig u-boot.bin > > > > > > >=20 > > > > > > > And it failed, even when this defconfig file is not SD card b= uilds. > > > > > >=20 > > > > > > Where is PBL in that case even then? > > > > >=20 > > > > > P2020 (and older) are pre-PBL boards, they do not support NXP PBL > > > > > header. > > > >=20 > > > > Ah, OK, then it should just be removing TARGET_P2020RDB from the ch= oice > > > > on "Freescale PBL load location". > > > >=20 > > > > --=20 > > > > Tom > > >=20 > > > I just do not understand. > > >=20 > > > P10** and P20** do not support NXP PBL. They support only pre-PBL and > > > for SD card pre-PBL support I added option FSL_PREPBL_ESDHC_BOOT_SECT= OR. > > >=20 > > > But CONFIG_SDCARD is automatically set when SYS_EXTRA_OPTIONS contains > > > "SDCARD" string and CONFIG_SDCARD is used then also in P10** and P20** > > > SD-card version of SPL to load proper U-Boot. > >=20 > > So CONFIG_SDCARD was over-loaded? That's very frustrating. That's what > > needs to be corrected then. >=20 > But it was correct, no? CONFIG_SDCARD ensures that U-Boot is compiled in > mode in which can be booted from SD card. Or what do you have in mind as > purpose of this symbol? >=20 > The issue is that your Kconfig migration changes enabled CONFIG_SDCARD > also when building (parallel) NOR version of U-Boot. To me, the biggest issue is that "CONFIG_SDCARD" exists. It's very much non-descriptive and that for some platforms it means "we have NXP PBL" and others means "we're booting from SDCARD". The former should be renamed to be descriptive, and the latter should re-use CONFIG_SD_CARD which is still a bad name, but what everyone else uses, so makes renaming it later to something less bad easier. --=20 Tom --hGzRdvij9TMxgK2o Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmLtPU0ACgkQFHw5/5Y0 tyzKqgwAt3ElUbmLmVMFkvxNkWU1Sc7lELydPlCY9Ex4dcAs7PHIGyJIESDhZbyA T5MZ1zOJUIYpCgs/aFakPBMAZTM0z59J9eLOhl5+x7/0rn/GjWd6KnttwwcsEvKa J5Xmoss7FkX7Cm2+5tI067viW7ZQbO1FsgVCvD1ICapXPE2+RWqSEbIJz0b986UT bRMlpHjbT0sHPU+ix++Xgz6moc7SBrY0mlkaOlf3559YFEGm2c3sTF8ZZIKLnqM7 66PntANwUnSp8n5jQyssyogTi44ytQaxyNkGAnL6jk+ma/FAeBEg/o1Dw6fcgf/Y AEN2SbuJgTV6lTwP1Osqz30qjrH19baAb3/LwCwj5ha2UJSlGSFs4GCKs2ACG0h8 qS+xzehqd9NzbvoD4j7lUuiwTfQ1PDiR2dpIV3U+6/nS7d/saurSASHzzj45mF2/ +5+yjevtUhPPRSx99ikYmhcYK6UsiLzEOpXmh1xdzyQZMW0aFkCxe11LunF5tts4 kvHJAiph =3rqV -----END PGP SIGNATURE----- --hGzRdvij9TMxgK2o--