All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: kory.maincent@bootlin.com, Jens Kleintje <scooby22@web.de>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/gcnano-binaries: create symlinks for libGLESv2 and libGLESv1_CM.so
Date: Fri, 5 Aug 2022 18:33:32 +0200	[thread overview]
Message-ID: <20220805163332.GE3621445@scaer> (raw)
In-Reply-To: <20220804204157.30731-1-thomas.petazzoni@bootlin.com>

Thomas, All,

On 2022-08-04 22:41 +0200, Thomas Petazzoni via buildroot spake thusly:
> At least libepoxy, a user of OpenGL ES, expects libraries to be
> available as libGLESv2.so.2 and libGLESv1_CM.so.1. While other OpenGL
> implementations comply with this, gcnano-binaries does not, and
> installs its libraries directly as .so, without any ABI version,
> causing runtime failures with libepoxy or SDL2, as it tries to
> dlopen() the OpenGL ES libraries with their ABI suffix.
> 
> See for example the libepoxy code:
> 
>   https://github.com/anholt/libepoxy/blob/master/src/dispatch_common.c#L191
> 
> Fix this issue by adding the relevant symlinks.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Applied to master, thanks.

(this is a bit of a convoluted install command, if any...)

Regards,
Yann E. MORIN.

> ---
>  package/gcnano-binaries/gcnano-binaries.mk | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/package/gcnano-binaries/gcnano-binaries.mk b/package/gcnano-binaries/gcnano-binaries.mk
> index dc309ec3c2..ce9b24cc3a 100644
> --- a/package/gcnano-binaries/gcnano-binaries.mk
> +++ b/package/gcnano-binaries/gcnano-binaries.mk
> @@ -44,10 +44,17 @@ GCNANO_BINARIES_MODULE_MAKE_OPTS = \
>  
>  GCNANO_BINARIES_USERLAND_SUBDIR = gcnano-userland-multi-$(GCNANO_BINARIES_USERLAND_VERSION)
>  
> +# This creates:
> +#   libGLESv2.so.2    -> libGLESv2.so
> +#   libGLESv1_CM.so.1 -> libGLESv1_CM.so
> +# symlinks, as most OpenGL implementations have them, and they are
> +# expected by some users such as libepoxy.
>  define GCNANO_BINARIES_INSTALL
>  	cd $(@D)/$(GCNANO_BINARIES_USERLAND_SUBDIR)/release/drivers/ ; \
>  	find . -type f -exec $(INSTALL) -D -m 0755 {} $(1)/usr/lib/{} \; ; \
>  	find . -type l -exec cp -a {} $(1)/usr/lib \;
> +	ln -sf libGLESv2.so $(1)/usr/lib/libGLESv2.so.2
> +	ln -sf libGLESv1_CM.so $(1)/usr/lib/libGLESv1_CM.so.1
>  	mkdir -p $(1)/usr/include
>  	cp -a $(@D)/$(GCNANO_BINARIES_USERLAND_SUBDIR)/release/include/* $(1)/usr/include/
>  	ln -sf gbm/gbm.h $(1)/usr/include/gbm.h
> -- 
> 2.37.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2022-08-05 16:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-04 20:41 [Buildroot] [PATCH 1/2] package/gcnano-binaries: create symlinks for libGLESv2 and libGLESv1_CM.so Thomas Petazzoni via buildroot
2022-08-04 20:41 ` [Buildroot] [PATCH 2/2] package/gcnano-binaries: set Version: field in .pc files Thomas Petazzoni via buildroot
2022-08-05 16:35   ` Yann E. MORIN
2022-08-06 13:40     ` Thomas Petazzoni via buildroot
2022-08-05 16:33 ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220805163332.GE3621445@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=kory.maincent@bootlin.com \
    --cc=scooby22@web.de \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.