From: Jakub Kicinski <kuba@kernel.org>
To: Jose Alonso <joalonsof@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
netdev <netdev@vger.kernel.org>, stable <stable@vger.kernel.org>,
Ronald Wahl <ronald.wahl@raritan.com>
Subject: Re: [PATCH v2 net] net: usb: ax88179_178a have issues with FLAG_SEND_ZLP
Date: Fri, 5 Aug 2022 17:51:55 -0700 [thread overview]
Message-ID: <20220805175155.6f021ff4@kernel.org> (raw)
In-Reply-To: <9a6829ee42e4e88639d35428c378f9da7802245b.camel@gmail.com>
On Fri, 05 Aug 2022 17:27:33 -0300 Jose Alonso wrote:
> To: David S. Miller <davem@davemloft.net>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: netdev <netdev@vger.kernel.org>, stable <stable@vger.kernel.org>, Ronald Wahl <ronald.wahl@raritan.com>
>
> [PATCH net] net: usb: ax88179_178a have issues with FLAG_SEND_ZLP
> The usage of FLAG_SEND_ZLP causes problems to other firmware/hardware
> versions that have no issues.
But you tested with 1790 previously so isn't the misbehaviour on that
device going to come back if we remove the flag again?
> The FLAG_SEND_ZLP is not safe to use in this context.
> See:
> https://patchwork.ozlabs.org/project/netdev/patch/1270599787.8900.8.camel@Linuxdev4-laptop/#118378
>
> Reported-by: Ronald Wahl <ronald.wahl@raritan.com>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216327
> Link: https://bugs.archlinux.org/task/75491
>
> Fixes: 36a15e1cb134 ("net: usb: ax88179_178a needs FLAG_SEND_ZLP")
> Signed-off-by: Jose Alonso <joalonsof@gmail.com>
The commit message looks unnecessarily indented, could you try with git
format-patch / git send-email?
next prev parent reply other threads:[~2022-08-06 0:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 20:27 [PATCH v2 net] net: usb: ax88179_178a have issues with FLAG_SEND_ZLP Jose Alonso
2022-08-06 0:51 ` Jakub Kicinski [this message]
2022-08-08 11:27 ` Jose Alonso
2022-08-06 15:23 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220805175155.6f021ff4@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=joalonsof@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ronald.wahl@raritan.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.