From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0DAF0C00140 for ; Fri, 5 Aug 2022 22:20:29 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1FED484869; Sat, 6 Aug 2022 00:20:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="VTXIWWqc"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id EAC5E84869; Sat, 6 Aug 2022 00:20:25 +0200 (CEST) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2960184839 for ; Sat, 6 Aug 2022 00:20:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82a.google.com with SMTP id w6so2546915qtv.9 for ; Fri, 05 Aug 2022 15:20:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=mlXZxAJJjLwW9NmBqMQ2MKdlRQpyCo52BbvCcNDz0Js=; b=VTXIWWqcxPIshsknV7r6k5uXoxSvBFtUM2RAeGnDmoXKbxuo4NZ3oqk6zra9F9/tCV uZqkTpN55VnvkWogCY3RUmNV1ZGG/ZjtoV3oi897G7XNNM1oTpWUxLvI69x4ZFVQjsBU 6C/JbuxRL2ds1jRomSlFy6742M7r4XXs3oqE4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=mlXZxAJJjLwW9NmBqMQ2MKdlRQpyCo52BbvCcNDz0Js=; b=kDA7zs7+T8ZG1vLtI19cC7PaKkMnlZiiC43n5cHYtD4/SSpPRtPZrEAxBXwnTd8xfq nxt1e/MJc7MZxCOXFJXVyqIGqGhyUctLgfrwbMi8e7wM4JbxaQfNqpKl5P3o6hTzxvIa fdpkXdFUkBNEX6tmkuF4yOZazgL6JuTAxpaMkedeIG+RybjcY1XFZRBEdwv/m0SeZvn3 Sz7ESBWziUbF2wA9G6k/wZprtzghyaF+dDbuTFzRqrhXNaq1ytaXn4U8+440kASG3rjz UPNnFrSsKfdxiztiCqkkAJqKzjMEl4j25Uo5KJV1pZmsyJs6mXAs+0wF+aI4nvpR4cyj XIbg== X-Gm-Message-State: ACgBeo1YDw1d72A44+jl/l9p5bq+ErYYHtP/HOtGS4o5mXky1FjXy6rc XdalNMguP5jcw/Gp5USm0IphBA== X-Google-Smtp-Source: AA6agR4a4slh94ZTpDrtBT/FquMZG+YAr2sVy3BxHx7bmOSaaZOrFWZoKy7kaUrhwuc9shawDQrKYA== X-Received: by 2002:ac8:5c83:0:b0:31e:e3ba:2be with SMTP id r3-20020ac85c83000000b0031ee3ba02bemr7852931qta.355.1659738021801; Fri, 05 Aug 2022 15:20:21 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id f15-20020a05620a408f00b006b5905999easm3952427qko.121.2022.08.05.15.20.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Aug 2022 15:20:20 -0700 (PDT) Date: Fri, 5 Aug 2022 18:20:19 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: u-boot@lists.denx.de, kabel@kernel.org Subject: Re: Broken commit de47ff536363289f92f85ed1e4901724d238432d Message-ID: <20220805222019.GE1146598@bill-the-cat> References: <20220803161318.GS1146598@bill-the-cat> <20220805142124.6swsha6aj62f33e3@pali> <20220805144731.GV1146598@bill-the-cat> <20220805145935.xumynhjbih3nekjq@pali> <20220805150340.GX1146598@bill-the-cat> <20220805151259.hdftfa3utfiq4i3w@pali> <20220805154400.GA1146598@bill-the-cat> <20220805155135.r5dctspg2oohzdev@pali> <20220805155453.GC1146598@bill-the-cat> <20220805201701.7t37kxn64qaiye3n@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Ms9aTwzPsqgNlb/T" Content-Disposition: inline In-Reply-To: <20220805201701.7t37kxn64qaiye3n@pali> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --Ms9aTwzPsqgNlb/T Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 05, 2022 at 10:17:01PM +0200, Pali Roh=E1r wrote: > On Friday 05 August 2022 11:54:53 Tom Rini wrote: > > On Fri, Aug 05, 2022 at 05:51:35PM +0200, Pali Roh=E1r wrote: > > > On Friday 05 August 2022 11:44:00 Tom Rini wrote: > > > > On Fri, Aug 05, 2022 at 05:12:59PM +0200, Pali Roh=E1r wrote: > > > > > On Friday 05 August 2022 11:03:40 Tom Rini wrote: > > > > > > On Fri, Aug 05, 2022 at 04:59:35PM +0200, Pali Roh=E1r wrote: > > > > > > > On Friday 05 August 2022 10:47:31 Tom Rini wrote: > > > > > > > > On Fri, Aug 05, 2022 at 04:21:24PM +0200, Pali Roh=E1r wrot= e: > > > > > > > > > On Wednesday 03 August 2022 12:13:18 Tom Rini wrote: > > > > > > > > > > On Wed, Aug 03, 2022 at 06:00:13PM +0200, Pali Roh=E1r = wrote: > > > > > > > > > > > On Tuesday 02 August 2022 06:58:26 Tom Rini wrote: > > > > > > > > > > > > On Tue, Aug 02, 2022 at 11:13:38AM +0200, Pali Roh= =E1r wrote: > > > > > > > > > > > >=20 > > > > > > > > > > > > > Hello Tom! > > > > > > > > > > > > >=20 > > > > > > > > > > > > > Your commit de47ff536363289f92f85ed1e4901724d2384= 32d ("Convert > > > > > > > > > > > > > CONFIG_SYS_MPC85XX_NO_RESETVEC to Kconfig") seems= to be broken. > > > > > > > > > > > >=20 > > > > > > > > > > > > I thought I had managed to mirror the TPL/SPL/full = usage that was there > > > > > > > > > > > > prior, but apparently some got missed. > > > > > > > > > > >=20 > > > > > > > > > > > Yea, conversion to Kconfig seems that was incorrect. > > > > > > > > > >=20 > > > > > > > > > > As the config files were just unclear, but you seem to = understand what > > > > > > > > > > it's supposed to be, a patch to clean it up would be mo= st appreciated, > > > > > > > > > > thanks. > > > > > > > > > >=20 > > > > > > > > > > --=20 > > > > > > > > > > Tom > > > > > > > > >=20 > > > > > > > > > Broken is also commit d433c74eecdce1e4952ef4e8c712a9289c0= dfcc2. Seems > > > > > > > > > that all kconfig migration changes done after that commit= are broken. > > > > > > > > >=20 > > > > > > > > > I really do not have energy to investigate what and how w= as broken due > > > > > > > > > to incorrect kconfig migration. > > > > > > > > >=20 > > > > > > > > >=20 > > > > > > > > > I did simple test. Applied following change: > > > > > > > > >=20 > > > > > > > > > diff --git a/include/configs/p1_p2_rdb_pc.h b/include/con= figs/p1_p2_rdb_pc.h > > > > > > > > > index a6523753d5ca..489f24df0ab1 100644 > > > > > > > > > --- a/include/configs/p1_p2_rdb_pc.h > > > > > > > > > +++ b/include/configs/p1_p2_rdb_pc.h > > > > > > > > > @@ -624,3 +624,7 @@ __stringify(__PCIE_RST_CMD)"\0" > > > > > > > > > "bootm $norbootaddr - $norfdtaddr" > > > > > > > > > =20 > > > > > > > > > #endif /* __CONFIG_H */ > > > > > > > > > + > > > > > > > > > +#ifdef CONFIG_SDCARD > > > > > > > > > +#error > > > > > > > > > +#endif > > > > > > > > >=20 > > > > > > > > > And then called: > > > > > > > > >=20 > > > > > > > > > make CROSS_COMPILE=3Dpowerpc-linux-gnuspe- P2020RDB-PC_de= fconfig u-boot.bin > > > > > > > > >=20 > > > > > > > > > And it failed, even when this defconfig file is not SD ca= rd builds. > > > > > > > >=20 > > > > > > > > Where is PBL in that case even then? > > > > > > >=20 > > > > > > > P2020 (and older) are pre-PBL boards, they do not support NXP= PBL > > > > > > > header. > > > > > >=20 > > > > > > Ah, OK, then it should just be removing TARGET_P2020RDB from th= e choice > > > > > > on "Freescale PBL load location". > > > > > >=20 > > > > > > --=20 > > > > > > Tom > > > > >=20 > > > > > I just do not understand. > > > > >=20 > > > > > P10** and P20** do not support NXP PBL. They support only pre-PBL= and > > > > > for SD card pre-PBL support I added option FSL_PREPBL_ESDHC_BOOT_= SECTOR. > > > > >=20 > > > > > But CONFIG_SDCARD is automatically set when SYS_EXTRA_OPTIONS con= tains > > > > > "SDCARD" string and CONFIG_SDCARD is used then also in P10** and = P20** > > > > > SD-card version of SPL to load proper U-Boot. > > > >=20 > > > > So CONFIG_SDCARD was over-loaded? That's very frustrating. That's w= hat > > > > needs to be corrected then. > > >=20 > > > But it was correct, no? CONFIG_SDCARD ensures that U-Boot is compiled= in > > > mode in which can be booted from SD card. Or what do you have in mind= as > > > purpose of this symbol? > > >=20 > > > The issue is that your Kconfig migration changes enabled CONFIG_SDCARD > > > also when building (parallel) NOR version of U-Boot. > >=20 > > To me, the biggest issue is that "CONFIG_SDCARD" exists. It's very much > > non-descriptive and that for some platforms it means "we have NXP PBL" > > and others means "we're booting from SDCARD". The former should be > > renamed to be descriptive, and the latter should re-use CONFIG_SD_CARD > > which is still a bad name, but what everyone else uses, so makes > > renaming it later to something less bad easier. >=20 > So I hope that you will do something with it. I already spent lot of > time to fix and improve powerpc support, but the result is that my > patches are on the list, mostly ignored; but changes which are breaking > powerpc support are happily merging. In this state I'm loosing any > motivation to continue development as it is needed to do again to find > out what new is broken. I'm not planning to try and further fiddle with those symbols. A simple revert is not possible as CONFIG_SYS_EXTRA_OPTIONS is gone. I assume that Marek will be picking up your PowerPC patches at this point, so any further work you're doing in that area shouldn't be delayed. I'll put re-examining this on my TODO list, but it's below finishing my CONFIG_SYS_* audit, and then renaming stuff to CFG_SYS. You should fix whatever platforms you have access to and ignore the rest, I feel likely to be removing most of them shortly at this point. --=20 Tom --Ms9aTwzPsqgNlb/T Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmLtl6AACgkQFHw5/5Y0 tyxmqAv/c15ltOLIsS3OhAzn0Zl3R86MAgSn4bIG9t7OKMYcWjW1CacEM9gBi1fZ X8/yk/o98di8+XnhtALnEX3YrLE7bWy/dKKthB1UvjJlMT2g+9UBZR6Ryo7VYhhs jwrmT/MIGrL7tQNiPnMWk7Qagd/T1563lOaFx9KQxXxrmzmwGgHGdAPiSzgmEho1 9ayApe1jtOFFk69E35G79cLXyOahooK07UWGCtpTVsTLn3e4FKbgRyjPF6JVQMTa tBAfpdRz18qgyLcGZAsCXqiP91WPCnP7fwMMZOqPuMgtcuNQgGQUXjpJHdmZLKk7 mhVHJb+XTUFt4cPqiTMaYWEbXcnehEknuhaOukYSabw63vZbi2fr3SrTPSaJXOfK q2rOIsNOGBcQx9UiSLcaiYWFWgEd6WSeerCcCCKCB3xanIqgv9bCzWSkHPfPGOeB ZY46QfbnPM7SpEcpZif+UlETXOfVWArp5wfheT53UYm9hcYVFpaafSRiHwHcs8ms 3bC96I1L =HUYL -----END PGP SIGNATURE----- --Ms9aTwzPsqgNlb/T--