All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Jianmin Lv <lvjianmin@loongson.cn>,
	lpieralisi@kernel.org, robin.murphy@arm.com,
	guohanjun@huawei.com, sudeep.holla@arm.com, rafael@kernel.org,
	lenb@kernel.org, robert.moore@intel.com
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	linux-acpi@vger.kernel.org
Subject: Re: [PATCH V2 2/2] LoongArch: Remove ARCH_HAS_PHYS_TO_DMA
Date: Sat, 6 Aug 2022 00:36:27 +0800	[thread overview]
Message-ID: <202208060021.6kjospL6-lkp@intel.com> (raw)
In-Reply-To: <1659684674-40612-3-git-send-email-lvjianmin@loongson.cn>

Hi Jianmin,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on rafael-pm/linux-next]
[also build test WARNING on linus/master v5.19 next-20220804]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jianmin-Lv/DMA-update-acpi_dma_get_range-to-return-dma-map-regions/20220805-153307
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: loongarch-randconfig-r011-20220805 (https://download.01.org/0day-ci/archive/20220806/202208060021.6kjospL6-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/30f8fbc6b485f30e8533a7848a4ad9a2e1351be8
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Jianmin-Lv/DMA-update-acpi_dma_get_range-to-return-dma-map-regions/20220805-153307
        git checkout 30f8fbc6b485f30e8533a7848a4ad9a2e1351be8
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=loongarch SHELL=/bin/bash arch/loongarch/kernel/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> arch/loongarch/kernel/dma.c:8:6: warning: no previous prototype for 'acpi_arch_dma_setup' [-Wmissing-prototypes]
       8 | void acpi_arch_dma_setup(struct device *dev)
         |      ^~~~~~~~~~~~~~~~~~~


vim +/acpi_arch_dma_setup +8 arch/loongarch/kernel/dma.c

     7	
   > 8	void acpi_arch_dma_setup(struct device *dev)
     9	{
    10		int ret;
    11		const struct bus_dma_region *map = NULL;
    12	
    13		ret = acpi_dma_get_range(dev, &map);
    14		if (!ret) {
    15			const struct bus_dma_region *r = map;
    16			u64 mask, dma_start, dma_end = 0;
    17	
    18			/* determine the overall bounds of all dma regions */
    19			for (dma_start = U64_MAX; r->size; r++) {
    20	
    21				/* Take lower and upper limits */
    22				if (r->dma_start < dma_start)
    23					dma_start = r->dma_start;
    24				if (r->dma_start + r->size - 1 > dma_end)
    25					dma_end = r->dma_start + r->size - 1;
    26			}
    27	
    28			if (dma_start >= dma_end) {
    29				dev_dbg(dev, "Invalid DMA regions configuration\n");
    30				return;
    31			}
    32	
    33			mask = DMA_BIT_MASK(ilog2(dma_end) + 1);
    34			dev->bus_dma_limit = dma_end;
    35			dev->dma_range_map = map;
    36			dev->coherent_dma_mask = min(dev->coherent_dma_mask, mask);
    37			*dev->dma_mask = min(*dev->dma_mask, mask);
    38		}
    39	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

      reply	other threads:[~2022-08-05 16:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-05  7:31 [PATCH V2 0/2] DMA: update acpi_dma_get_range to return dma map regions Jianmin Lv
2022-08-05  7:31 ` [PATCH V2 1/2] ACPI / scan: Support multiple dma windows with different offsets Jianmin Lv
2022-08-05 12:46   ` Robin Murphy
2022-08-06  6:13     ` Jianmin Lv
2022-08-06  7:21       ` Jianmin Lv
2022-08-08  8:24     ` Lorenzo Pieralisi
2022-08-12  7:52     ` Lorenzo Pieralisi
2022-08-29 13:00       ` Jianmin Lv
2022-08-05  7:31 ` [PATCH V2 2/2] LoongArch: Remove ARCH_HAS_PHYS_TO_DMA Jianmin Lv
2022-08-05 16:36   ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202208060021.6kjospL6-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=guohanjun@huawei.com \
    --cc=kbuild-all@lists.01.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=lvjianmin@loongson.cn \
    --cc=rafael@kernel.org \
    --cc=robert.moore@intel.com \
    --cc=robin.murphy@arm.com \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.