From: Michael Straube <straube.linux@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Michael Straube <straube.linux@gmail.com>
Subject: [PATCH 1/3] staging: r8188eu: use ffs() in phy_CalculateBitShift()
Date: Sat, 6 Aug 2022 08:09:27 +0200 [thread overview]
Message-ID: <20220806060929.11022-2-straube.linux@gmail.com> (raw)
In-Reply-To: <20220806060929.11022-1-straube.linux@gmail.com>
Use ffs() in phy_CalculateBitShift() to simplify the function and
improve readability.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/r8188eu/hal/rtl8188e_phycfg.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/r8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/r8188eu/hal/rtl8188e_phycfg.c
index dea6d915a1f4..3d8fcc1f0b6a 100644
--- a/drivers/staging/r8188eu/hal/rtl8188e_phycfg.c
+++ b/drivers/staging/r8188eu/hal/rtl8188e_phycfg.c
@@ -25,13 +25,9 @@
*/
static u32 phy_CalculateBitShift(u32 BitMask)
{
- u32 i;
+ u32 i = ffs(BitMask);
- for (i = 0; i <= 31; i++) {
- if (((BitMask >> i) & 0x1) == 1)
- break;
- }
- return i;
+ return i ? i - 1 : 32;
}
/**
--
2.37.1
next prev parent reply other threads:[~2022-08-06 6:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-06 6:09 [PATCH 0/3] staging: r8188eu: clean up phy_CalculateBitShift() Michael Straube
2022-08-06 6:09 ` Michael Straube [this message]
2022-08-06 6:09 ` [PATCH 2/3] staging: r8188eu: avoid camel case in phy_CalculateBitShift() Michael Straube
2022-08-06 6:09 ` [PATCH 3/3] staging: r8188eu: clean up comment for phy_calculate_bit_shift() Michael Straube
2022-08-06 18:18 ` [PATCH 0/3] staging: r8188eu: clean up phy_CalculateBitShift() Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220806060929.11022-2-straube.linux@gmail.com \
--to=straube.linux@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.