All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: linux-iio@vger.kernel.org
Cc: "Nuno Sá" <nuno.sa@analog.com>,
	"Jonathan Cameron" <Jonathan.Cameron@huawei.com>
Subject: [PATCH 1/4] staging: iio: frequency: ad9832: Fix alignment for DMA safety
Date: Sun,  7 Aug 2022 16:12:15 +0100	[thread overview]
Message-ID: <20220807151218.656881-2-jic23@kernel.org> (raw)
In-Reply-To: <20220807151218.656881-1-jic23@kernel.org>

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

____cacheline_aligned is an insufficient guarantee for non-coherent DMA
on platforms with 128 byte cachelines above L1.  Switch to the updated
IIO_DMA_MINALIGN definition.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
 drivers/staging/iio/frequency/ad9832.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c
index f43464db618a..ce9fcba6bc5c 100644
--- a/drivers/staging/iio/frequency/ad9832.c
+++ b/drivers/staging/iio/frequency/ad9832.c
@@ -112,7 +112,7 @@ struct ad9832_state {
 	 * transfer buffers to live in their own cache lines.
 	 */
 	union {
-		__be16			freq_data[4]____cacheline_aligned;
+		__be16			freq_data[4] __aligned(IIO_DMA_MINALIGN);
 		__be16			phase_data[2];
 		__be16			data;
 	};
-- 
2.37.1


  reply	other threads:[~2022-08-07 15:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-07 15:12 [PATCH 0/4] staging: iio: DMA alignment fixes Jonathan Cameron
2022-08-07 15:12 ` Jonathan Cameron [this message]
2022-08-08  9:18   ` [PATCH 1/4] staging: iio: frequency: ad9832: Fix alignment for DMA safety Andy Shevchenko
2022-08-08 14:14     ` Jonathan Cameron
2022-08-07 15:12 ` [PATCH 2/4] staging: iio: frequency: ad9834: " Jonathan Cameron
2022-08-07 15:12 ` [PATCH 3/4] staging: iio: meter: ade7854: " Jonathan Cameron
2022-08-07 15:12 ` [PATCH 4/4] staging: iio: resolver: ad2s1210: " Jonathan Cameron
2022-08-08  9:20 ` [PATCH 0/4] staging: iio: DMA alignment fixes Andy Shevchenko
2022-08-13 16:01   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220807151218.656881-2-jic23@kernel.org \
    --to=jic23@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.