From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Johan Hovold <johan+linaro@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] arm64: dts: qcom: sc8280xp: disallow regulator mode switches
Date: Mon, 8 Aug 2022 13:40:31 +0530 [thread overview]
Message-ID: <20220808081031.GC7601@thinkpad> (raw)
In-Reply-To: <20220803121942.30236-1-johan+linaro@kernel.org>
On Wed, Aug 03, 2022 at 02:19:39PM +0200, Johan Hovold wrote:
> A recent change in a USB/DP PHY driver that started specifying regulator
> loads caused the regulators that were also shared with the PCIe and USB
> PHYs to be put in low-power mode, something which broke PCIe and USB on
> sa8295p-adp.
>
> As was discussed in the following thread:
>
> https://lore.kernel.org/all/YtkrDcjTGhpaU1e0@hovoldconsulting.com
>
> regulators should generally not be allowed to switch to low-power mode
> unless some of the consumers can actually support an idle mode.
>
> This series disables mode-switching for all regulators on sc8280xp-crd,
> sc8280xp-lenovo-thinkpad-x13s and sa8295p-adp except for the ones used
> by the UFS controllers which do support an idle mode.
>
For the series,
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> Johan
>
>
> Johan Hovold (3):
> arm64: dts: qcom: sc8280xp-crd: disallow regulator mode switches
> arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: disallow regulator
> mode switches
> arm64: dts: qcom: sa8295p-adp: disallow regulator mode switches
>
> arch/arm64/boot/dts/qcom/sa8295p-adp.dts | 11 -----------
> arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 9 ---------
> .../boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 10 ----------
> 3 files changed, 30 deletions(-)
>
> --
> 2.35.1
>
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2022-08-08 8:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 12:19 [PATCH 0/3] arm64: dts: qcom: sc8280xp: disallow regulator mode switches Johan Hovold
2022-08-03 12:19 ` [PATCH 1/3] arm64: dts: qcom: sc8280xp-crd: " Johan Hovold
2022-08-03 12:19 ` [PATCH 2/3] arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: " Johan Hovold
2022-08-03 12:19 ` [PATCH 3/3] arm64: dts: qcom: sa8295p-adp: " Johan Hovold
2022-08-08 8:10 ` Manivannan Sadhasivam [this message]
2022-08-29 23:45 ` [PATCH 0/3] arm64: dts: qcom: sc8280xp: " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220808081031.GC7601@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.