From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38367C00140 for ; Mon, 8 Aug 2022 10:10:38 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 9FC483C9485 for ; Mon, 8 Aug 2022 12:10:36 +0200 (CEST) Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [217.194.8.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 500353C91FE for ; Mon, 8 Aug 2022 12:10:26 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id C8FE41000741 for ; Mon, 8 Aug 2022 12:10:25 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5807637629; Mon, 8 Aug 2022 10:10:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1659953425; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XuQFlsi9xFlsvW9m3zSVoMzGCvic80f9VJmocYWKTZE=; b=EKaJK0KnRaKwahlCLIver6nHP6Q840KymcP7bw3vHo4RFu8USBgj2x+vXhM6Bh8fmWIar/ 75WlQEfgNFXMnfrFMef1kQnqRxL2m04vJeVoMTMFYvQTvVO2a4R/l5kXb5ICLLjdIagfgK c7thvGmc3YGzEWIbWgBm9eA8ubDTh7c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1659953425; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XuQFlsi9xFlsvW9m3zSVoMzGCvic80f9VJmocYWKTZE=; b=h5ny3dEuvkY2kN0oZrub9tncSK3DpGwKzPfPk/B9ksu8Tl80Zu64iZEHtnj2NOIID7J3vE 3P8cIFtyxQo21gBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 342C313A7C; Mon, 8 Aug 2022 10:10:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id yL53CxHh8GKkAgAAMHmgww (envelope-from ); Mon, 08 Aug 2022 10:10:25 +0000 From: Petr Vorel To: ltp@lists.linux.it Date: Mon, 8 Aug 2022 12:10:19 +0200 Message-Id: <20220808101019.29892-5-pvorel@suse.cz> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220808101019.29892-1-pvorel@suse.cz> References: <20220808101019.29892-1-pvorel@suse.cz> MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.102.4 at in-4.smtp.seeweb.it X-Virus-Status: Clean Subject: [LTP] [PATCH v3 4/4] generate_lvm_runfile.sh: Fix bashism X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" ERR is not on dash (tested on 0.5.11). using -e (i.e. implying 'set -e') is required to exit on any non zero exit code. It requires 2 previous fixes. Signed-off-by: Petr Vorel --- testcases/misc/lvm/generate_lvm_runfile.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/testcases/misc/lvm/generate_lvm_runfile.sh b/testcases/misc/lvm/generate_lvm_runfile.sh index 72b286a69..aba706c64 100755 --- a/testcases/misc/lvm/generate_lvm_runfile.sh +++ b/testcases/misc/lvm/generate_lvm_runfile.sh @@ -1,6 +1,7 @@ -#!/bin/sh +#!/bin/sh -e # SPDX-License-Identifier: GPL-2.0-or-later # Copyright (c) 2020 SUSE LLC +# Copyright (c) Linux Test Project, 2022 # # Generate LTP runfile for LVM tests (runtest/lvm.local) @@ -13,7 +14,7 @@ LVM_TMPDIR="$LVM_DIR/ltp/growfiles" generate_runfile() { - trap 'tst_brk TBROK "Cannot create LVM runfile"' ERR + trap '[ $? -eq 0 ] || tst_brk TBROK "Cannot create LVM runfile"' EXIT INFILE="$LTPROOT/testcases/data/lvm/runfile.tpl" OUTFILE="$LTPROOT/runtest/lvm.local" FS_LIST=`tst_supported_fs` -- 2.37.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp