From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D29D3C00140 for ; Mon, 8 Aug 2022 14:30:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243134AbiHHOaP convert rfc822-to-8bit (ORCPT ); Mon, 8 Aug 2022 10:30:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242421AbiHHOaN (ORCPT ); Mon, 8 Aug 2022 10:30:13 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E61202DEC for ; Mon, 8 Aug 2022 07:30:10 -0700 (PDT) Received: from fraeml714-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4M1dns2bNrz67xX3; Mon, 8 Aug 2022 22:27:29 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (7.191.163.240) by fraeml714-chm.china.huawei.com (10.206.15.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 8 Aug 2022 16:30:08 +0200 Received: from localhost (10.202.226.42) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 8 Aug 2022 15:30:08 +0100 Date: Mon, 8 Aug 2022 15:30:07 +0100 From: Jonathan Cameron To: Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= CC: Jean Delvare , Guenter Roeck , , Steen Hegelund , , Lars Povlsen , , Nuno =?ISO-8859-1?Q?S=E1?= , Subject: Re: [PATCH] hwmon: Make use of devm_clk_get_enabled() Message-ID: <20220808153007.00007208@huawei.com> In-Reply-To: <20220808075408.i63dtoe66hm7xwta@pengutronix.de> References: <20220808060640.272549-1-u.kleine-koenig@pengutronix.de> <20220808075408.i63dtoe66hm7xwta@pengutronix.de> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8BIT X-Originating-IP: [10.202.226.42] X-ClientProxiedBy: lhrpeml100001.china.huawei.com (7.191.160.183) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On Mon, 8 Aug 2022 09:54:08 +0200 Uwe Kleine-König wrote: > On Mon, Aug 08, 2022 at 08:06:40AM +0200, Uwe Kleine-König wrote: > > Several drivers manually register a devm handler to disable their clk. > > Convert them to devm_clk_get_enabled(). > > > > Acked-by: Guenter Roeck > > Reviewed-by: Nuno Sá > > Acked-by: Jonathan Cameron > > Oh, the tags by Nuno Sá and Jonathan Cameron are a fake. I picked them > by mistake from the (similar) patch for iio. Please take care about that > before application. (i.e. drop them, or make me resend the patch without > the tags, or make the two give the tags post-factum :-) > > Best regards and sorry for the chaos, > Uwe > Much like the IIO one you may get a request to split it by driver. I personally prefer per driver patches as Andy suggested, but meh, it is up to the hmwon maintainer. I'm feeling particularly unhelpful today. As it's not IIO patches going through another tree (like the IIO one was when I gave that tag): + simple patch to quickly review. Reviewed-by: Jonathan Cameron *evil laugh* From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55554C00140 for ; Mon, 8 Aug 2022 14:31:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sUqMZ5biot1JbXYv6zp/y4U5QysvgkXNPpjjDTFfxLY=; b=Z3zXh5xNeIORL8 iQ9bk8Uu2Bp62mRqEBuRq//UMx40vtqiB3nVYtzRtAWJadox7YRs4beiH1RVUuZ4X7I9Sz3H/sFRt C9g9qwtfxhMpeqV0j+sEoX4NDhakx6eqye348X743V8BkWynTHjLaoic7NGa7VOYHmdx9IbNgXLUT UY27+ma5R006H/E7ZOLlzTyZhNmwV9smtLjAQlDk6rKckkab0FcigGd8inN4LW+3HXEEb6kaWKoAX kHpccvUSj0rzNg0XKvosCI6O5Vr0NA84QLzqVCLVVXRxy2DrFWNeOEeTolktWdvj4LCjxecwDEmNm BKEhHnRwldMIm9t0TUgA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oL3lz-00EOmw-OG; Mon, 08 Aug 2022 14:30:27 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oL3lw-00EOgk-82 for linux-arm-kernel@lists.infradead.org; Mon, 08 Aug 2022 14:30:26 +0000 Received: from fraeml714-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4M1dns2bNrz67xX3; Mon, 8 Aug 2022 22:27:29 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (7.191.163.240) by fraeml714-chm.china.huawei.com (10.206.15.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 8 Aug 2022 16:30:08 +0200 Received: from localhost (10.202.226.42) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 8 Aug 2022 15:30:08 +0100 Date: Mon, 8 Aug 2022 15:30:07 +0100 From: Jonathan Cameron To: Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= CC: Jean Delvare , Guenter Roeck , , Steen Hegelund , , Lars Povlsen , , Nuno =?ISO-8859-1?Q?S=E1?= , Subject: Re: [PATCH] hwmon: Make use of devm_clk_get_enabled() Message-ID: <20220808153007.00007208@huawei.com> In-Reply-To: <20220808075408.i63dtoe66hm7xwta@pengutronix.de> References: <20220808060640.272549-1-u.kleine-koenig@pengutronix.de> <20220808075408.i63dtoe66hm7xwta@pengutronix.de> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; i686-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.202.226.42] X-ClientProxiedBy: lhrpeml100001.china.huawei.com (7.191.160.183) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220808_073024_501884_944E675D X-CRM114-Status: GOOD ( 12.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 8 Aug 2022 09:54:08 +0200 Uwe Kleine-K=F6nig wrote: > On Mon, Aug 08, 2022 at 08:06:40AM +0200, Uwe Kleine-K=F6nig wrote: > > Several drivers manually register a devm handler to disable their clk. > > Convert them to devm_clk_get_enabled(). > > = > > Acked-by: Guenter Roeck > > Reviewed-by: Nuno S=E1 > > Acked-by: Jonathan Cameron = > = > Oh, the tags by Nuno S=E1 and Jonathan Cameron are a fake. I picked them > by mistake from the (similar) patch for iio. Please take care about that > before application. (i.e. drop them, or make me resend the patch without > the tags, or make the two give the tags post-factum :-) > = > Best regards and sorry for the chaos, > Uwe > = Much like the IIO one you may get a request to split it by driver. I personally prefer per driver patches as Andy suggested, but meh, it is up to the hmwon maintainer. I'm feeling particularly unhelpful today. As it's not IIO patches going through another tree (like the IIO one was when I gave that tag): + simple patch to quickly review. Reviewed-by: Jonathan Cameron *evil laugh* _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel