From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05D5DC25B07 for ; Tue, 9 Aug 2022 07:19:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660029588; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=jVRrOoJ0NjvtPJRtk76vg/Z2Od+pkzDL5N3sEgKLiQk=; b=jTIYSA01nOPQ4TvRL7Bvar5nXqahVx2GEflE460DOjJxFRPxFdRWbKsykHx9kaC1aMsR7h igDheAQA4cKp2jSUYACYem9HaF2q+/G1YORB31DZcL7rpFBu3l7ckBhFhGJTTAhYf4LoIK R5d+0tCTe/j2J/TxPHoD875qBwZbmEY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-395-tjmjx-KjP4-7IEfQBrH6Vw-1; Tue, 09 Aug 2022 03:19:46 -0400 X-MC-Unique: tjmjx-KjP4-7IEfQBrH6Vw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 86A453C0E20D; Tue, 9 Aug 2022 07:19:44 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 75DB39457F; Tue, 9 Aug 2022 07:19:44 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 55CFC1946A58; Tue, 9 Aug 2022 07:19:44 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id B6D7E1946A44 for ; Tue, 9 Aug 2022 07:19:43 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id A6B06C15BA3; Tue, 9 Aug 2022 07:19:43 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast09.extmail.prod.ext.rdu2.redhat.com [10.11.55.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A32F5C15BA1 for ; Tue, 9 Aug 2022 07:19:43 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8EF4F2806AA8 for ; Tue, 9 Aug 2022 07:19:43 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-663-h8g21YPpPta5vhIgDqHadw-1; Tue, 09 Aug 2022 03:19:41 -0400 X-MC-Unique: h8g21YPpPta5vhIgDqHadw-1 Received: by verein.lst.de (Postfix, from userid 2407) id 2163668BEB; Tue, 9 Aug 2022 09:19:39 +0200 (CEST) Date: Tue, 9 Aug 2022 09:19:38 +0200 From: Christoph Hellwig To: Mike Christie Message-ID: <20220809071938.GC11161@lst.de> References: <20220809000419.10674-1-michael.christie@oracle.com> <20220809000419.10674-7-michael.christie@oracle.com> MIME-Version: 1.0 In-Reply-To: <20220809000419.10674-7-michael.christie@oracle.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Subject: Re: [dm-devel] [PATCH v2 06/20] nvme: Fix reservation status related structs X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: axboe@kernel.dk, james.bottomley@hansenpartnership.com, bvanassche@acm.org, martin.petersen@oracle.com, snitzer@kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, dm-devel@redhat.com, linux-scsi@vger.kernel.org, hch@lst.de Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Aug 08, 2022 at 07:04:05PM -0500, Mike Christie wrote: > This fixes the following issues with the reservation status structs: > > 1. resv10 is bytes 23:10 so it should be 14 bytes. > 2. regctl_ds only supports 64 bit host IDs. This doesn't actually seem to be used by the kernel at all. Which I guess means I need to go back into my todo list and tackle the discussion if we want to have non-kernel bits in nvme.h to start with. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F729C19F2D for ; Tue, 9 Aug 2022 07:19:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232412AbiHIHTo (ORCPT ); Tue, 9 Aug 2022 03:19:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230141AbiHIHTm (ORCPT ); Tue, 9 Aug 2022 03:19:42 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C627A20BFC; Tue, 9 Aug 2022 00:19:41 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 2163668BEB; Tue, 9 Aug 2022 09:19:39 +0200 (CEST) Date: Tue, 9 Aug 2022 09:19:38 +0200 From: Christoph Hellwig To: Mike Christie Cc: bvanassche@acm.org, linux-block@vger.kernel.org, dm-devel@redhat.com, snitzer@kernel.org, axboe@kernel.dk, hch@lst.de, linux-nvme@lists.infradead.org, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, james.bottomley@hansenpartnership.com Subject: Re: [PATCH v2 06/20] nvme: Fix reservation status related structs Message-ID: <20220809071938.GC11161@lst.de> References: <20220809000419.10674-1-michael.christie@oracle.com> <20220809000419.10674-7-michael.christie@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220809000419.10674-7-michael.christie@oracle.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Mon, Aug 08, 2022 at 07:04:05PM -0500, Mike Christie wrote: > This fixes the following issues with the reservation status structs: > > 1. resv10 is bytes 23:10 so it should be 14 bytes. > 2. regctl_ds only supports 64 bit host IDs. This doesn't actually seem to be used by the kernel at all. Which I guess means I need to go back into my todo list and tackle the discussion if we want to have non-kernel bits in nvme.h to start with.