From: "Marek Behún" <kabel@kernel.org>
To: "Pali Rohár" <pali@kernel.org>, "Stefan Roese" <sr@denx.de>
Cc: "Paweł Anikiel" <pan@semihalf.com>,
"Adrian Fiergolski" <adrian.fiergolski@fastree3d.com>,
"Simon Glass" <sjg@chromium.org>,
u-boot@lists.denx.de
Subject: Re: [PATCH] misc: atsha204a: Don't check for error when waking up the device
Date: Tue, 9 Aug 2022 09:56:48 +0200 [thread overview]
Message-ID: <20220809095648.29b726b5@thinkpad> (raw)
In-Reply-To: <20220804110344.24268-1-pali@kernel.org>
On Thu, 4 Aug 2022 13:03:44 +0200
Pali Rohár <pali@kernel.org> wrote:
> The device ignores any levels or transitions on the SCL pin when the device
> is idle, asleep or during waking up.
>
> Linux kernel driver for atsha204a (atmel-sha204a.ko) also ignores return
> value from i2c wakeup send command, see:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/crypto/atmel-i2c.c?h=v5.19#n174
>
> And also userspace Turris libatsha204 library ignores return value from
> wakeup send command, see:
> https://gitlab.nic.cz/turris/libatsha204/-/blob/v29.2/src/libatsha204/layer_ni2c.c#L75-76
>
> U-Boot driver should do same thing.
>
> Fixes waking up ATSHA204 on Turris 1.x boards.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Marek Behún <kabel@kernel.org>
Stefan, will you apply this via marvell?
next prev parent reply other threads:[~2022-08-09 7:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 11:03 [PATCH] misc: atsha204a: Don't check for error when waking up the device Pali Rohár
2022-08-05 10:46 ` Stefan Roese
2022-08-07 19:30 ` Pali Rohár
2022-08-08 9:29 ` Paweł Anikiel
2022-08-09 7:56 ` Marek Behún [this message]
2022-08-09 7:58 ` Stefan Roese
2022-08-09 11:36 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220809095648.29b726b5@thinkpad \
--to=kabel@kernel.org \
--cc=adrian.fiergolski@fastree3d.com \
--cc=pali@kernel.org \
--cc=pan@semihalf.com \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.