From: Stephen Hemminger <stephen@networkplumber.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
bhelgaas@google.com, gregkh@linuxfoundation.org
Cc: linux-pci@vger.kernel.org
Subject: [REGRESSION] changes to driver_override parsing broke DPDK script
Date: Tue, 9 Aug 2022 11:29:43 -0700 [thread overview]
Message-ID: <20220809112943.393684af@hermes.local> (raw)
This commit broke the driver override script in DPDK.
This is an API/ABI breakage, please revert or fix the commit.
Report of problem:
http://mails.dpdk.org/archives/dev/2022-August/247794.html
commit 23d99baf9d729ca30b2fb6798a7b403a37bfb800
Author: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Date: Tue Apr 19 13:34:28 2022 +0200
PCI: Use driver_set_override() instead of open-coding
Use a helper to set driver_override to the reduce amount of duplicated
code. Make the driver_override field const char, because it is not
modified by the core and it matches other subsystems.
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20220419113435.246203-6-krzysztof.kozlowski@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
The script is sending single nul character to remove override
and that no longer works.
Source code to dpdk-devbind
https://github.com/DPDK/dpdk/blob/main/usertools/dpdk-devbind.py
next reply other threads:[~2022-08-09 18:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 18:29 Stephen Hemminger [this message]
2022-08-09 19:21 ` [REGRESSION] changes to driver_override parsing broke DPDK script Bjorn Helgaas
2022-08-10 5:54 ` Krzysztof Kozlowski
2022-08-10 6:11 ` Greg KH
2022-08-10 8:21 ` Greg KH
2022-08-12 1:48 ` Dongdong Liu
2022-08-12 2:54 ` lihuisong (C)
2022-08-12 5:46 ` Greg KH
2022-09-01 16:41 ` Greg KH
2022-08-10 6:13 ` Krzysztof Kozlowski
2022-08-10 14:03 ` Stephen Hemminger
2022-08-10 14:06 ` Stephen Hemminger
2022-08-10 5:45 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220809112943.393684af@hermes.local \
--to=stephen@networkplumber.org \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.