All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
	linux-can@vger.kernel.org, kernel@pengutronix.de,
	"Sebastian Würl" <sebastian.wuerl@ororatech.com>
Subject: Re: [PATCH net 4/4] can: mcp251x: Fix race condition on receive interrupt
Date: Tue, 9 Aug 2022 11:50:16 -0700	[thread overview]
Message-ID: <20220809115016.1db564b3@kernel.org> (raw)
In-Reply-To: <20220809075317.1549323-5-mkl@pengutronix.de>

On Tue,  9 Aug 2022 09:53:17 +0200 Marc Kleine-Budde wrote:
> @@ -1082,6 +1079,18 @@ static irqreturn_t mcp251x_can_ist(int irq, void *dev_id)
>  			if (mcp251x_is_2510(spi))
>  				mcp251x_write_bits(spi, CANINTF,
>  						   CANINTF_RX0IF, 0x00);
> +
> +			/* check if buffer 1 is already known to be full, no need to re-read */
> +			if (!(intf & CANINTF_RX1IF)) {
> +				u8 intf1, eflag1;
> +				

This line is full of trailing whitespace, could you add a fix on top to
remove it and resend?

  reply	other threads:[~2022-08-09 19:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-09  7:53 [PATCH net 0/4] pull-request: can 2022-08-09 Marc Kleine-Budde
2022-08-09  7:53 ` [PATCH net 1/4] can: j1939: j1939_sk_queue_activate_next_locked(): replace WARN_ON_ONCE with netdev_warn_once() Marc Kleine-Budde
2022-08-09  7:53 ` [PATCH net 2/4] can: j1939: j1939_session_destroy(): fix memory leak of skbs Marc Kleine-Budde
2022-08-09  7:53 ` [PATCH net 3/4] can: ems_usb: fix clang's -Wunaligned-access warning Marc Kleine-Budde
2022-08-09  7:53 ` [PATCH net 4/4] can: mcp251x: Fix race condition on receive interrupt Marc Kleine-Budde
2022-08-09 18:50   ` Jakub Kicinski [this message]
2022-08-10  7:19     ` Marc Kleine-Budde
  -- strict thread matches above, loose matches on Subject: below --
2022-08-10  7:14 [PATCH net 0/n] pull-request: can 2022-08-10 Marc Kleine-Budde
2022-08-10  7:14 ` [PATCH net 4/4] can: mcp251x: Fix race condition on receive interrupt Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220809115016.1db564b3@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=kernel@pengutronix.de \
    --cc=linux-can@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=sebastian.wuerl@ororatech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.