From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: "Kadam, Pallavi" <pallavi.kadam@intel.com>
Cc: <dev@dpdk.org>, <thomas@monjalon.net>, <ranjit.menon@intel.com>,
<Narcisa.Vasile@microsoft.com>, <roretzla@linux.microsoft.com>,
<qiao.liu@intel.com>
Subject: Re: [dpdk-kmods] windows/netuio: fix bar parsing
Date: Tue, 9 Aug 2022 12:15:48 +0300 [thread overview]
Message-ID: <20220809121548.00a18082@sovereign> (raw)
In-Reply-To: <ed8590ed-4628-f25a-9659-ca9a7b92aa86@intel.com>
2022-08-08 17:33 (UTC-0700), Kadam, Pallavi:
[...]
> > Hi Pallavi,
> >
> > In the first place, it was wrong to always test `prev_bar & PCI_TYPE_64BIT`
> > because only the first BAR slot of a 64-bit BAR contains flags.
> > The current code has a state to track (curr_bar, prev_bar),
> > and the fix is complicating it even more without solving the root cause.
> > I suggest a simpler fix (not tested!)
> > that eliminates both the incorrectness and the state to maintain:
>
> Thank you. This change works for us.
>
> Please let me know if you would like to submit this change as a new patch or if I should include it as a v2 of this same patch.
Please send v2.
You can include my Signed-off-by.
You might also update the commit message and capitalize "BAR" in the title.
next prev parent reply other threads:[~2022-08-09 9:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 19:10 [dpdk-kmods] windows/netuio: fix bar parsing Pallavi Kadam
2022-08-06 21:01 ` Dmitry Kozlyuk
2022-08-08 20:40 ` Kadam, Pallavi
2022-08-09 0:33 ` Kadam, Pallavi
2022-08-09 9:15 ` Dmitry Kozlyuk [this message]
2022-08-11 22:21 ` Kadam, Pallavi
2022-08-11 22:17 ` [dpdk-kmods v2] windows/netuio: fix BAR parsing Pallavi Kadam
2022-08-18 2:51 ` Liu, Qiao
2022-08-19 18:13 ` Menon, Ranjit
2022-08-29 8:04 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220809121548.00a18082@sovereign \
--to=dmitry.kozliuk@gmail.com \
--cc=Narcisa.Vasile@microsoft.com \
--cc=dev@dpdk.org \
--cc=pallavi.kadam@intel.com \
--cc=qiao.liu@intel.com \
--cc=ranjit.menon@intel.com \
--cc=roretzla@linux.microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.