From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Antoine Tenart <atenart@kernel.org>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] package/refpolicy: set default values for custom repo
Date: Tue, 9 Aug 2022 13:34:12 +0200 [thread overview]
Message-ID: <20220809133412.521708e3@windsurf> (raw)
In-Reply-To: <20220809083325.1906594-2-fontaine.fabrice@gmail.com>
Hello Fabrice,
On Tue, 9 Aug 2022 10:33:25 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Set default values for custom repo to make sure that a random
> configuration with an empty repo location or version for refpolicy
> doesn't fail.
>
> Fixes:
> - http://autobuild.buildroot.org/results/98da07a1f9b88e2e8a028a55c8cf76c6ebc28304
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
I don't think that's the right way of solving this, because it would be
inconsistent with what we do for Linux, U-Boot, Barebox, TF-A and all
those projects that have a configurable version/repository option.
So I have instead applied your patch fixing the indentation in
genrandconfig.
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-08-09 11:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 8:33 [Buildroot] [PATCH 1/2] Revert "utils/genrandconfig: add refpolicy custom git handling" Fabrice Fontaine
2022-08-09 8:33 ` [Buildroot] [PATCH 2/2] package/refpolicy: set default values for custom repo Fabrice Fontaine
2022-08-09 11:34 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220809133412.521708e3@windsurf \
--to=buildroot@buildroot.org \
--cc=atenart@kernel.org \
--cc=fontaine.fabrice@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.