All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Alistair Francis <alistair@alistair23.me>
Cc: Jagan Teki <jagan@amarulasolutions.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] pine64_sopine_defconfig: Use mainline ATF
Date: Tue, 9 Aug 2022 13:47:03 +0200	[thread overview]
Message-ID: <20220809134703.05bfd118@windsurf> (raw)
In-Reply-To: <20220809113329.249779-1-alistair@alistair23.me>

Hello Francis,

On Tue,  9 Aug 2022 21:33:29 +1000
Alistair Francis <alistair@alistair23.me> wrote:

> Use the mainline ATF as it supports the Pine64 SoPine module.
> 
> Signed-off-by: Alistair Francis <alistair@alistair23.me>
> ---
>  configs/pine64_sopine_defconfig | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/configs/pine64_sopine_defconfig b/configs/pine64_sopine_defconfig
> index 6fa511477c..2295c9338d 100644
> --- a/configs/pine64_sopine_defconfig
> +++ b/configs/pine64_sopine_defconfig
> @@ -7,10 +7,7 @@ BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_0=y
>  
>  # Firmware
>  BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
> -BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_GIT=y
> -BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_URL="https://github.com/apritzel/arm-trusted-firmware.git"
> -BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="sun50iw1p1"
> -BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_VERSION="aa75c8da415158a94b82a430b2b40000778e851f"
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="sun50i_a64"
>  BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31=y

Thanks a lot! However, could you adjust the patch to use a fixed
version of ATF, like is done for Linux or U-Boot in all our defconfigs?

Also, do you confirm this change was tested on hardware? Does it solve
https://gitlab.com/buildroot.org/buildroot/-/jobs/2812053812 ? If yes,
then could you include something like this in your commit log:

Fixes:

  https://gitlab.com/buildroot.org/buildroot/-/jobs/2812053812

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2022-08-09 11:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-09 11:33 [Buildroot] [PATCH] pine64_sopine_defconfig: Use mainline ATF Alistair Francis
2022-08-09 11:47 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220809134703.05bfd118@windsurf \
    --to=buildroot@buildroot.org \
    --cc=alistair@alistair23.me \
    --cc=jagan@amarulasolutions.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.