Re: [Buildroot] [PATCH 1/1] package/xenomai: always set default version

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Romain Naour <romain.naour@gmail.com>,
	Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/xenomai: always set default version
Date: Tue, 9 Aug 2022 15:54:26 +0200	[thread overview]
Message-ID: <20220809155426.7d950e64@windsurf> (raw)
In-Reply-To: <CAPi7W831MWDk=uBqFzebZ9FmsZiVNxDfDfNMYfa5rqW6cgxOuA@mail.gmail.com>

Hello,

On Tue, 9 Aug 2022 14:12:53 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> >  - Not have any default value for BR2_PACKAGE_XENOMAI_VERSION
> >  
> 
> This will not be really consistent with other packages.
> arm-trusted-firmware, barebox, optee-os, opensbi and uboot all have default
> values for
> BR2_TARGET_{ARM_TRUSTED_FIRMWARE,BAREBOX,OPENSBI,OPTEE_OS,UBOOT}_VERSION

Well, not really for Git/Mercurial/SVN:

config BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION
        string "Custom repository version"
        help
          Revision to use in the typical format used by
          Git/Mercurial/Subversion E.G. a sha id, a tag, branch, ..

So no default version.

And:

config BR2_TARGET_UBOOT_VERSION
        string
        default "2022.04"       if BR2_TARGET_UBOOT_LATEST_VERSION
        default BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE \
                if BR2_TARGET_UBOOT_CUSTOM_VERSION
        default "custom"        if BR2_TARGET_UBOOT_CUSTOM_TARBALL
        default BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION \
                if BR2_TARGET_UBOOT_CUSTOM_GIT || BR2_TARGET_UBOOT_CUSTOM_HG || BR2_TARGET_UBOOT_CUSTOM_SVN

which only means that BR2_TARGET_BOOT_VERSION is automatically set to
BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION when Git/Mercurial/SVN is used.

I wouldn't call that having a default version :-)

I think we should use the same pattern everywhere.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot