From: Rob Herring <robh@kernel.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: "Clément Léger" <clement.leger@bootlin.com>,
UNGLinuxDriver@microchip.com, devicetree@vger.kernel.org,
"Eric Dumazet" <edumazet@google.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Russell King" <rmk+kernel@armlinux.org.uk>,
"Claudiu Manoil" <claudiu.manoil@nxp.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Luiz Angelo Daros de Luca" <luizluca@gmail.com>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Sean Wang" <sean.wang@mediatek.com>,
"Landen Chao" <Landen.Chao@mediatek.com>,
"Marcin Wojtas" <mw@semihalf.com>,
"Christian Marangi" <ansuelsmth@gmail.com>,
"DENG Qingfang" <dqfext@gmail.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Hauke Mehrtens" <hauke@hauke-m.de>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Andrew Lunn" <andrew@lunn.ch>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Pawel Dembicki" <paweldembicki@gmail.com>,
"Alvin Šipraga" <alsi@bang-olufsen.dk>,
"Kurt Kanzenbach" <kurt@linutronix.de>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
"John Crispin" <john@phrozen.org>,
"Oleksij Rempel" <linux@rempel-privat.de>,
"Arun Ramadoss" <arun.ramadoss@microchip.com>,
"Woojung Huh" <woojung.huh@microchip.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"Marek Vasut" <marex@denx.de>, "Paolo Abeni" <pabeni@redhat.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Marek Behún" <kabel@kernel.org>,
"Aleksander Jan Bajkowski" <olek2@wp.pl>,
linux-renesas-soc@vger.kernel.org,
"Mans Rullgard" <mans@mansr.com>,
"George McCollister" <george.mccollister@gmail.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>
Subject: Re: [RFC PATCH v3 net-next 03/10] dt-bindings: net: dsa: b53: add missing CPU port phy-mode to example
Date: Tue, 9 Aug 2022 14:11:42 -0600 [thread overview]
Message-ID: <20220809201142.GA2312298-robh@kernel.org> (raw)
In-Reply-To: <20220806141059.2498226-4-vladimir.oltean@nxp.com>
On Sat, 06 Aug 2022 17:10:52 +0300, Vladimir Oltean wrote:
> Looking at b53_srab_phylink_get_caps() I get no indication of what PHY
> modes does port 8 support, since it is implemented circularly based on
> the p->mode retrieved from the device tree (and in PHY_INTERFACE_MODE_NA
> it reports nothing to supported_interfaces).
>
> However if I look at the b53_switch_chips[] element for BCM58XX_DEVICE_ID,
> I see that port 8 is the IMP port, and SRAB means the IMP port is
> internal to the SoC. So use phy-mode = "internal" in the example.
>
> Note that this will make b53_srab_phylink_get_caps() go through the
> "default" case and report PHY_INTERFACE_MODE_INTERNAL to
> supported_interfaces, which is probably a good thing.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
> v2->v3: patch is new
>
> Documentation/devicetree/bindings/net/dsa/brcm,b53.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2022-08-09 20:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-06 14:10 [RFC PATCH v3 net-next 00/10] Validate OF nodes for DSA shared ports Vladimir Oltean
2022-08-06 14:10 ` [RFC PATCH v3 net-next 01/10] dt-bindings: net: dsa: xrs700x: add missing CPU port phy-mode to example Vladimir Oltean
2022-08-09 20:11 ` Rob Herring
2022-08-06 14:10 ` [RFC PATCH v3 net-next 02/10] dt-bindings: net: dsa: hellcreek: add missing CPU port phy-mode/fixed-link " Vladimir Oltean
2022-08-08 5:31 ` Kurt Kanzenbach
2022-08-09 20:11 ` Rob Herring
2022-08-06 14:10 ` [RFC PATCH v3 net-next 03/10] dt-bindings: net: dsa: b53: add missing CPU port phy-mode " Vladimir Oltean
2022-08-09 20:11 ` Rob Herring [this message]
2022-08-06 14:10 ` [RFC PATCH v3 net-next 04/10] dt-bindings: net: dsa: microchip: " Vladimir Oltean
2022-08-09 20:11 ` Rob Herring
2022-08-06 14:10 ` [RFC PATCH v3 net-next 05/10] dt-bindings: net: dsa: rzn1-a5psw: " Vladimir Oltean
2022-08-09 20:11 ` Rob Herring
2022-08-06 14:10 ` [RFC PATCH v3 net-next 06/10] dt-bindings: net: dsa: make phylink bindings required for CPU/DSA ports Vladimir Oltean
2022-08-09 20:12 ` Rob Herring
2022-08-06 14:10 ` [RFC PATCH v3 net-next 07/10] of: base: export of_device_compatible_match() for use in modules Vladimir Oltean
2022-08-09 20:12 ` Rob Herring
2022-08-06 14:10 ` [RFC PATCH v3 net-next 08/10] net: dsa: avoid dsa_port_link_{,un}register_of() calls with platform data Vladimir Oltean
2022-08-06 14:10 ` [RFC PATCH v3 net-next 09/10] net: dsa: rename dsa_port_link_{,un}register_of Vladimir Oltean
2022-08-06 14:10 ` [RFC PATCH v3 net-next 10/10] net: dsa: make phylink-related OF properties mandatory on DSA and CPU ports Vladimir Oltean
2022-08-06 19:58 ` Christian Marangi
2022-08-08 7:31 ` Vladimir Oltean
2022-08-09 8:24 ` Kurt Kanzenbach
2022-08-10 9:52 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220809201142.GA2312298-robh@kernel.org \
--to=robh@kernel.org \
--cc=Landen.Chao@mediatek.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alsi@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=arun.ramadoss@microchip.com \
--cc=claudiu.manoil@nxp.com \
--cc=clement.leger@bootlin.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=geert+renesas@glider.be \
--cc=george.mccollister@gmail.com \
--cc=hauke@hauke-m.de \
--cc=john@phrozen.org \
--cc=kabel@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=luizluca@gmail.com \
--cc=mans@mansr.com \
--cc=marex@denx.de \
--cc=martin.blumenstingl@googlemail.com \
--cc=matthias.bgg@gmail.com \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=olek2@wp.pl \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=paweldembicki@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.