From: Siddh Raman Pant <code@siddh.me>
To: syzbot+b6c9fe29aefe68e4ad34@syzkaller.appspotmail.com
Cc: davem@davemloft.net, johannes@sipsolutions.net, kuba@kernel.org,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: WARNING in ieee80211_ibss_csa_beacon
Date: Wed, 10 Aug 2022 17:05:51 +0530 [thread overview]
Message-ID: <20220810113551.344792-1-code@siddh.me> (raw)
In-Reply-To: <0000000000008c848805b123f174@google.com>
When we are not connected to a channel, sending channel "switch"
announcement doesn't make any sense.
#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
--- a/net/mac80211/ibss.c
+++ b/net/mac80211/ibss.c
@@ -530,6 +530,10 @@ int ieee80211_ibss_finish_csa(struct ieee80211_sub_if_data *sdata)
sdata_assert_lock(sdata);
+ /* When not connected/joined, sending CSA doesn't make sense. */
+ if (sdata->u.ibss.state != IEEE80211_IBSS_MLME_JOINED)
+ return -ENOLINK;
+
/* update cfg80211 bss information with the new channel */
if (!is_zero_ether_addr(ifibss->bssid)) {
cbss = cfg80211_get_bss(sdata->local->hw.wiphy,
--
2.35.1
next prev parent reply other threads:[~2022-08-10 11:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 7:40 WARNING in ieee80211_ibss_csa_beacon syzbot
2020-12-05 2:28 ` syzbot
2022-08-10 11:35 ` Siddh Raman Pant [this message]
2022-08-10 16:47 ` [syzbot] " syzbot
2022-08-11 6:41 ` Siddh Raman Pant
2022-08-11 13:01 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220810113551.344792-1-code@siddh.me \
--to=code@siddh.me \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzbot+b6c9fe29aefe68e4ad34@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.