All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: Christoph Hellwig <hch@lst.de>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"Ewan D . Milne" <emilne@redhat.com>,
	James Smart <jsmart2021@gmail.com>,
	Muneendra Kumar M <muneendra.kumar@broadcom.com>
Subject: Re: [PATCH] nvme-fc: fix the fc_appid_store return value
Date: Wed, 10 Aug 2022 16:23:51 +0200	[thread overview]
Message-ID: <20220810142351.GC25801@lst.de> (raw)
In-Reply-To: <d6867d59-9e1b-78c7-6832-3157bc0fda61@nvidia.com>

On Sun, Aug 07, 2022 at 09:23:27AM +0000, Chaitanya Kulkarni wrote:
> while we are at it perhaps we should consider fixing following ?

Yes, please send a separate patch.  Please also remove the various
pointless braces in the hunk that you are touching.


  reply	other threads:[~2022-08-10 14:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-06  8:32 [PATCH] nvme-fc: fix the fc_appid_store return value Christoph Hellwig
2022-08-07  9:21 ` Chaitanya Kulkarni
2022-08-07  9:23 ` Chaitanya Kulkarni
2022-08-10 14:23   ` Christoph Hellwig [this message]
2022-08-28 12:11 ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220810142351.GC25801@lst.de \
    --to=hch@lst.de \
    --cc=chaitanyak@nvidia.com \
    --cc=emilne@redhat.com \
    --cc=jsmart2021@gmail.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=muneendra.kumar@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.