From: Jakub Kicinski <kuba@kernel.org>
To: Emeel Hakim <ehakim@nvidia.com>
Cc: <edumazet@google.com>, <mayflowerera@gmail.com>,
<pabeni@redhat.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Raed Salem <raeds@nvidia.com>
Subject: Re: [PATCH net 1/1] net: macsec: Fix XPN properties passing to macsec offload
Date: Thu, 11 Aug 2022 09:25:43 -0700 [thread overview]
Message-ID: <20220811092543.696a5ef2@kernel.org> (raw)
In-Reply-To: <20220809102905.31826-1-ehakim@nvidia.com>
On Tue, 9 Aug 2022 13:29:05 +0300 Emeel Hakim wrote:
> Currently macsec invokes HW offload path before reading extended
> packet number (XPN) related user properties i.e. salt and short
> secure channel identifier (ssci), hence preventing macsec XPN HW
> offload.
>
> Fix by moving macsec XPN properties reading prior to HW offload path.
>
> Fixes: 48ef50fa866a ("macsec: Netlink support of XPN cipher suites")
> Reviewed-by: Raed Salem <raeds@nvidia.com>
> Signed-off-by: Emeel Hakim <ehakim@nvidia.com>
Is there a driver in the tree which uses those values today?
I can't grep out any rx_sa->key accesses in the drivers at all :S
If there is none it's not really a fix.
next prev parent reply other threads:[~2022-08-11 16:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 10:29 [PATCH net 1/1] net: macsec: Fix XPN properties passing to macsec offload Emeel Hakim
2022-08-11 16:25 ` Jakub Kicinski [this message]
2022-08-14 7:32 ` Emeel Hakim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220811092543.696a5ef2@kernel.org \
--to=kuba@kernel.org \
--cc=edumazet@google.com \
--cc=ehakim@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mayflowerera@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=raeds@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.