From: Christoph Hellwig <hch@lst.de>
To: Mike Christie <michael.christie@oracle.com>
Cc: Martin Wilck <mwilck@suse.com>,
bvanassche@acm.org, hch@lst.de, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org,
james.bottomley@hansenpartnership.com,
Hannes Reinecke <Hannes.Reinecke@suse.com>
Subject: Re: [PATCH 3/4] scsi: Internally retry scsi_execute commands
Date: Thu, 11 Aug 2022 14:27:38 +0200 [thread overview]
Message-ID: <20220811122738.GC1742@lst.de> (raw)
In-Reply-To: <2b1943b2-466f-5674-1c8c-7db7b2dc4738@oracle.com>
On Wed, Aug 10, 2022 at 12:06:41PM -0500, Mike Christie wrote:
> 2. Instead of trying to make it general for all scsi_execute_users, we can
> add SCMD bits for specific cases like DID_TIME_OUT or a SCMD bit that tells
> scsi_noretry_cmd to not always fail passthrough commands just because they
> are passthrough. It would work the opposite of the FASTFAIL bits where instead
> of failing fast, we retry.
Yes, I think this is closer to what I'd like to see. Although I wonder
if we should turn it around and require the FAILFAST bits to opt out of
automatic retries even for passthrough, even if that turns into a major
audit.
next prev parent reply other threads:[~2022-08-11 12:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 3:41 [PATCH 0/4] scsi: passthrough fixes/improvements Mike Christie
2022-08-10 3:41 ` [PATCH 1/4] scsi: Fix passthrough retry counter handling Mike Christie
2022-08-11 12:16 ` Christoph Hellwig
2022-08-10 3:41 ` [PATCH 2/4] scsi: Add new SUBMITTED types for passthrough Mike Christie
2022-08-11 12:21 ` Christoph Hellwig
2022-08-10 3:41 ` [PATCH 3/4] scsi: Internally retry scsi_execute commands Mike Christie
2022-08-10 10:46 ` Martin Wilck
2022-08-10 17:06 ` Mike Christie
2022-08-10 17:38 ` Mike Christie
2022-08-11 12:28 ` Christoph Hellwig
2022-08-11 16:19 ` Mike Christie
2022-08-11 9:56 ` Martin Wilck
2022-08-11 16:15 ` Mike Christie
2022-08-11 17:02 ` Martin Wilck
2022-08-11 18:22 ` Mike Christie
2022-08-11 12:27 ` Christoph Hellwig [this message]
2022-08-10 3:41 ` [PATCH 4/4] scsi: Handle UAs for pr_ops Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220811122738.GC1742@lst.de \
--to=hch@lst.de \
--cc=Hannes.Reinecke@suse.com \
--cc=bvanassche@acm.org \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=mwilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.