From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FD2DC19F2A for ; Thu, 11 Aug 2022 16:10:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235399AbiHKQKx (ORCPT ); Thu, 11 Aug 2022 12:10:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236176AbiHKQKE (ORCPT ); Thu, 11 Aug 2022 12:10:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 051DDF2D; Thu, 11 Aug 2022 08:55:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 95EBC612BF; Thu, 11 Aug 2022 15:55:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E96AC433D6; Thu, 11 Aug 2022 15:55:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660233311; bh=9DyU2OUNIXlnp/IMSrdvrogl4JUXt2JFXlz4ErufCU0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lNeeMXzVTR8C8jmR28Whl/kJh0eRAJk7UCd0NNEQExmpV9Uy304KKN1ya64YQuaIh qt+G9UkoT4uH1412EwIJ9E20GH9TS7sHiRyllfZ1kcAkI58gT0R7fFSJE1A4YYBbGQ VlQzbrFzDjuIFYbEWLdUblzMrE3wmYAMuZmXZt4CmyBRgdg39jxq/B+YmDDO20O5VX uzd1H/tPS8Wor4EI3zkTBwnCoikRoppa/z1p6QjIPcFf2Q4Si6b2egDaSTo/hB4SP0 XfWPcv4bk50P//ahB69JykV8ah4PjVsnptarrj+bzwz/pFfHb7m6USG9FQyXJ4rr9H gTV0XvKsM9oVg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Christian Marangi , Jakub Kicinski , Sasha Levin , peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, mcoquelin.stm32@gmail.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.18 85/93] net: ethernet: stmicro: stmmac: first disable all queues and disconnect in release Date: Thu, 11 Aug 2022 11:42:19 -0400 Message-Id: <20220811154237.1531313-85-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220811154237.1531313-1-sashal@kernel.org> References: <20220811154237.1531313-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Christian Marangi [ Upstream commit 7028471edb646bfc532fec0973e50e784cdcb7c6 ] Disable all queues and disconnect before tx_disable in stmmac_release to prevent a corner case where packet may be still queued at the same time tx_disable is called resulting in kernel panic if some packet still has to be processed. Signed-off-by: Christian Marangi Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 98c4abbcd469..fd3671f1bad0 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -3766,8 +3766,6 @@ static int stmmac_release(struct net_device *dev) struct stmmac_priv *priv = netdev_priv(dev); u32 chan; - netif_tx_disable(dev); - if (device_may_wakeup(priv->device)) phylink_speed_down(priv->phylink, false); /* Stop and disconnect the PHY */ @@ -3779,6 +3777,8 @@ static int stmmac_release(struct net_device *dev) for (chan = 0; chan < priv->plat->tx_queues_to_use; chan++) hrtimer_cancel(&priv->tx_queue[chan].txtimer); + netif_tx_disable(dev); + /* Free the IRQ lines */ stmmac_free_irq(dev, REQ_IRQ_ERR_ALL, 0); -- 2.35.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 875EFC19F2A for ; Thu, 11 Aug 2022 15:56:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8qQZsdI7KzS743+U7g+imYZtMMYyioo7kDlmqWu/tQA=; b=FnwXV5RjhYHHbq 8Oj8DHdSsvfXpYCvHjkWP7aPHBlednI+/6N4fqJ55nWB8Bl8jMMGKcIfiIzObPXiA3s++8T1G+KUL 1JmbSmfa73RQDWbIVinflJVzHc0+2QrcFH5LZhTT7zeWH77Pg679w0QMFngVPgJSSJqn4BsG7oKkv W6us+Yj11dlfjuiL4DCUBuJvhoIwDyvg4QY57QpkHBzVSeuVBdeeVcDGjNvvfwJASrVrUHG2A8eC1 0Kn/2VuXHlMnZjmv62491JnsnMHeeEnJ1NCYLNKr4HvNr6fshnyZ33XPZlfGZgHZPsC4pW04+wBQE OuqO3QN9bUBRd07aiqXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMAWi-00EV7L-B3; Thu, 11 Aug 2022 15:55:16 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMAWe-00EV3X-3i for linux-arm-kernel@lists.infradead.org; Thu, 11 Aug 2022 15:55:13 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 96204612DB; Thu, 11 Aug 2022 15:55:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E96AC433D6; Thu, 11 Aug 2022 15:55:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660233311; bh=9DyU2OUNIXlnp/IMSrdvrogl4JUXt2JFXlz4ErufCU0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lNeeMXzVTR8C8jmR28Whl/kJh0eRAJk7UCd0NNEQExmpV9Uy304KKN1ya64YQuaIh qt+G9UkoT4uH1412EwIJ9E20GH9TS7sHiRyllfZ1kcAkI58gT0R7fFSJE1A4YYBbGQ VlQzbrFzDjuIFYbEWLdUblzMrE3wmYAMuZmXZt4CmyBRgdg39jxq/B+YmDDO20O5VX uzd1H/tPS8Wor4EI3zkTBwnCoikRoppa/z1p6QjIPcFf2Q4Si6b2egDaSTo/hB4SP0 XfWPcv4bk50P//ahB69JykV8ah4PjVsnptarrj+bzwz/pFfHb7m6USG9FQyXJ4rr9H gTV0XvKsM9oVg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Christian Marangi , Jakub Kicinski , Sasha Levin , peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, mcoquelin.stm32@gmail.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.18 85/93] net: ethernet: stmicro: stmmac: first disable all queues and disconnect in release Date: Thu, 11 Aug 2022 11:42:19 -0400 Message-Id: <20220811154237.1531313-85-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220811154237.1531313-1-sashal@kernel.org> References: <20220811154237.1531313-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220811_085512_304962_83EFC4BB X-CRM114-Status: GOOD ( 13.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Christian Marangi [ Upstream commit 7028471edb646bfc532fec0973e50e784cdcb7c6 ] Disable all queues and disconnect before tx_disable in stmmac_release to prevent a corner case where packet may be still queued at the same time tx_disable is called resulting in kernel panic if some packet still has to be processed. Signed-off-by: Christian Marangi Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 98c4abbcd469..fd3671f1bad0 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -3766,8 +3766,6 @@ static int stmmac_release(struct net_device *dev) struct stmmac_priv *priv = netdev_priv(dev); u32 chan; - netif_tx_disable(dev); - if (device_may_wakeup(priv->device)) phylink_speed_down(priv->phylink, false); /* Stop and disconnect the PHY */ @@ -3779,6 +3777,8 @@ static int stmmac_release(struct net_device *dev) for (chan = 0; chan < priv->plat->tx_queues_to_use; chan++) hrtimer_cancel(&priv->tx_queue[chan].txtimer); + netif_tx_disable(dev); + /* Free the IRQ lines */ stmmac_free_irq(dev, REQ_IRQ_ERR_ALL, 0); -- 2.35.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel