From: Christoph Hellwig <hch@lst.de>
To: Mike Christie <michael.christie@oracle.com>
Cc: hch@lst.de, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org,
james.bottomley@hansenpartnership.com
Subject: Re: [PATCH v2 1/1] scsi: Fix passthrough retry counter handling
Date: Fri, 12 Aug 2022 07:33:49 +0200 [thread overview]
Message-ID: <20220812053349.GA24671@lst.de> (raw)
In-Reply-To: <20220812011206.9157-1-michael.christie@oracle.com>
On Thu, Aug 11, 2022 at 08:12:06PM -0500, Mike Christie wrote:
> Passthrough users will set the scsi_cmnd->allowed value and were
> expecting up to $allowed retries. The problem is that before:
>
> commit 6aded12b10e0 ("scsi: core: Remove struct scsi_request")
>
> we used to set the retries on the scsi_request then copy them over to
> scsi_cmnd->allowed in scsi_setup_scsi_cmnd. With that patch we now set
> scsi_cmnd->allowed to 0 in scsi_prepare_cmd and overwrite what the
> passthrough user set.
>
> This moves the allowed initialization to after the blk_rq_is_passthrough
> check so it's only done for the non-passthrough path where the ULD
> init_command will normally set an allowed value it prefers.
>
> Fixes: 6aded12b10e0 ("scsi: core: Remove struct scsi_request")
> Signed-off-by: Mike Christie <michael.christie@oracle.com>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2022-08-12 5:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 1:12 [PATCH v2 1/1] scsi: Fix passthrough retry counter handling Mike Christie
2022-08-12 5:33 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220812053349.GA24671@lst.de \
--to=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.