All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Czerner <lczerner@redhat.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org, Daniel Ng <danielng@google.com>
Subject: Re: [PATCH] e2fsprogs: fix device name parsing to resolve names containing '='
Date: Fri, 12 Aug 2022 09:12:38 +0200	[thread overview]
Message-ID: <20220812071238.d766gj3do7clwhdn@fedora> (raw)
In-Reply-To: <YvR0/wmZgf1HwidK@mit.edu>

On Wed, Aug 10, 2022 at 11:18:23PM -0400, Theodore Ts'o wrote:
> Hi Lukas,
> 
> Could you move get_devname() into its own file in lib/support?  e.g.,
> create a devname.c and devname.h.
> 
> The reason for this is that plausible.c tries to call libmagic via
> dlopen() so we don't need to drag libmagic into the minimal package
> set for distros.  But that means that any executiables that try to use
> devname() will drag in lib/support/pausible.c, which means if you
> don't change the makefiles to link in -ldl, static linking will fail:
> 
> 					- Ted

Ah, I didn't notice that. I'll move it into a separate file,
devname.[ch] sounds good.

Thanks!
-Lukas


  reply	other threads:[~2022-08-12  7:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-05  9:47 [PATCH] e2fsprogs: fix device name parsing to resolve names containing '=' Lukas Czerner
2022-08-08  3:13 ` Daniel Ng
2022-08-11  3:18 ` Theodore Ts'o
2022-08-12  7:12   ` Lukas Czerner [this message]
2022-08-12 13:01 ` [PATCH v2] " Lukas Czerner
2022-08-13 14:58   ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220812071238.d766gj3do7clwhdn@fedora \
    --to=lczerner@redhat.com \
    --cc=danielng@google.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.