From: Jakub Kicinski <kuba@kernel.org>
To: "Csókás Bence" <csokas.bence@prolan.hu>
Cc: <netdev@vger.kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
<qiangqing.zhang@nxp.com>
Subject: Re: [PATCH] net: fec: Restart PPS after link state change
Date: Fri, 12 Aug 2022 16:59:54 -0700 [thread overview]
Message-ID: <20220812165954.50427baa@kernel.org> (raw)
In-Reply-To: <20220812115408.12985-1-csokas.bence@prolan.hu>
On Fri, 12 Aug 2022 13:54:09 +0200 Csókás Bence wrote:
> On link state change, the controller gets reset,
> causing PPS to drop out and the PHC to lose its
> time and calibration. So we restart it if needed,
> restoring calibration and time registers.
>
> Changes since v2:
> * Add `fec_ptp_save_state()`/`fec_ptp_restore_state()`
> * Use `ktime_get_real_ns()`
> * Use `BIT()` macro
> Changes since v1:
> * More ECR #define's
> * Stop PPS in `fec_ptp_stop()`
nit: [PATCH net v3] net: fec: ...
would have been the perfect prefix here.
The patch doesn't seem to apply, it needs to go to this tree:
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/
When you repost, please also CC Andrew since he was giving feedback
on the initial version.
prev parent reply other threads:[~2022-08-12 23:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 11:54 [PATCH] net: fec: Restart PPS after link state change Csókás Bence
2022-08-12 23:59 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220812165954.50427baa@kernel.org \
--to=kuba@kernel.org \
--cc=csokas.bence@prolan.hu \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=qiangqing.zhang@nxp.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.