From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0C05C00140 for ; Fri, 12 Aug 2022 17:10:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=aP1dZQMNULaCRWTSA5tuahXVL5OcFQ4YAjVzo8nE9Cc=; b=t5JPPeLSRJmV/N m9yR+bcGpSoeXfGjEnl1TIvXRM3WLCe1ANMMxpczqAw0OuZQaMDQ/io4gXME2UNvGlSVKyKHNg4zP /2S1bjq1WTJREmNFUfhBSgwamZJ9Ztl3BOFQ/ImALm7hVxxZxvHkuMYyF6xJjmlGJeGlKtFPF+V2P NGCC6xhfnNdHtcsidOz0TNe/ZZy4OQzvEsZgyF2pt+aIQ/9rLL6avMy5ZPJFvwFFt5mgRdZllsRrQ ManJBdKwn5IGwJbkekJK+UR6TCtyHPZJRv+TeynWg6xw2Q0fTb/YsKhgCz5Gq2IR9BuKiJFxDrMQ8 WeFdMXo4ftkxdPwH4oSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMY97-00BHYn-MW; Fri, 12 Aug 2022 17:08:29 +0000 Received: from phobos.denx.de ([85.214.62.61]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMY91-00BHSp-N6 for linux-arm-kernel@lists.infradead.org; Fri, 12 Aug 2022 17:08:27 +0000 Received: from tr.lan (ip-86-49-12-201.bb.vodafone.cz [86.49.12.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id EF2E28485F; Fri, 12 Aug 2022 19:08:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1660324100; bh=n+FKvpD4xZzE7RSLO4s5QXrcmypidaJXEZLQS+erW94=; h=From:To:Cc:Subject:Date:From; b=wFsSTCfr8B+8y7SPkRQ3ysV6x66LCo8tcVfbh6la69SVBu8mf/YduFiipnX0abqy6 0MDrRKQGssj2aldAMrePpsSOwxaasneEJvxOX5Guelsvt/opCG1nfV5K4z0VIJIZ8w K99/LmlLBG30De9O9mT155TRxKNRl5/QQiDhlLIK6NMO6a1V3s5FOLfrJpKtWo9wCo 9UepbgmluEWOx3j/rOzX6FVGlVudcVVykkWOuIcGH1CZinwEVm7RdkHxI2RmM1xZfJ fnxprLbi4+1n0L2FjzVvWjHV3fNjtSerc1kNWIhMSFxN7PbkK57EUE0QH9/vVB8jRS wZNyr3vJUkytA== From: Marek Vasut To: linux-arm-kernel@lists.infradead.org Cc: Marek Vasut , Fabio Estevam , Frieder Schrempf , Lucas Stach , NXP Linux Team , Peng Fan , Shawn Guo Subject: [PATCH v3] soc: imx: gpcv2: Assert reset before ungating clock Date: Fri, 12 Aug 2022 19:08:02 +0200 Message-Id: <20220812170802.205244-1-marex@denx.de> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220812_100824_015407_40863DAE X-CRM114-Status: GOOD ( 13.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In case the power domain clock are ungated before the reset is asserted, the system might freeze completely. This is likely due to a device is an undefined state being attached to bus, which sporadically leads to a bus hang. Assert the reset before the clock are enabled to assure the device is in defined state before being attached to bus. Fixes: fe58c887fb8ca ("soc: imx: gpcv2: add support for optional resets") Signed-off-by: Marek Vasut --- Cc: Fabio Estevam Cc: Frieder Schrempf Cc: Lucas Stach Cc: NXP Linux Team Cc: Peng Fan Cc: Shawn Guo To: linux-arm-kernel@lists.infradead.org --- V2: - Always assert the reset before enabling clock - Update commit message - Add Fixes tag V3: Move the extra delay past clk_prepare_enable() --- drivers/soc/imx/gpcv2.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index 6383a4edc3607..88aee59730e39 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -335,6 +335,8 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) } } + reset_control_assert(domain->reset); + /* Enable reset clocks for all devices in the domain */ ret = clk_bulk_prepare_enable(domain->num_clks, domain->clks); if (ret) { @@ -342,7 +344,8 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) goto out_regulator_disable; } - reset_control_assert(domain->reset); + /* delays for reset to propagate */ + udelay(5); if (domain->bits.pxx) { /* request the domain to power up */ -- 2.35.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel