All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joelle van Dyne <j@getutm.app>
To: qemu-devel@nongnu.org
Cc: Joelle van Dyne <j@getutm.app>, Gerd Hoffmann <kraxel@redhat.com>
Subject: [PATCH 3/3] usbredir: avoid queuing hello packet on snapshot restore
Date: Fri, 12 Aug 2022 18:10:31 -0700	[thread overview]
Message-ID: <20220813011031.3744-4-j@getutm.app> (raw)
In-Reply-To: <20220813011031.3744-1-j@getutm.app>

When launching QEMU with "-loadvm", usbredir_create_parser() should avoid
setting up the hello packet (just as with "-incoming". On the latest version
of libusbredir, usbredirparser_unserialize() will return error if the parser
is not "pristine."

Signed-off-by: Joelle van Dyne <j@getutm.app>
---
 hw/usb/redirect.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c
index fd7df599bc..47fac3895a 100644
--- a/hw/usb/redirect.c
+++ b/hw/usb/redirect.c
@@ -1280,7 +1280,8 @@ static void usbredir_create_parser(USBRedirDevice *dev)
     }
 #endif
 
-    if (runstate_check(RUN_STATE_INMIGRATE)) {
+    if (runstate_check(RUN_STATE_INMIGRATE) ||
+        runstate_check(RUN_STATE_RESTORE_VM)) {
         flags |= usbredirparser_fl_no_hello;
     }
     usbredirparser_init(dev->parser, VERSION, caps, USB_REDIR_CAPS_SIZE,
-- 
2.28.0



  parent reply	other threads:[~2022-08-13  1:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-13  1:10 [PATCH 0/3] Set runstate to RUN_STATE_RESTORE_VM when started with "-loadvm" Joelle van Dyne
2022-08-13  1:10 ` [PATCH 1/3] Revert "usbredir: avoid queuing hello packet on snapshot restore" Joelle van Dyne
2022-11-21 12:26   ` Ján Tomko
2022-08-13  1:10 ` [PATCH 2/3] vl: on -loadvm set run state to "restore-vm" Joelle van Dyne
2022-08-22 10:11   ` Daniel P. Berrangé
2022-10-29 23:35     ` Joelle van Dyne
2022-08-13  1:10 ` Joelle van Dyne [this message]
2022-08-13  5:30   ` [PATCH 3/3] usbredir: avoid queuing hello packet on snapshot restore Victor Toso
2022-08-13  5:33     ` Joelle van Dyne
2022-08-13  5:50       ` Victor Toso
2022-08-13  5:57         ` Joelle van Dyne
2022-08-13  7:12           ` Victor Toso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220813011031.3744-4-j@getutm.app \
    --to=j@getutm.app \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.