All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org,
	Zygo Blaxell <ce3g8jdj@umail.furryterror.org>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2] btrfs: don't merge pages into bio if their page offset is not continuous
Date: Sat, 13 Aug 2022 10:09:13 +0200	[thread overview]
Message-ID: <20220813080913.GA12088@lst.de> (raw)
In-Reply-To: <1d9b69af6ce0a79e54fbaafcc65ead8f71b54b60.1660377678.git.wqu@suse.com>

On Sat, Aug 13, 2022 at 04:06:53PM +0800, Qu Wenruo wrote:
> -	bool contig;
> +	bool contig = false;

Nit: the initialization isn't strictly needed in this new version.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

  reply	other threads:[~2022-08-13  8:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-13  8:06 [PATCH v2] btrfs: don't merge pages into bio if their page offset is not continuous Qu Wenruo
2022-08-13  8:09 ` Christoph Hellwig [this message]
2022-08-18 12:50 ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220813080913.GA12088@lst.de \
    --to=hch@lst.de \
    --cc=ce3g8jdj@umail.furryterror.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.