From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F6F6C19F2D for ; Sat, 13 Aug 2022 11:51:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id E1782405D1; Sat, 13 Aug 2022 11:51:51 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org E1782405D1 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4jrVM3K6wQEJ; Sat, 13 Aug 2022 11:51:50 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id DD070402E5; Sat, 13 Aug 2022 11:51:48 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org DD070402E5 Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 8DF391BF3A8 for ; Sat, 13 Aug 2022 11:51:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 687F260D72 for ; Sat, 13 Aug 2022 11:51:46 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 687F260D72 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WYCKXym0A8FJ for ; Sat, 13 Aug 2022 11:51:45 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org BF9DA60D6F Received: from smtp5-g21.free.fr (smtp5-g21.free.fr [IPv6:2a01:e0c:1:1599::14]) by smtp3.osuosl.org (Postfix) with ESMTPS id BF9DA60D6F for ; Sat, 13 Aug 2022 11:51:44 +0000 (UTC) Received: from ymorin.is-a-geek.org (unknown [IPv6:2a01:cb19:8b51:cb00:ac43:2f79:1c81:6f7d]) (Authenticated sender: yann.morin.1998@free.fr) by smtp5-g21.free.fr (Postfix) with ESMTPSA id A4BC960132; Sat, 13 Aug 2022 13:51:37 +0200 (CEST) Received: by ymorin.is-a-geek.org (sSMTP sendmail emulation); Sat, 13 Aug 2022 13:51:37 +0200 Date: Sat, 13 Aug 2022 13:51:37 +0200 From: "Yann E. MORIN" To: Stefan Agner Message-ID: <20220813115137.GA2741326@scaer> References: <2ba3394abf87c940fe036b2e18e1afc2a2d37ad0.1660320356.git.stefan@agner.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2ba3394abf87c940fe036b2e18e1afc2a2d37ad0.1660320356.git.stefan@agner.ch> User-Agent: Mutt/1.5.22 (2013-10-16) X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1660391500; bh=EpbOvOS9X+ywEO09JGG4IyAzayqaAXPBB8cnJP00eT4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DkrrTpcvvz7wp769/SUDOLZerrLtYVJcLTqUE0dUOElnRYAjtcpYXe3k7a2Wcm+H7 CufWwSiCGaq2b7mcE+r3zCftxJj/lbtK867w/8jdYZTkxiMRGVL0rtxLxXLytvRZLO zJCiTgQgOeu4L5q/7RpmnBchFn55EXsEeq5kyr6V+RQSrWeKV2dLsIwgOYo/mW6xB/ I5YHOeTBtWtjfcENHaOQ7PhNIpZe7BMc8QjzxpWbDwsjiU7sxSl/l812W3VyublxDS a4RJBJvSJHTlATpBGNeDPFofyBNyMzdwOb+lqk6qWJOrJizZGau7c2NExHdGbdPJze FooVpj8N8nb4g== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=free.fr header.i=@free.fr header.a=rsa-sha256 header.s=smtp-20201208 header.b=DkrrTpcv Subject: Re: [Buildroot] [PATCH] package/docker-engine: use kernel modules for extra network drivers X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" Stefan, All, On 2022-08-12 18:07 +0200, Stefan Agner spake thusly: > Docker network driver "overlay", "macvlan" and "ipvlan" are not used > by default. Make them a module. > > The main aim here is to get rid of the dummy0 network interface which > is generated by the dummy driver by default. For consistency, make > all kernel drivers required for Docker network drivers a module. Also > add the currently missing CONFIG_BRIDGE_VLAN_FILTERING (mandatory > for the Docker network driver "overlay"). > > Signed-off-by: Stefan Agner > --- > package/docker-engine/docker-engine.mk | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/package/docker-engine/docker-engine.mk b/package/docker-engine/docker-engine.mk > index 293af1858c..730f2e3b86 100644 > --- a/package/docker-engine/docker-engine.mk > +++ b/package/docker-engine/docker-engine.mk > @@ -124,10 +124,11 @@ define DOCKER_ENGINE_LINUX_CONFIG_FIXUPS > $(call KCONFIG_ENABLE_OPT,CONFIG_IP_NF_TARGET_MASQUERADE) > $(call KCONFIG_ENABLE_OPT,CONFIG_BRIDGE) > $(call KCONFIG_ENABLE_OPT,CONFIG_NET_CORE) > - $(call KCONFIG_ENABLE_OPT,CONFIG_DUMMY) > - $(call KCONFIG_ENABLE_OPT,CONFIG_MACVLAN) > - $(call KCONFIG_ENABLE_OPT,CONFIG_IPVLAN) > - $(call KCONFIG_ENABLE_OPT,CONFIG_VXLAN) > + $(call KCONFIG_SET_OPT,CONFIG_DUMMY,m) > + $(call KCONFIG_SET_OPT,CONFIG_MACVLAN,m) > + $(call KCONFIG_SET_OPT,CONFIG_IPVLAN,m) > + $(call KCONFIG_SET_OPT,CONFIG_VXLAN,m) > + $(call KCONFIG_SET_OPT,CONFIG_BRIDGE_VLAN_FILTERING,m) That entirely overrides the options from the configuration file provided by the user, if they have and require any of those options set as =y. I think that what we need, is to have a helper KCONFIG_ENABLE_OPT_MOD, which only sets an option to 'm' if it is not already 'y' (i.e. the opposite of KCONFIG_ENABLE_OPT). Regards, Yann E. MORIN. > $(call KCONFIG_ENABLE_OPT,CONFIG_VETH) > $(call KCONFIG_ENABLE_OPT,CONFIG_OVERLAY_FS) > $(call KCONFIG_ENABLE_OPT,CONFIG_KEYS) > -- > 2.37.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot