diff for duplicates of <202208141119.RKGSGoZ7-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index 49208ef..ac6f18b 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,15 +1,6 @@ -BCC: lkp(a)intel.com -CC: kbuild-all(a)lists.01.org -CC: linux-kernel(a)vger.kernel.org -TO: Matthias Kaehlcke <mka@chromium.org> -CC: Kees Cook <keescook@chromium.org> - tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: aea23e7c464bfdec04b52cf61edb62030e9e0d0a commit: 3f805f8cc23ba35679dd01446929292911c2b469 LoadPin: Enable loading from trusted dm-verity devices -date: 5 weeks ago -:::::: branch date: 3 hours ago -:::::: commit date: 5 weeks ago config: s390-randconfig-m031-20220810 (https://download.01.org/0day-ci/archive/20220814/202208141119.RKGSGoZ7-lkp(a)intel.com/config) compiler: s390-linux-gcc (GCC) 12.1.0 @@ -22,7 +13,6 @@ security/loadpin/loadpin.c:365 dm_verity_ioctl() warn: maybe return -EFAULT inst vim +365 security/loadpin/loadpin.c -3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 354 3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 355 static long dm_verity_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) 3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 356 { 3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 357 void __user *uarg = (void __user *)arg; @@ -34,6 +24,13 @@ vim +365 security/loadpin/loadpin.c 3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 363 rc = copy_from_user(&fd, uarg, sizeof(fd)); 3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 364 if (rc) 3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 @365 return rc; + +The copy_from_user() function returns the number of bytes remaining to +be copied. It should be: + + if (copy_from_user(&fd, uarg, sizeof(fd))) + return -EFAULT; + 3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 366 3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 367 return read_trusted_verity_root_digests(fd); 3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 368 @@ -41,7 +38,6 @@ vim +365 security/loadpin/loadpin.c 3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 370 return -EINVAL; 3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 371 } 3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 372 } -3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 373 -- 0-DAY CI Kernel Test Service diff --git a/a/content_digest b/N1/content_digest index beb0e5e..6d667ef 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,21 +1,12 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0security/loadpin/loadpin.c:365 dm_verity_ioctl() warn: maybe return -EFAULT instead of the bytes remaining?\0" - "Date\0Sun, 14 Aug 2022 11:47:15 +0800\0" - "To\0kbuild@lists.01.org\0" + "Date\0Mon, 15 Aug 2022 11:07:12 +0300\0" + "To\0kbuild-all@lists.01.org\0" "\01:1\0" "b\0" - "BCC: lkp(a)intel.com\n" - "CC: kbuild-all(a)lists.01.org\n" - "CC: linux-kernel(a)vger.kernel.org\n" - "TO: Matthias Kaehlcke <mka@chromium.org>\n" - "CC: Kees Cook <keescook@chromium.org>\n" - "\n" "tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master\n" "head: aea23e7c464bfdec04b52cf61edb62030e9e0d0a\n" "commit: 3f805f8cc23ba35679dd01446929292911c2b469 LoadPin: Enable loading from trusted dm-verity devices\n" - "date: 5 weeks ago\n" - ":::::: branch date: 3 hours ago\n" - ":::::: commit date: 5 weeks ago\n" "config: s390-randconfig-m031-20220810 (https://download.01.org/0day-ci/archive/20220814/202208141119.RKGSGoZ7-lkp(a)intel.com/config)\n" "compiler: s390-linux-gcc (GCC) 12.1.0\n" "\n" @@ -28,7 +19,6 @@ "\n" "vim +365 security/loadpin/loadpin.c\n" "\n" - "3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 354 \n" "3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 355 static long dm_verity_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)\n" "3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 356 {\n" "3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 357 \tvoid __user *uarg = (void __user *)arg;\n" @@ -40,6 +30,13 @@ "3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 363 \t\trc = copy_from_user(&fd, uarg, sizeof(fd));\n" "3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 364 \t\tif (rc)\n" "3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 @365 \t\t\treturn rc;\n" + "\n" + "The copy_from_user() function returns the number of bytes remaining to\n" + "be copied. It should be:\n" + "\n" + "\tif (copy_from_user(&fd, uarg, sizeof(fd)))\n" + "\t\treturn -EFAULT;\n" + "\n" "3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 366 \n" "3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 367 \t\treturn read_trusted_verity_root_digests(fd);\n" "3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 368 \n" @@ -47,10 +44,9 @@ "3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 370 \t\treturn -EINVAL;\n" "3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 371 \t}\n" "3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 372 }\n" - "3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 373 \n" "\n" "-- \n" "0-DAY CI Kernel Test Service\n" https://01.org/lkp -a0a311407d192764ae337b7cd154ee84c56a8e4b6a107c6a769610c26c04fb88 +9b2250f5b053408c226aa6df90b22f66f55c15353ab99acc0479bed9e0e2a247
diff --git a/a/1.txt b/N2/1.txt index 49208ef..45ea3f1 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,16 +1,7 @@ -BCC: lkp(a)intel.com -CC: kbuild-all(a)lists.01.org -CC: linux-kernel(a)vger.kernel.org -TO: Matthias Kaehlcke <mka@chromium.org> -CC: Kees Cook <keescook@chromium.org> - tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: aea23e7c464bfdec04b52cf61edb62030e9e0d0a commit: 3f805f8cc23ba35679dd01446929292911c2b469 LoadPin: Enable loading from trusted dm-verity devices -date: 5 weeks ago -:::::: branch date: 3 hours ago -:::::: commit date: 5 weeks ago -config: s390-randconfig-m031-20220810 (https://download.01.org/0day-ci/archive/20220814/202208141119.RKGSGoZ7-lkp(a)intel.com/config) +config: s390-randconfig-m031-20220810 (https://download.01.org/0day-ci/archive/20220814/202208141119.RKGSGoZ7-lkp@intel.com/config) compiler: s390-linux-gcc (GCC) 12.1.0 If you fix the issue, kindly add following tag where applicable @@ -22,7 +13,6 @@ security/loadpin/loadpin.c:365 dm_verity_ioctl() warn: maybe return -EFAULT inst vim +365 security/loadpin/loadpin.c -3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 354 3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 355 static long dm_verity_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) 3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 356 { 3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 357 void __user *uarg = (void __user *)arg; @@ -34,6 +24,13 @@ vim +365 security/loadpin/loadpin.c 3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 363 rc = copy_from_user(&fd, uarg, sizeof(fd)); 3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 364 if (rc) 3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 @365 return rc; + +The copy_from_user() function returns the number of bytes remaining to +be copied. It should be: + + if (copy_from_user(&fd, uarg, sizeof(fd))) + return -EFAULT; + 3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 366 3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 367 return read_trusted_verity_root_digests(fd); 3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 368 @@ -41,7 +38,6 @@ vim +365 security/loadpin/loadpin.c 3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 370 return -EINVAL; 3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 371 } 3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 372 } -3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 373 -- 0-DAY CI Kernel Test Service diff --git a/a/content_digest b/N2/content_digest index beb0e5e..515d058 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,22 +1,18 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0security/loadpin/loadpin.c:365 dm_verity_ioctl() warn: maybe return -EFAULT instead of the bytes remaining?\0" - "Date\0Sun, 14 Aug 2022 11:47:15 +0800\0" - "To\0kbuild@lists.01.org\0" - "\01:1\0" + "Date\0Mon, 15 Aug 2022 11:07:12 +0300\0" + "To\0kbuild@lists.01.org" + " Matthias Kaehlcke <mka@chromium.org>\0" + "Cc\0lkp@intel.com" + kbuild-all@lists.01.org + linux-kernel@vger.kernel.org + " Kees Cook <keescook@chromium.org>\0" + "\00:1\0" "b\0" - "BCC: lkp(a)intel.com\n" - "CC: kbuild-all(a)lists.01.org\n" - "CC: linux-kernel(a)vger.kernel.org\n" - "TO: Matthias Kaehlcke <mka@chromium.org>\n" - "CC: Kees Cook <keescook@chromium.org>\n" - "\n" "tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master\n" "head: aea23e7c464bfdec04b52cf61edb62030e9e0d0a\n" "commit: 3f805f8cc23ba35679dd01446929292911c2b469 LoadPin: Enable loading from trusted dm-verity devices\n" - "date: 5 weeks ago\n" - ":::::: branch date: 3 hours ago\n" - ":::::: commit date: 5 weeks ago\n" - "config: s390-randconfig-m031-20220810 (https://download.01.org/0day-ci/archive/20220814/202208141119.RKGSGoZ7-lkp(a)intel.com/config)\n" + "config: s390-randconfig-m031-20220810 (https://download.01.org/0day-ci/archive/20220814/202208141119.RKGSGoZ7-lkp@intel.com/config)\n" "compiler: s390-linux-gcc (GCC) 12.1.0\n" "\n" "If you fix the issue, kindly add following tag where applicable\n" @@ -28,7 +24,6 @@ "\n" "vim +365 security/loadpin/loadpin.c\n" "\n" - "3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 354 \n" "3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 355 static long dm_verity_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)\n" "3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 356 {\n" "3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 357 \tvoid __user *uarg = (void __user *)arg;\n" @@ -40,6 +35,13 @@ "3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 363 \t\trc = copy_from_user(&fd, uarg, sizeof(fd));\n" "3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 364 \t\tif (rc)\n" "3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 @365 \t\t\treturn rc;\n" + "\n" + "The copy_from_user() function returns the number of bytes remaining to\n" + "be copied. It should be:\n" + "\n" + "\tif (copy_from_user(&fd, uarg, sizeof(fd)))\n" + "\t\treturn -EFAULT;\n" + "\n" "3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 366 \n" "3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 367 \t\treturn read_trusted_verity_root_digests(fd);\n" "3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 368 \n" @@ -47,10 +49,9 @@ "3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 370 \t\treturn -EINVAL;\n" "3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 371 \t}\n" "3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 372 }\n" - "3f805f8cc23ba3 Matthias Kaehlcke 2022-06-27 373 \n" "\n" "-- \n" "0-DAY CI Kernel Test Service\n" https://01.org/lkp -a0a311407d192764ae337b7cd154ee84c56a8e4b6a107c6a769610c26c04fb88 +845981a30865c42d3f4e10b03349141be86c4e443534282c2bb5658a93fd5447
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.