From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDBB7C00140 for ; Mon, 15 Aug 2022 08:01:59 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 10641848D5; Mon, 15 Aug 2022 10:01:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="pLBkUgEE"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C1A24848DB; Mon, 15 Aug 2022 10:01:55 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D088284854 for ; Mon, 15 Aug 2022 10:01:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D4AEB60EFD; Mon, 15 Aug 2022 08:01:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E2B1C433D6; Mon, 15 Aug 2022 08:01:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660550510; bh=ftv6nqw39jzDGoH8hoE3uTQww/g7jidDxQ2sss8hyYc=; h=From:To:Cc:Subject:Date:From; b=pLBkUgEEcovbbAAU1tlhByk+90OJlXYv3B5hyc45ziPo6jWnTpGrjeb7LQ3d9CjTd HFecXN41Xm+mBxf+ijGY1ir3csKqTx8TPnkp2zG7NT9BguBHUUutGvHrv4g3KF02pd uWCTeM9lgOw0sJvrNVMznc2EdKTWewZAkOOnPRDM+3FzkS4rKL6iQ6cgntVPMdX5PX 8OSVPv/SwIT9y2BC5nTnXfNYYhLN7tooBJqoNSu5t+GhoHSmMdC5Z6iyqIhALCz0g0 FKAult65eJG1OyhT5f04IZ4Mq5YkJWRm0XRbkhXvyUkgv0F/105tLRw4iSp8QCM3Ef GY7cSudGs6dXg== Received: by pali.im (Postfix) id 5C6ECBE0; Mon, 15 Aug 2022 10:01:47 +0200 (CEST) From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Dario Binacchi , Michael Trimarchi Cc: Scott Wood , u-boot@lists.denx.de Subject: [PATCH] mtd: rawnand: fsl_elbc: Remove NAND_NO_SUBPAGE_WRITE flag Date: Mon, 15 Aug 2022 10:01:40 +0200 Message-Id: <20220815080140.4048-1-pali@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Subpage write support for freescale eLBC NAND controller driver is implemented in U-Boot and was fixes in the commit d3963721d93f ("nand: Sync with Linux v4.1"). So remove NAND_NO_SUBPAGE_WRITE flag from the fsl_elbc_nand.c driver. This partially revert commit cb04c7723429 ("nand/fsl: add NAND_NO_SUBPAGE_WRITE to eLBC and IFC drivers"), only eLBC driver part. With this change U-Boot with default settings can read from NAND UBIFS image created on Linux with Linux default settings. Prior this change U-Boot was unable to read from NAND UBIFS images created with Linux default settings due to differnet UBI geometry. Linux kernel fsl_elbc_nand.c driver also does not set NAND_NO_SUBPAGE_WRITE flag and has implemented subpage write support. Fixes: cb04c7723429 ("nand/fsl: add NAND_NO_SUBPAGE_WRITE to eLBC and IFC drivers") Fixes: d3963721d93f ("nand: Sync with Linux v4.1") Signed-off-by: Pali Rohár --- See also email thread: https://lore.kernel.org/u-boot/20220807120027.2zz43afbqtqljhul@pali/t/#u --- drivers/mtd/nand/raw/fsl_elbc_nand.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mtd/nand/raw/fsl_elbc_nand.c b/drivers/mtd/nand/raw/fsl_elbc_nand.c index 48a3687f2728..e28670a4724a 100644 --- a/drivers/mtd/nand/raw/fsl_elbc_nand.c +++ b/drivers/mtd/nand/raw/fsl_elbc_nand.c @@ -732,7 +732,6 @@ static int fsl_elbc_chip_init(int devnum, u8 *addr, struct udevice *dev) nand->bbt_md = &bbt_mirror_descr; /* set up nand options */ - nand->options = NAND_NO_SUBPAGE_WRITE; nand->bbt_options = NAND_BBT_USE_FLASH; nand->controller = &elbc_ctrl->controller; -- 2.20.1