From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: buildroot@buildroot.org
Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Jagan Teki <jagan@amarulasolutions.com>,
"Yann E . MORIN" <yann.morin.1998@free.fr>
Subject: [Buildroot] [PATCH 1/4] Revert "configs/olimex_a33_olinuxino: use NEON+VFPv4 as FPU strategy"
Date: Mon, 15 Aug 2022 17:48:51 +0200 [thread overview]
Message-ID: <20220815154854.17628-2-giulio.benetti@benettiengineering.com> (raw)
In-Reply-To: <20220815154854.17628-1-giulio.benetti@benettiengineering.com>
The gcc man page states that specifying Neon as part of the fpu setting
has no effect, unless the -funsafe-math-optimizations is also specified,
because Neon is not compliant with IEEE 754:
```
If the selected floating-point hardware includes the NEON extension
(e.g. -mfpu=neon), note that floating-point operations are not
generated by GCC's auto-vectorization pass unless
-funsafe-math-optimizations is also specified. This is because NEON
hardware does not fully implement the IEEE 754 standard for
floating-point arithmetic (in particular denormal values are treated
as zero), so the use of NEON instructions may lead to a loss of
precision.
```
-funsafe-math-optimizations must be explictly specified per package to
really use NEON as FPU, but it's something that is left to the user as
well as setting BR2_ARM_FPU_NEON_VFPV4. This way the default
BR2_ARM_FPU_VFPV4D16 is used as previously. So let's revert the
offending patch.
This reverts commit 23329364e206d5ca67a9eb9c733d3d556ccdbac4.
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
configs/olimex_a33_olinuxino_defconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/configs/olimex_a33_olinuxino_defconfig b/configs/olimex_a33_olinuxino_defconfig
index 27924b9e92..cdbc63efe1 100644
--- a/configs/olimex_a33_olinuxino_defconfig
+++ b/configs/olimex_a33_olinuxino_defconfig
@@ -1,7 +1,6 @@
# Architecture
BR2_arm=y
BR2_cortex_a7=y
-BR2_ARM_FPU_NEON_VFPV4=y
# Linux headers same as kernel, a 5.14 series
BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_14=y
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-08-15 15:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 15:48 [Buildroot] [PATCH 0/4] Revert wrong NEON/VFPV4 FPU strategy Giulio Benetti
2022-08-15 15:48 ` Giulio Benetti [this message]
2022-08-16 20:46 ` [Buildroot] [PATCH 1/4] Revert "configs/olimex_a33_olinuxino: use NEON+VFPv4 as FPU strategy" Arnout Vandecappelle
2022-08-18 23:20 ` Giulio Benetti
2022-09-16 21:46 ` Peter Korsgaard
2022-08-15 15:48 ` [Buildroot] [PATCH 2/4] Revert "configs/olimex_a20_olinuxino_lime2: " Giulio Benetti
2022-09-16 21:46 ` Peter Korsgaard
2022-08-15 15:48 ` [Buildroot] [PATCH 3/4] Revert "configs/olimex_a20_olinuxino_lime: " Giulio Benetti
2022-09-16 21:46 ` Peter Korsgaard
2022-08-15 15:48 ` [Buildroot] [PATCH 4/4] Revert "configs/bananapi_m1: " Giulio Benetti
2022-09-16 21:47 ` Peter Korsgaard
2022-08-15 19:05 ` [Buildroot] [PATCH 0/4] Revert wrong NEON/VFPV4 FPU strategy Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220815154854.17628-2-giulio.benetti@benettiengineering.com \
--to=giulio.benetti@benettiengineering.com \
--cc=buildroot@buildroot.org \
--cc=jagan@amarulasolutions.com \
--cc=luca.ceresoli@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.