From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Francois Perrad <fperrad@gmail.com>
Cc: buildroot@busybox.net
Subject: Re: [Buildroot] [PATCH 3/4] package/freescale-imx: rename FREESCALE_IMX_EXTRACT_HELPER to NXP_EXTRACT_HELPER
Date: Mon, 15 Aug 2022 21:02:11 +0200 [thread overview]
Message-ID: <20220815190211.GG2854108@scaer> (raw)
In-Reply-To: <20220815165632.1278597-3-francois.perrad@gadz.org>
On 2022-08-15 18:56 +0200, Francois Perrad spake thusly:
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
This comit log was bit too short, so I extended it with a rationale for
the renaming.
Applied to next, thanks.
Regards,
Yann E. MORIN.
> ---
> package/freescale-imx/firmware-imx/firmware-imx.mk | 2 +-
> package/freescale-imx/gpu-amd-bin-mx51/gpu-amd-bin-mx51.mk | 2 +-
> package/freescale-imx/imx-codec/imx-codec.mk | 2 +-
> package/freescale-imx/imx-gpu-g2d/imx-gpu-g2d.mk | 2 +-
> package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk | 2 +-
> package/freescale-imx/imx-parser/imx-parser.mk | 2 +-
> package/freescale-imx/imx-sc-firmware/imx-sc-firmware.mk | 2 +-
> package/freescale-imx/imx-seco/imx-seco.mk | 2 +-
> package/freescale-imx/imx-vpu-hantro-vc/imx-vpu-hantro-vc.mk | 2 +-
> package/freescale-imx/imx-vpu-hantro/imx-vpu-hantro.mk | 2 +-
> package/freescale-imx/imx-vpu/imx-vpu.mk | 2 +-
> package/freescale-imx/imx-vpuwrap/imx-vpuwrap.mk | 2 +-
> package/freescale-imx/libz160/libz160.mk | 2 +-
> package/pkg-utils.mk | 4 ++--
> 14 files changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/package/freescale-imx/firmware-imx/firmware-imx.mk b/package/freescale-imx/firmware-imx/firmware-imx.mk
> index 47c21585a..4884079d5 100644
> --- a/package/freescale-imx/firmware-imx/firmware-imx.mk
> +++ b/package/freescale-imx/firmware-imx/firmware-imx.mk
> @@ -15,7 +15,7 @@ FIRMWARE_IMX_REDISTRIBUTE = NO
> FIRMWARE_IMX_INSTALL_IMAGES = YES
>
> define FIRMWARE_IMX_EXTRACT_CMDS
> - $(call FREESCALE_IMX_EXTRACT_HELPER,$(FIRMWARE_IMX_DL_DIR)/$(FIRMWARE_IMX_SOURCE))
> + $(call NXP_EXTRACT_HELPER,$(FIRMWARE_IMX_DL_DIR)/$(FIRMWARE_IMX_SOURCE))
> endef
>
> #
> diff --git a/package/freescale-imx/gpu-amd-bin-mx51/gpu-amd-bin-mx51.mk b/package/freescale-imx/gpu-amd-bin-mx51/gpu-amd-bin-mx51.mk
> index c99c568f7..895fedc2e 100644
> --- a/package/freescale-imx/gpu-amd-bin-mx51/gpu-amd-bin-mx51.mk
> +++ b/package/freescale-imx/gpu-amd-bin-mx51/gpu-amd-bin-mx51.mk
> @@ -23,7 +23,7 @@ GPU_AMD_BIN_MX51_LICENSE_FILES = EULA
> GPU_AMD_BIN_MX51_REDISTRIBUTE = NO
>
> define GPU_AMD_BIN_MX51_EXTRACT_CMDS
> - $(call FREESCALE_IMX_EXTRACT_HELPER,$(GPU_AMD_BIN_MX51_DL_DIR)/$(GPU_AMD_BIN_MX51_SOURCE))
> + $(call NXP_EXTRACT_HELPER,$(GPU_AMD_BIN_MX51_DL_DIR)/$(GPU_AMD_BIN_MX51_SOURCE))
> endef
>
> # Upstream headers need to be compiled with -D_LINUX. It is more convenient
> diff --git a/package/freescale-imx/imx-codec/imx-codec.mk b/package/freescale-imx/imx-codec/imx-codec.mk
> index 1ec701d2f..2b7c346a6 100644
> --- a/package/freescale-imx/imx-codec/imx-codec.mk
> +++ b/package/freescale-imx/imx-codec/imx-codec.mk
> @@ -26,7 +26,7 @@ IMX_CODEC_CONF_OPTS += --enable-vpu
> endif
>
> define IMX_CODEC_EXTRACT_CMDS
> - $(call FREESCALE_IMX_EXTRACT_HELPER,$(IMX_CODEC_DL_DIR)/$(IMX_CODEC_SOURCE))
> + $(call NXP_EXTRACT_HELPER,$(IMX_CODEC_DL_DIR)/$(IMX_CODEC_SOURCE))
> endef
>
> # FIXME The Makefile installs both the arm9 and arm11 versions of the
> diff --git a/package/freescale-imx/imx-gpu-g2d/imx-gpu-g2d.mk b/package/freescale-imx/imx-gpu-g2d/imx-gpu-g2d.mk
> index 0e4078a96..c5df87e61 100644
> --- a/package/freescale-imx/imx-gpu-g2d/imx-gpu-g2d.mk
> +++ b/package/freescale-imx/imx-gpu-g2d/imx-gpu-g2d.mk
> @@ -19,7 +19,7 @@ IMX_GPU_G2D_LICENSE_FILES = EULA COPYING
> IMX_GPU_G2D_REDISTRIBUTE = NO
>
> define IMX_GPU_G2D_EXTRACT_CMDS
> - $(call FREESCALE_IMX_EXTRACT_HELPER,$(IMX_GPU_G2D_DL_DIR)/$(IMX_GPU_G2D_SOURCE))
> + $(call NXP_EXTRACT_HELPER,$(IMX_GPU_G2D_DL_DIR)/$(IMX_GPU_G2D_SOURCE))
> endef
>
> define IMX_GPU_G2D_INSTALL_STAGING_CMDS
> diff --git a/package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk b/package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk
> index 1d76d79e2..63d5d3c2e 100644
> --- a/package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk
> +++ b/package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk
> @@ -44,7 +44,7 @@ IMX_GPU_VIV_DEPENDENCIES += wayland
> endif
>
> define IMX_GPU_VIV_EXTRACT_CMDS
> - $(call FREESCALE_IMX_EXTRACT_HELPER,$(IMX_GPU_VIV_DL_DIR)/$(IMX_GPU_VIV_SOURCE))
> + $(call NXP_EXTRACT_HELPER,$(IMX_GPU_VIV_DL_DIR)/$(IMX_GPU_VIV_SOURCE))
> endef
>
> ifeq ($(IMX_GPU_VIV_LIB_TARGET),fb)
> diff --git a/package/freescale-imx/imx-parser/imx-parser.mk b/package/freescale-imx/imx-parser/imx-parser.mk
> index fc4376f04..dccb8829d 100644
> --- a/package/freescale-imx/imx-parser/imx-parser.mk
> +++ b/package/freescale-imx/imx-parser/imx-parser.mk
> @@ -24,7 +24,7 @@ IMX_PARSER_CONF_OPTS += --enable-fsw
> endif
>
> define IMX_PARSER_EXTRACT_CMDS
> - $(call FREESCALE_IMX_EXTRACT_HELPER,$(IMX_PARSER_DL_DIR)/$(IMX_PARSER_SOURCE))
> + $(call NXP_EXTRACT_HELPER,$(IMX_PARSER_DL_DIR)/$(IMX_PARSER_SOURCE))
> endef
>
> # The Makefile installs several versions of the libraries, but we only
> diff --git a/package/freescale-imx/imx-sc-firmware/imx-sc-firmware.mk b/package/freescale-imx/imx-sc-firmware/imx-sc-firmware.mk
> index bbb731030..6a304c0c8 100644
> --- a/package/freescale-imx/imx-sc-firmware/imx-sc-firmware.mk
> +++ b/package/freescale-imx/imx-sc-firmware/imx-sc-firmware.mk
> @@ -13,7 +13,7 @@ IMX_SC_FIRMWARE_LICENSE_FILES = EULA COPYING
> IMX_SC_FIRMWARE_REDISTRIBUTE = NO
>
> define IMX_SC_FIRMWARE_EXTRACT_CMDS
> - $(call FREESCALE_IMX_EXTRACT_HELPER,$(IMX_SC_FIRMWARE_DL_DIR)/$(IMX_SC_FIRMWARE_SOURCE))
> + $(call NXP_EXTRACT_HELPER,$(IMX_SC_FIRMWARE_DL_DIR)/$(IMX_SC_FIRMWARE_SOURCE))
> endef
>
> IMX_SC_FIRMWARE_INSTALL_IMAGES = YES
> diff --git a/package/freescale-imx/imx-seco/imx-seco.mk b/package/freescale-imx/imx-seco/imx-seco.mk
> index 79c9722c4..987f24658 100644
> --- a/package/freescale-imx/imx-seco/imx-seco.mk
> +++ b/package/freescale-imx/imx-seco/imx-seco.mk
> @@ -13,7 +13,7 @@ IMX_SECO_LICENSE_FILES = EULA COPYING
> IMX_SECO_REDISTRIBUTE = NO
>
> define IMX_SECO_EXTRACT_CMDS
> - $(call FREESCALE_IMX_EXTRACT_HELPER,$(IMX_SECO_DL_DIR)/$(IMX_SECO_SOURCE))
> + $(call NXP_EXTRACT_HELPER,$(IMX_SECO_DL_DIR)/$(IMX_SECO_SOURCE))
> endef
>
> IMX_SECO_INSTALL_IMAGES = YES
> diff --git a/package/freescale-imx/imx-vpu-hantro-vc/imx-vpu-hantro-vc.mk b/package/freescale-imx/imx-vpu-hantro-vc/imx-vpu-hantro-vc.mk
> index b07e11667..5f4c6faee 100644
> --- a/package/freescale-imx/imx-vpu-hantro-vc/imx-vpu-hantro-vc.mk
> +++ b/package/freescale-imx/imx-vpu-hantro-vc/imx-vpu-hantro-vc.mk
> @@ -14,7 +14,7 @@ IMX_VPU_HANTRO_VC_LICENSE_FILES = EULA COPYING
> IMX_VPU_HANTRO_VC_REDISTRIBUTE = NO
>
> define IMX_VPU_HANTRO_VC_EXTRACT_CMDS
> - $(call FREESCALE_IMX_EXTRACT_HELPER,$(IMX_VPU_HANTRO_VC_DL_DIR)/$(IMX_VPU_HANTRO_VC_SOURCE))
> + $(call NXP_EXTRACT_HELPER,$(IMX_VPU_HANTRO_VC_DL_DIR)/$(IMX_VPU_HANTRO_VC_SOURCE))
> endef
>
> define IMX_VPU_HANTRO_VC_INSTALL_TARGET_CMDS
> diff --git a/package/freescale-imx/imx-vpu-hantro/imx-vpu-hantro.mk b/package/freescale-imx/imx-vpu-hantro/imx-vpu-hantro.mk
> index 360591b44..9d34c7add 100644
> --- a/package/freescale-imx/imx-vpu-hantro/imx-vpu-hantro.mk
> +++ b/package/freescale-imx/imx-vpu-hantro/imx-vpu-hantro.mk
> @@ -23,7 +23,7 @@ IMX_VPU_HANTRO_LICENSE_FILES = EULA COPYING
> IMX_VPU_HANTRO_REDISTRIBUTE = NO
>
> define IMX_VPU_HANTRO_EXTRACT_CMDS
> - $(call FREESCALE_IMX_EXTRACT_HELPER,$(IMX_VPU_HANTRO_DL_DIR)/$(IMX_VPU_HANTRO_SOURCE))
> + $(call NXP_EXTRACT_HELPER,$(IMX_VPU_HANTRO_DL_DIR)/$(IMX_VPU_HANTRO_SOURCE))
> endef
>
> define IMX_VPU_HANTRO_BUILD_CMDS
> diff --git a/package/freescale-imx/imx-vpu/imx-vpu.mk b/package/freescale-imx/imx-vpu/imx-vpu.mk
> index 14a1a7a9f..cae3d88b6 100644
> --- a/package/freescale-imx/imx-vpu/imx-vpu.mk
> +++ b/package/freescale-imx/imx-vpu/imx-vpu.mk
> @@ -21,7 +21,7 @@ IMX_VPU_LICENSE_FILES = EULA COPYING
> IMX_VPU_REDISTRIBUTE = NO
>
> define IMX_VPU_EXTRACT_CMDS
> - $(call FREESCALE_IMX_EXTRACT_HELPER,$(IMX_VPU_DL_DIR)/$(IMX_VPU_SOURCE))
> + $(call NXP_EXTRACT_HELPER,$(IMX_VPU_DL_DIR)/$(IMX_VPU_SOURCE))
> endef
>
> define IMX_VPU_BUILD_CMDS
> diff --git a/package/freescale-imx/imx-vpuwrap/imx-vpuwrap.mk b/package/freescale-imx/imx-vpuwrap/imx-vpuwrap.mk
> index 4f8916540..4bee1cf64 100644
> --- a/package/freescale-imx/imx-vpuwrap/imx-vpuwrap.mk
> +++ b/package/freescale-imx/imx-vpuwrap/imx-vpuwrap.mk
> @@ -22,7 +22,7 @@ IMX_VPUWRAP_LICENSE_FILES = EULA COPYING
> IMX_VPUWRAP_REDISTRIBUTE = NO
>
> define IMX_VPUWRAP_EXTRACT_CMDS
> - $(call FREESCALE_IMX_EXTRACT_HELPER,$(IMX_VPUWRAP_DL_DIR)/$(IMX_VPUWRAP_SOURCE))
> + $(call NXP_EXTRACT_HELPER,$(IMX_VPUWRAP_DL_DIR)/$(IMX_VPUWRAP_SOURCE))
> endef
>
> $(eval $(autotools-package))
> diff --git a/package/freescale-imx/libz160/libz160.mk b/package/freescale-imx/libz160/libz160.mk
> index 5b1feeb44..a15b5f6b6 100644
> --- a/package/freescale-imx/libz160/libz160.mk
> +++ b/package/freescale-imx/libz160/libz160.mk
> @@ -15,7 +15,7 @@ LIBZ160_LICENSE_FILES = EULA
> LIBZ160_REDISTRIBUTE = NO
>
> define LIBZ160_EXTRACT_CMDS
> - $(call FREESCALE_IMX_EXTRACT_HELPER,$(LIBZ160_DL_DIR)/$(LIBZ160_SOURCE))
> + $(call NXP_EXTRACT_HELPER,$(LIBZ160_DL_DIR)/$(LIBZ160_SOURCE))
> endef
>
> define LIBZ160_INSTALL_STAGING_CMDS
> diff --git a/package/pkg-utils.mk b/package/pkg-utils.mk
> index 57f4af04c..32a5c8c95 100644
> --- a/package/pkg-utils.mk
> +++ b/package/pkg-utils.mk
> @@ -276,7 +276,7 @@ legal-deps = \
> $(call non-virtual-deps,\
> $($(call UPPERCASE,$(1))_FINAL_RECURSIVE_DEPENDENCIES))),$(p) [$($(call UPPERCASE,$(p))_LICENSE)])
>
> -# Helper for self-extracting binaries distributed by Freescale.
> +# Helper for self-extracting binaries distributed by NXP.
> #
> # The --force option makes sure it doesn't fail if the source
> # directory already exists. The --auto-accept skips the license check,
> @@ -290,7 +290,7 @@ legal-deps = \
> #
> # $(1): full path to the archive file
> #
> -define FREESCALE_IMX_EXTRACT_HELPER
> +define NXP_EXTRACT_HELPER
> awk 'BEGIN { start = 0; } \
> /^EOEULA/ { start = 0; } \
> { if (start) print; } \
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-08-15 19:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 16:56 [Buildroot] [PATCH 1/4] package/qoriq-cadence-dp-firmware: fix license info Francois Perrad
2022-08-15 16:56 ` [Buildroot] [PATCH 2/4] package/pkg-utils.mk: move FREESCALE_IMX_EXTRACT_HELPER Francois Perrad
2022-08-15 19:01 ` Yann E. MORIN
2022-08-15 16:56 ` [Buildroot] [PATCH 3/4] package/freescale-imx: rename FREESCALE_IMX_EXTRACT_HELPER to NXP_EXTRACT_HELPER Francois Perrad
2022-08-15 19:02 ` Yann E. MORIN [this message]
2022-08-15 16:56 ` [Buildroot] [PATCH 4/4] package/qoriq-cadence-dp-firmware: refactor with NXP_EXTRACT_HELPER Francois Perrad
2022-08-15 19:02 ` Yann E. MORIN
2022-08-15 18:46 ` [Buildroot] [PATCH 1/4] package/qoriq-cadence-dp-firmware: fix license info Yann E. MORIN
2022-09-16 14:11 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220815190211.GG2854108@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
--cc=fperrad@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.